Matt Bierner
e1f0f8f513
Add override keyword in codebase ( #120755 )
...
For #120675
This uses a script to add the override keyword to places that need it in the codebase
Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
2021-04-08 10:05:20 -07:00
Jackson Kearl
2ba67b7b07
Allow ripgrep search provider to work for files backed by file scheme, but not file scheme themselves (vscode-userdata) ( #118069 )
...
* Allow ripgrep search provider to work for files backed by file scheme, but not file scheme themselves (vscode-userdata)
Fixes #115434
* Only execute new code path for userData scheme
* Differentiate output channels
2021-03-03 21:13:58 -08:00
Matt Bierner
1b70625f8c
Use import type when importing vscode under src
...
When the core references `vscode`, we only want to import the types and never generate a real import (which will fail to load). Use `import type` to better enforce this
2020-01-10 14:25:21 -08:00
Benjamin Pasero
1a1e7c9545
debt - allow extHostSearch in common ( #84109 )
...
* debt - allow extHostSearch in common
* web - implement text search provider
* fix text search
* Update extensions/vscode-api-tests/src/extension.ts
Co-Authored-By: Rob Lourens <roblourens@gmail.com >
2019-11-12 18:57:08 +01:00
Benjamin Pasero
f692972925
debt - move fileSearchManager to common (for #84106 )
2019-11-07 07:28:19 +01:00
Rob Lourens
779e29a41c
Fix some strictPropertyInitialization in search, #78168
2019-09-03 14:28:28 -07:00
Johannes Rieken
7a6f22b3af
rename rpcService to extHostRpcService
2019-08-09 09:51:22 +02:00
Johannes Rieken
f47bf93da9
add search to injector
2019-08-08 10:08:57 +02:00
Alex Dima
9fb9ca51a6
Add transformOutgoingScheme to IURITransformer
2019-05-24 12:46:48 +02:00
Benjamin Pasero
84726e51f4
debt - merge extfs and pfs
2019-04-01 08:45:46 +02:00
Johannes Rieken
97cc9b15ba
implicit any, #70352
2019-03-22 09:11:36 +01:00
Johannes Rieken
c92ce4014f
move extHost.protocol to common, #70319
2019-03-19 15:46:01 +01:00
SteVen Batten
bf5e12e923
consolidate search into common ( #69614 )
2019-03-08 16:43:13 -08:00
Rob Lourens
a09e7bd128
Fix #64575 - delete FileIndexProvider
2019-03-07 05:33:35 +00:00
Rob Lourens
cbff363641
Strict null check extHostSearch.ts
2019-02-11 17:48:57 -08:00
Matt Bierner
9ee6077373
Strict null work in extHost
2019-02-11 09:31:13 -08:00
Benjamin Pasero
7c1fe9a7d6
debt - move search out of platform
2019-02-09 17:02:31 +01:00
Rob Lourens
19adeb1620
Simplify extHostSearch
2019-01-16 12:27:35 +01:00
Alex Dima
2fe9de8511
Initialize configuration data through ExtHostConfiguration
2019-01-14 17:28:14 +01:00
Johannes Rieken
653280d133
debt - Thenable -> Promise
2018-12-13 11:31:54 +01:00
Rob Lourens
6f9b2d7593
Fix #59922 - changes needed to support a cache in a FileSearchProvider
2018-12-03 16:19:37 -08:00
Rob Lourens
96f7df4336
Refactor file search - use new interface for SearchService.fileSearch
2018-10-22 11:35:41 -07:00
Rob Lourens
0c1c02c827
Limit search provider extensions to one per scheme
2018-10-19 21:40:47 -07:00
Johannes Rieken
45f4904378
debt remove TPromise from extHost-files #53526
2018-10-19 09:49:05 +02:00
Rob Lourens
b17e21d0ad
Split text and file search interfaces
2018-10-18 16:49:58 -07:00
Rob Lourens
4b5f23f4ca
Move all old text search code under legacy/
2018-10-18 16:48:39 -07:00
Rob Lourens
2fdd6c1021
Refactor search - add config to run search in EH
2018-10-15 22:50:20 -07:00
Rob Lourens
a32b10881b
Run file search in EH
2018-10-15 21:35:10 -07:00
Rob Lourens
5c23d38a09
Refactor search - move file search code out of ExtHostSearch
...
Not generic now, maybe in the future
2018-10-15 21:35:10 -07:00
Rob Lourens
e07cacd1f2
Refactor search - rename files
2018-10-15 16:28:31 -07:00
Rob Lourens
c26d6e6c93
Refactor text seach
...
To allow better code sharing between EH and search proc
2018-10-15 16:28:31 -07:00
Rob Lourens
ee40fa3e0d
Text search in EH
2018-10-15 16:28:31 -07:00
Rob Lourens
3d3df21a92
Fix #50676 - unreponsive window for some searches in EH
2018-10-12 16:48:35 -07:00
Rob Lourens
38a2c24ca2
Merge pull request #59717 from skprabhanjan/fix-59364
...
Fix #59364 : Respect global .gitignore when searching
2018-10-04 11:40:23 -07:00
Matt Bierner
f7456ebf90
Switch to use standard @types/node types instead of our customized version
...
Using a custom version of the node typings is causing a lot of pain while trying to upgrade our build to use `@types` instead of the `d.ts` files we have to maintain. I believe we primarily maintain our own version for two reason:
- Custom require function
- setTimeout and other timer functions return NodeJs.timer instead of a number
These can both be delt with, the first by using interface augmentation and the second by switching to use any types for timer. I believe that the pain of maintaining our own node `d.ts` outweighs the benefits here
This change switches us to use the standard @types/node package for our node typings
2018-10-03 14:18:36 -07:00
Matt Bierner
8087b0a8d8
Remove use strict directives in main vs code ts files (part 2)
...
We compile using the alwaysStrict flag so these directives are not needed
This part removes most `use strict` directives that are right after the file header
2018-10-02 16:11:05 -07:00
pkoushik
c4928076b7
fix #59364 - Review #2
2018-10-02 19:35:18 +05:30
Rob Lourens
f3654c59e0
Fix #55790 - allow extensions to return a hitLimit flag
2018-09-17 22:48:12 -07:00
Rob Lourens
b7e684c508
Fix TPromise#cancel in FileIndexProvider #56137
2018-09-10 11:21:47 -07:00
Rob Lourens
44dc55b9fc
Fix #57951 - remove $cancelSearch
2018-09-05 16:51:16 -07:00
Johannes Rieken
670719d22a
use CancellationToken over cancel-callback and cancel-calls
2018-09-05 15:02:15 +02:00
Rob Lourens
497ea886b7
#56137 - remove more TPromise#cancel from search
2018-09-03 17:06:46 -07:00
Johannes Rieken
3c727a6d01
uri - replace usages of default export with named export (part 2)
2018-09-03 11:04:26 +02:00
Rob Lourens
de70176d06
Fix #57186 , Fix #31551 - implement previewOptions for text search API
2018-08-24 20:37:08 -07:00
Rob Lourens
34b3302bb4
#56950 - add details to text search telemetry
2018-08-22 18:45:43 -07:00
Rob Lourens
dd13d47e02
#56950 - add search telemetry for EH-based search
2018-08-21 19:58:55 -07:00
Rob Lourens
00649474f2
#55883 - remove some TPromise#cancel from extHostSearch
2018-08-19 21:22:31 -07:00
Rob Lourens
c86cab2211
SearchProvider - fix NPE when searching extraFileResources
2018-08-01 21:27:18 -07:00
Rob Lourens
49bbb88160
Fix FileSearchProvider unit tests for progress change
2018-08-01 13:39:21 -07:00
Rob Lourens
e69e4d3a47
Search provider - Fix FileSearchProvider to return array, not progress
2018-08-01 11:44:51 -07:00