Commit Graph

38 Commits

Author SHA1 Message Date
Benjamin Pasero 51ed283cc5 :chore: some code cleanup
- use readonly for static ids
- prefer undefined over null in my code
- remove some obsolete todos
- do not require Promise from action.run()
2021-05-03 10:53:26 +02:00
Matt Bierner e1f0f8f513 Add override keyword in codebase (#120755)
For #120675

This uses a script to add the override keyword to places that need it in the codebase

Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
2021-04-08 10:05:20 -07:00
Benjamin Pasero 1c9e7eb296 💄 2021-03-12 13:59:52 +01:00
Benjamin Pasero 5a8936ae63 Lift native text file service to electron-sandbox (#118815)
* sandbox - lift native text file service to electron-sandbox

* polish docs and ensure tests actually run

* add write unlock capability

* do not use fs constants (fix tests)
2021-03-12 13:52:00 +01:00
Martin Aeschlimann f311b19b64 filewatcher: allow to specify path globs for polling 2021-02-10 14:55:14 +01:00
Benjamin Pasero cb537dd4e8 fs - provide a fallback when readdir with filetypes fails (#115645) 2021-02-04 14:27:50 +01:00
Benjamin Pasero 2d31774a52 fs - provide an option to copy to preserve symlinks or not 2021-02-03 16:37:10 +01:00
Benjamin Pasero aca5d3ea2e fs - merge readdir functions into one 2021-02-03 12:07:48 +01:00
Benjamin Pasero b28cd23d52 fs - more removal of promisify utility 2021-02-03 11:29:26 +01:00
Benjamin Pasero dbf6147c01 fs - remove promise based methods from pfs and replace with fs.promises 2021-02-03 11:20:14 +01:00
Benjamin Pasero a17c656c33 fs - some polish around file services 2021-02-03 10:32:30 +01:00
Benjamin Pasero 0677d5e6f6 fs - sort pfs and introduce SymlinkSupport namespace 2021-02-02 17:33:41 +01:00
Benjamin Pasero f4ab083c28 update todos 2021-01-04 15:17:40 +01:00
ChaseKnowlden e8760a5d6c Fix capitalization of GitHub org 2020-09-17 11:43:03 +02:00
Benjamin Pasero a50bf5d7df files - some more readonly use 2020-07-01 10:20:41 +02:00
Benjamin Pasero f77d676878 files - 💄 2020-06-11 13:44:52 +02:00
Benjamin Pasero 400240489e files - reduce need for stream transformer in io.ts 2020-06-11 12:23:12 +02:00
Benjamin Pasero 9bc5425eaa working copy file service - assert delete/move/copy operations are valid before even attempting them 2020-06-01 08:50:20 +02:00
Benjamin Pasero 7764b06fae 💄 2020-03-30 14:33:39 +02:00
Benjamin Pasero 3f0e5b4ab0 debt - adopt more ES6 things 2020-03-30 14:04:52 +02:00
Benjamin Pasero 2c4c755bc4 fs - add error code for ENOTDIR 2020-03-26 14:33:08 +01:00
Benjamin Pasero aaa3c3e26c Files - deal with dangling symbolic links (fix #90075) 2020-02-05 15:39:22 +01:00
Benjamin Pasero c739b34b50 vscode.workspace.fs.readDirectory() ignores broken symlinks. (fix #90031) 2020-02-05 11:41:50 +01:00
Benjamin Pasero e2fbad5a2c vscode.workspace.fs.readDirectory() reports symlinks to sockets incorrectly. (fix #90032) 2020-02-05 11:31:19 +01:00
Benjamin Pasero d01e111fb0 debt - model reload should happen from model manager 2019-12-10 09:46:04 +01:00
Benjamin Pasero 5ae52b61cb files - implement ctime properly as btime (fix #84525) 2019-11-12 10:42:04 +01:00
Benjamin Pasero c6be0b5480 remote - adopt readFileStream capability 2019-11-04 12:04:19 +01:00
Benjamin Pasero 6f823003a7 files - speed up reads and writes
For reading, introduce the readFileStream capability that reduces
the overhead of low level file reading by switching to an event based
model.

For writing, try to consume up to N chunks of data from the underlying
source and directly call writeFile if the source is consumed. This will avoid
the overhead of low level file reading for small to medium files.
2019-11-04 11:57:45 +01:00
Benjamin Pasero 444567f281 files - skip exists() check if not needed 2019-10-30 18:03:45 +01:00
Benjamin Pasero 935b0f1c0d debt - optional chaining 2019-10-21 15:44:21 +02:00
Benjamin Pasero b2157cbe2e Revert "Revert "debt - adopt new fs.readdir with stat info""
This reverts commit 956208bb05.
2019-10-14 15:32:35 +02:00
Matt Bierner c25e7e90f0 Making IFileChange readonly 2019-09-25 18:30:03 -07:00
Benjamin Pasero 1cba911717 Strict init (#80190)
* strict init

* more strict props
2019-09-02 09:24:43 +02:00
Benjamin Pasero 956208bb05 Revert "debt - adopt new fs.readdir with stat info"
This reverts commit da5fb7d5b8.
2019-08-12 08:23:31 +02:00
Benjamin Pasero 18a4ddc05a files - avoid read/write with pos and prefer null (fix #73884) 2019-08-07 08:00:17 +02:00
Matt Bierner 7411e3f341 Convert many simple getters for events into readonly properties
We seem to use the readonly property way of exposing these values more widely. Standardizing this a bit across the codebase
2019-07-15 16:12:25 -07:00
Sandeep Somavarapu 79186fa045 Merge branch 'master' into sandy081/moveFileService 2019-07-11 11:54:23 +02:00
Sandeep Somavarapu 0df6764710 move file service to platform 2019-07-10 20:55:44 +02:00