61 Commits

Author	SHA1	Message	Date
Matt Bierner	52556f9742	Auto converting let -> const where possible in mainthread and extHost ... Const provides better type guards and can make logic clearer	2019-03-05 16:53:41 -08:00
Peng Lyu	e5dbd34dd3	Merge pull request #69253 from Microsoft/rebornix/commentscontrol ... Comments API refactor	2019-02-22 16:54:39 -08:00
Peng Lyu	bb62f5036d	Support new comment thread creation.	2019-02-22 16:46:49 -08:00
Peng Lyu	4f249529e8	Commenting Ranges API	2019-02-22 12:05:08 -08:00
Peng Lyu	39218635a5	Dispose commentcontrol properly.	2019-02-22 11:29:58 -08:00
Peng Lyu	bcc48091d3	Make sure CommentControl & CommentsProvider handles are unique.	2019-02-22 11:02:23 -08:00
Peng Lyu	de52daea94	edit/delete command	2019-02-20 16:45:50 -08:00
Peng Lyu	38e0c3f2c2	accept input commands.	2019-02-20 16:45:14 -08:00
Matt Bierner	7e759cf3c8	Annotate more usage before assign strict null errors	2019-02-19 16:29:01 -08:00
Peng Lyu	67ad526371	comment control. active thread, comment, input update.	2019-02-15 17:48:03 -08:00
Peng Lyu	54c75aa50b	support icons	2019-02-13 19:34:35 -08:00
Peng Lyu	1789af2b83	Use customized toolbar for reactions.	2019-02-13 19:34:35 -08:00
Peng Lyu	0d50120c71	fix comments npe	2019-02-12 09:19:33 -08:00
Peng Lyu	d50c9d8609	check if users can operate on reactions	2019-02-11 16:32:24 -08:00
Matt Bierner	f1afe72087	Add getDocument helper method ... Many places in `extHostLanguageFeatures` were calling `getDocumentData` without checking if the result is undefined. Add an `getDocument` that cannot return undefined values and instead throws an error if there is no document	2019-02-11 09:31:13 -08:00
Peng Lyu	130fdbee2b	reaction api	2019-01-27 15:06:33 -08:00
rebornix	fe5f523735	Add extension information to comment widget model	2019-01-10 09:58:56 -08:00
Alex Dima	9cf36cdf8f	Rename CanonicalExtensionIdentifier to ExtensionIdentifier	2019-01-07 12:00:54 +01:00
Alex Dima	25417553be	Adopt case insensitive extension identifiers	2018-12-21 12:41:41 +01:00
Rachel Macfarlane	c5c15eb75f	Add document parameter to draft methods on comments provider	2018-12-18 14:57:50 -08:00
Matt Bierner	d40fa4a27e	Review uses of Promise.resolve(null) ... Many `Promise.resolve(null)` should actually be `Promise.resolve(void 0)`. In other cases, we were missing a null return annotation.	2018-12-13 15:41:13 -08:00
Johannes Rieken	c6c7edaa9f	debt - asThenable -> asPromise because it returns a promise	2018-12-13 11:45:48 +01:00
Johannes Rieken	653280d133	debt - Thenable -> Promise	2018-12-13 11:31:54 +01:00
rebornix	9eb6d908e3	remove unused method	2018-11-29 10:38:42 -08:00
rebornix	e877e5c820	comment thread can be updated by draft mode change.	2018-11-29 10:27:27 -08:00
rebornix	8d78edddaa	render pending comment	2018-11-28 16:05:16 -08:00
rebornix	11d48f122e	first cut	2018-11-27 16:02:39 -08:00
Rachel Macfarlane	af1b4ebded	Refactoring comment service to not be keyed on handle	2018-11-08 14:13:43 -08:00
Rachel Macfarlane	36dc10c9f7	Add log for registering workspace comment provider	2018-10-29 15:16:18 -07:00
Johannes Rieken	45f4904378	debt remove TPromise from extHost-files #53526	2018-10-19 09:49:05 +02:00
Matt Bierner	c63c97c128	Remove use strict directives in main vs code ts files ... We compile using the alwaysStrict flag so these directives are not needed	2018-10-02 16:05:44 -07:00
Rachel Macfarlane	b4f4f55f5a	Return void instead of comment from editComment, fixes #59460	2018-09-26 14:39:55 -07:00
Rachel Macfarlane	434059aaf6	Fixes #59449, add docs for CommentInfo and CommentThread, rename gravatar to userIconPath	2018-09-26 14:01:57 -07:00
Rachel Macfarlane	d1dbe4d53c	Add support for deleting comments, #58078	2018-09-18 16:45:41 -07:00
Rachel Macfarlane	1d1105e96b	Add support for editing comments, #58078	2018-09-17 11:22:41 -07:00
Alex Dima	bc374f6279	Reduce usage of asWinJsPromise	2018-09-05 12:26:25 +02:00
Alex Dima	34837504ba	debt - More precise typings	2018-09-05 12:21:06 +02:00
Johannes Rieken	3c727a6d01	uri - replace usages of default export with named export (part 2)	2018-09-03 11:04:26 +02:00
Peng Lyu	c4efd00309	show diff view editor for outdated comments.	2018-05-22 11:37:14 -07:00
Peng Lyu	777075998b	fix failure for api change	2018-05-18 17:03:12 -07:00
Peng Lyu	41f1722166	use explict api instead of commands for commenting.	2018-05-16 19:14:24 -07:00
Peng Lyu	b7a2c2cea1	save pr status to git config	2018-05-01 18:09:59 -07:00
Peng Lyu	faa4bd1fff	null check	2018-04-23 10:09:13 -07:00
Rachel Macfarlane	1920a28289	Separate WorkspaceCommentProvider and DocumentCommentProvider	2018-04-20 15:15:50 -07:00
Peng Lyu	5a3c4d1930	commentProvider can control collapse state of a thread	2018-04-20 15:04:00 -07:00
Peng Lyu	55198cb554	huge refactoring, remove getNewCommentRange	2018-04-19 11:49:45 -07:00
Peng Lyu	8730f9688f	explicit reply comment thread command	2018-04-19 10:36:28 -07:00
Peng Lyu	5c25f5001f	rough incremental update.	2018-04-18 15:05:45 -07:00
Peng Lyu	aed94aee0c	comment service fetch	2018-04-17 17:07:29 -07:00
Rachel Macfarlane	801d3eaacf	Add onDidCommentThreadsChange	2018-04-17 16:48:56 -07:00