Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 09:08:53 +01:00
Code Issues Packages Projects Releases Wiki Activity
37,452 Commits 3,623 Branches 357 Tags
52db14c9e68abae4280a8d4f7ddc52d868901e3a
Commit Graph

240 Commits

Author SHA1 Message Date
Matt Bierner
52db14c9e6 Sort definitions 2018-07-26 17:36:11 -07:00
Matt Bierner
74b5247504 Use more explicit types for ts server execute 
- Only allow known strings to be used as commands
- Simplify overloading. Introduce new `executeWithoutWaitingForResponse` function for calls that are fire and forget
- Always require a token for execture calls
 2018-07-26 17:36:11 -07:00
Matt Bierner
633e386b18 Remove extra conditional 2018-07-26 16:06:05 -07:00
Matt Bierner
5e40bd7df9 Expand js/ts document symbols to have entries for each span 
Fixes #54855
 2018-07-26 16:01:34 -07:00
Matt Bierner
341013c0ef Log warning when returned code action will be dropped (#55090) 
* Add extension logging when returned code action will be dropped

Fixes #54803

Adds a loggin warning when a code action provider returns code actions that will be dropped. Warn in the the following cases:

- A provider returns code actions (not commands)
- And a specific code action type is requested.
- And the returned code actions either don't set kind or are of the wrong kind

* Use log service

* Include extension id in warning
 2018-07-26 15:14:16 -07:00
Matt Bierner
e8b1ee0b4d Use more standard scheme across providers for getting TS response body 
- Avoids extra checks when response cannot be null
 2018-07-25 18:50:16 -07:00
Matt Bierner
a1af04f571 Prefer namespace imports for 'vscode' 2018-07-25 18:34:12 -07:00
Matt Bierner
410509137b Add base Disposable class to help manage disposables 2018-07-25 18:17:56 -07:00
Matt Bierner
f97c743507 Use VersionDependentRegistration for update paths on rename 
Avoids registering class on unsupported ts versions
 2018-07-25 17:56:08 -07:00
Matt Bierner
d5855b35b2 Cleanup 
- Remove noop optional method
- Use double quotes for strings
- Mark fields readonly
 2018-07-25 17:51:05 -07:00
Matt Bierner
42e0c43645 Use resource map for storing formatting options 
Try to normalize file cases on case-insensitive file systems
 2018-07-25 17:47:06 -07:00
Matt Bierner
edc6b2acdd Always invoke quick fix command 
Make sure we always invoke the applyCodeActionCommand. This is needed for telemetry to be sent properly
 2018-07-25 17:29:35 -07:00
Matt Bierner
9e6a525723 Fixing fix all not applying correct commands on edit 2018-07-25 17:27:03 -07:00
Matt Bierner
690744c3c6 Only return a single all code action per quick fix fixId 
Fixes #55065
 2018-07-25 17:19:33 -07:00
Matt Bierner
ccf9f4badd Use VersionDependentRegistration 2018-07-25 17:19:33 -07:00
Matt Bierner
5347a06a46 Don't convert diagnostic set to array 2018-07-25 17:19:33 -07:00
Matt Bierner
8531a230e5 Use flatten in a few places to improve readability 2018-07-20 17:58:43 -07:00
Matt Bierner
f500f659e6 Create links for files section in tsconfig 2018-07-20 17:52:01 -07:00
Matt Bierner
91d55c965a Make sure we disable suggestions properly 2018-07-20 14:32:21 -07:00
Matt Bierner
9fb3229377 Use single diagnostic collection for js and ts 
Refactors the ts DiagnosticManager to be shared between language providers.  To do this:

- Make sure we always maintain a complete list of diagnostics in the extension. But only update the vscode.DiagnosticCollection with the ones we care about

- Add the concept of a diagnostic language. This is needed now that we only have a single collection. Use the diagnostic language to determine which diagnostics to filter out using `typescript.validate` and `javascript.validate`

- Add a diagnosticSetting class to track settings for different languages (js and ts)

Fixes #54359
 2018-07-20 14:16:28 -07:00
Matt Bierner
44cd521ced Finalize definition link (#54424) 
Finalize the definition link api

- Gives fields more explicit names (target and origin)
- Moves api to vscode.d.ts
- Makes other definition providers (such as type definition provider and implementation provider) also return definition links

Fixes #54101
 2018-07-18 16:32:27 -07:00
Matt Bierner
533c6deb79 Move cancellation files to own dir 
Fixes #53423
 2018-07-18 14:28:55 -07:00
Matt Bierner
b9bc23bb58 Only exec server call in try catch 2018-07-18 14:28:54 -07:00
Matt Bierner
3331d725e5 Use toFileLocationRequestArgs 2018-07-18 14:28:54 -07:00
Matt Bierner
708b16a96c Remove unused property 2018-07-18 14:28:54 -07:00
Matt Bierner
6c2818d42e Clean up provideDocumentSymbols 
- Returned undefined instead of empty array
- Only execute server call in try catch
 2018-07-18 14:28:54 -07:00
Matt Bierner
4c003dbbc1 Remove old navtree call 
This API has been replaced with navbar. The code related to navbar is not being tested and a very small number of users are using < 2.1 in their workspaces
 2018-07-18 14:28:54 -07:00
Matt Bierner
966bec8650 Reducing scope of try catch to just exec 
We want to be alerted if an exception is thrown outside of execute
 2018-07-18 14:28:54 -07:00
Matt Bierner
b6e9dc253b Fix visual match for string types 
Fixes #53962
 2018-07-16 16:46:08 -07:00
Matt Bierner
f5c36f4bb8 Add telemetry on organize imports 
This is needed to understand if users are running this action and how we can improve discoverablity
 2018-07-16 13:00:46 -07:00
Matt Bierner
cbcafcc284 Don't enable commit characters when isNewIdentifierLocation is true 
Fixes #54386
 2018-07-16 13:00:46 -07:00
Matt Bierner
eaa535ff3e Use properties for commitCharacters 2018-07-13 11:42:58 -07:00
Matt Bierner
b179deefe5 Only use isNewIdentifierLocation to disable commit characers instead of all suggestions 
Fixes #54267
 2018-07-13 09:17:14 -07:00
Matt Bierner
b64ff63750 Remove extra await 2018-07-13 09:17:14 -07:00
Matt Bierner
ba9c869b6a Organize all imports in ts extension 2018-07-12 16:32:18 -07:00
Matt Bierner
0986ab3633 Move resource map to utils 2018-07-12 16:30:34 -07:00
Matt Bierner
dc08cbdfa9 Also support regular json files for tsconfig document links 2018-07-12 16:25:14 -07:00
Matt Bierner
cb9ad4f8be Add link provider for jsconfig and tsconfig files 
Fixes #16905
Fixes #54215
 2018-07-12 16:11:30 -07:00
Matt Bierner
4dc63b5061 Fix duplicate config requests sometimes being sent to TS 
Fixes #54088
 2018-07-12 16:11:30 -07:00
Matt Bierner
659d646e55 Use destructuring 2018-07-12 16:11:30 -07:00
Matt Bierner
23d9f2cea6 Don't create empty arrays to signal no return types 2018-07-12 16:11:30 -07:00
Matt Bierner
a7fb144e95 Use Typescript's CompletionInfo.isNewIdentifierLocation 
Fixes #52499
 2018-07-11 14:30:21 -07:00
Matt Bierner
e1d50f119d Move execute into geterror class 2018-07-11 14:19:34 -07:00
Matt Bierner
f3af5502e7 Convert GetErrRequest to class 2018-07-11 14:19:34 -07:00
Matt Bierner
46db7d9d3b tagCompletion -> tagClosing 2018-07-11 14:19:34 -07:00
Matt Bierner
bd3beec042 Extract getInsertionPositions 2018-07-11 14:19:34 -07:00
Matt Bierner
6c99578088 Hook up CancellationToken 2018-07-11 14:19:34 -07:00
Matt Bierner
97734e3a39 Reduce nested statements 2018-07-11 14:19:34 -07:00
Matt Bierner
2e8e41c06d Prefix private members with _ 2018-07-11 14:19:34 -07:00
Matt Bierner
1dcb248d30 Clear auto closing tag timeout 
This should already be effectively canceled but no reason to fire it
 2018-07-11 14:19:33 -07:00