Commit Graph

11802 Commits

Author SHA1 Message Date
Connor Peet
57479c0e8a mcp: fix concurrent request response collection race (#299628)
* mcp: fix concurrent request response collection race

- JsonRpcProtocol.handleMessage now returns JsonRpcMessage[] containing
  responses generated by incoming requests, rather than delegating
  response collection to callers via side-channel state
- McpGatewaySession simplified by removing _pendingResponses and
  _isCollectingPostResponses fields, which were susceptible to racing
  under concurrent HTTP POSTs. Now directly uses handleMessage's
  return value for the response body
- _send callback still invoked for all messages (backward compatible
  with McpServerRequestHandler and SSE notification broadcast)
- Updated tests to assert on handleMessage return values

Fixes #297780

(Commit message generated by Copilot)

* mcp: address review comments on jsonRpcProtocol changes

- Adds JSDoc to handleMessage clarifying what is returned (only responses
  for incoming requests), ordering guarantees for batch inputs, and that
  responses are still emitted via _send callback to avoid double-sending
- Tightens _handleRequest return type from Promise<JsonRpcMessage> to
  Promise<JsonRpcResponse>, enforcing that only valid responses are
  returned. Introduces JsonRpcResponse type alias for better type safety
- Expands error handling tests to assert that returned replies match
  what is emitted via _send for both JsonRpcError and generic error paths

Fixes #297780

(Commit message generated by Copilot)
2026-03-06 14:52:44 -08:00
Matt Bierner
844d9b263b Always require tooltips for markdown command links
Fixes #299657

Also gives the displayed text argument a clearer name
2026-03-06 09:52:09 -08:00
David Dossett
0471f8c218 Polish chat input part: picker collapse, padding, and icon sizing (#299293)
* Polish chat input part: adjust padding, prevent picker collapse, size add context icon

* Increase action widget row gap to 8px
2026-03-04 22:02:50 +00:00
mrleemurray
b31b8d535b update: refine color theme styles and improve CSS for better UI consistency 2026-03-04 15:50:31 +00:00
Lee Murray
fefd2c95c6 Merge pull request #299173 from microsoft/mrleemurray/port-misc-2026-theme-styles-1
2026 theme: update misc UI component styles
2026-03-04 13:04:59 +00:00
mrleemurray
0ac17b9c3b 2026 theme: update misc UI component styles 2026-03-04 10:43:58 +00:00
Johannes Rieken
780451d291 Inline chat affordance fixes (#299169)
* Add ESC to dismiss inline chat editor affordance

Adds a new action bound to Escape that hides the editor affordance
without collapsing the selection.

Fixes https://github.com/Microsoft/vscode/issues/297994

* fix orphaned separators when toolbar items are hidden

Fixes https://github.com/microsoft/vscode/issues/298659

* Add tests for InlineChatAffordance telemetry events

* undo instruct-changes
2026-03-04 11:40:32 +01:00
Connor Peet
d481546f4c dialogs: prevent custom dialogs from overflowing screen vertically (#299048)
Adds max-height: 90vh to the dialog box to prevent it from exceeding the
viewport height, matching the existing max-width: 90vw constraint.

The message content area now scrolls when it exceeds available space:
- Added align-self: stretch to .dialog-message-container in horizontal
  layout so it fills the row height and triggers overflow-y scrolling
- Added min-height: 0 to .dialog-message-container in vertical layout
  to allow flex shrinking and overflow-y scrolling
- Changed .dialog-message-container overflow from 'hidden' to 'overflow-y:
  auto; overflow-x: hidden' to enable vertical scrolling

Buttons, toolbar, and footer remain visible. Only message content scrolls.

Fixes https://github.com/microsoft/vscode/issues/296528

(Commit message generated by Copilot)
2026-03-03 13:19:17 -08:00
mrleemurray
b02a0fd311 refactor: enhance box-shadow styling for menu container based on shadow color
Co-authored-by: Copilot <copilot@github.com>
2026-03-03 11:48:31 +00:00
mrleemurray
a6e427ed1f refactor: update box-shadow styles across various components to use new shadow variables
- Replaced hardcoded box-shadow values with new CSS variables for consistency and improved theming.
- Updated styles in postEditWidget, findOptionsWidget, findWidget, floatingMenu, hover, parameterHints, peekViewWidget, renameWidget, stickyScroll, suggest, actionWidget, hover, quickInput, agentFeedback components, and more.
- Introduced new shadow variables: --vscode-shadow-sm, --vscode-shadow-md, --vscode-shadow-lg, --vscode-shadow-xl, and --vscode-shadow-hover for better control over shadow effects.

Co-authored-by: Copilot <copilot@github.com>
2026-03-03 10:47:14 +00:00
mrleemurray
1cdf38fd85 style(dropdown): remove unnecessary whitespace for cleaner code 2026-03-02 10:59:14 +00:00
mrleemurray
154634f755 style(dialog): update border-radius for modal block shadow to use theme variable 2026-03-02 10:49:13 +00:00
mrleemurray
b13422637b style(dropdown, debug-toolbar): update border-radius to use theme variable for consistency 2026-03-02 10:48:46 +00:00
mrleemurray
75b588a2ae style(dialog): replace fixed border-radius with CSS variable for consistency 2026-03-02 10:48:24 +00:00
Benjamin Pasero
fe85be6c2d Merge branch 'main' into mrleemurray/custom-menu-update 2026-03-01 08:08:21 +01:00
Alexandru Dima
a837f16fbe Report Event.Buffer leaks when running from source (#298468)
* Report Event.Buffer leaks when running from source

* Address feedback
2026-02-28 18:14:13 +00:00
ulugbekna
e0d6fa242d default account: expose copilot token info and keep cache model separated 2026-02-26 23:04:58 +05:00
David Dossett
a6bcce17ed Align custom menu styling with chat picker visuals 2026-02-26 10:04:34 -08:00
mrleemurray
d38271c050 feat: update @vscode/codicons to version 0.0.45-11 and add new 'new-session' icon 2026-02-26 15:55:51 +00:00
mrleemurray
aed186d12e fix(selectBox): enhance handling of disabled options in selection navigation
Co-authored-by: Copilot <copilot@github.com>
2026-02-26 11:27:10 +00:00
mrleemurray
911b82a84b fix(selectBox): improve handling of disabled options and separators 2026-02-26 11:21:09 +00:00
mrleemurray
5039f6a9db feat(selectBox): enhance option creation to support separators in native select box 2026-02-25 15:29:11 +00:00
mrleemurray
7f9ec73230 feat(selectBox): enhance separator handling and update focus ring behavior
Co-authored-by: Copilot <copilot@github.com>
2026-02-25 15:19:32 +00:00
mrleemurray
40db213e28 feat(selectBox): inherit font size from select button for dropdown consistency 2026-02-25 15:03:43 +00:00
mrleemurray
b834690534 feat(selectBox): add separator option styling and update focus outlines
Co-authored-by: Copilot <copilot@github.com>
2026-02-24 17:04:04 +00:00
mrleemurray
98e3531973 fix: standardize border-radius in select box styles for consistency 2026-02-24 15:03:36 +00:00
mrleemurray
ec89c76be5 fix: update select box styles for improved consistency and accessibility 2026-02-24 14:54:30 +00:00
Dmitriy Vasyura
4eb8565469 Get accurate Windows version info from registry instead of os.release() (#295842)
Used Windows registry to retrieve Windows release and build numbers.
Added passing User-Agent header to update service.
Updated installer launch env to ignore compat mode.
2026-02-23 16:06:56 +01:00
Lee Murray
ff21980e60 Add configurable notification positions (#295571)
* feat: add configurable notification positions and update layout accordingly

* test: add unit tests for configurable notification positions and related functionality

* Update src/vs/workbench/browser/parts/notifications/notificationsCommands.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/vs/workbench/browser/parts/notifications/notificationsToasts.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/vs/workbench/test/browser/notificationsPosition.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Initial plan

* Replace hard-coded titlebar height with DEFAULT_CUSTOM_TITLEBAR_HEIGHT constant

Co-authored-by: mrleemurray <25487940+mrleemurray@users.noreply.github.com>

* Remove unused position variable in NotificationsToasts class

* Add ConfigureNotificationsPositionAction and integrate into NotificationsCenter

* Update src/vs/workbench/test/browser/notificationsPosition.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Initial plan

* Replace hard-coded titlebar height with DEFAULT_CUSTOM_TITLEBAR_HEIGHT in test

Co-authored-by: mrleemurray <25487940+mrleemurray@users.noreply.github.com>

* move some things around

* use menu with submenu for positions

* slide in from right

* settings

* .

* .

* .

* .

* .

* .

* unused

* .

* .

---------

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mrleemurray <25487940+mrleemurray@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2026-02-22 19:25:45 +01:00
Benjamin Christopher Simmonds
cd9a8f3e8d Merge pull request #296555 from microsoft/benibenj/fresh-chinchilla
sessions feedback improvements
2026-02-21 10:01:18 +01:00
Copilot
5ba9ca4ec1 Add accessible label to workbench progress bar (#296533)
* Initial plan

* Add aria-label to progress bar

Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>

* Allow progress bar aria label override

Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
2026-02-20 17:34:38 +00:00
BeniBenj
08ee8cdf2b sessions feedback improvements 2026-02-20 17:56:59 +01:00
Copilot
39e42e1e67 Chat sign-in: auto-enable GitHub Authentication extension if silently disabled (#296303)
* Initial plan

* Auto-enable GitHub Authentication extension during chat sign-in if disabled

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

* Apply during the chat request

* feedback

* delete the tests that didn't exist in the first place

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
Co-authored-by: Tyler Leonhardt <tyleonha@microsoft.com>
2026-02-20 08:32:18 +00:00
Benjamin Pasero
0d0f2cea7b Confusing archive/delete UI elements across chat surfaces (fix #296405) (#296461) 2026-02-20 08:24:03 +00:00
Elijah King
10fbccc244 Improve chat feedback animations (#294686) 2026-02-19 15:03:54 -08:00
Don Jayamanne
0d26c20abc Fix PromptFileParser when description contains : (#296205) 2026-02-19 07:54:25 +01:00
Connor Peet
7fe0ebf878 mcp: implement gateway with tools
- Extract an underlying json RPC protocol helper, use that to implement
  the 'gateway' MCP endpoint.
- Pipe server tools through the gateway via the tool broker channel.
- Resources coming tomorrow.
2026-02-18 15:54:56 -08:00
Copilot
3810f9746a Add "Show Details" button to chat setup timeout message (#295653) 2026-02-18 18:23:21 +00:00
Martin Aeschlimann
48b2dca809 improved yaml parser (#295833)
* improved yaml parser

* Update src/vs/workbench/contrib/chat/common/promptSyntax/promptFileParser.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-02-17 15:49:57 -08:00
Sam Shubham
a102af468e Right align actions tree view (#295266)
* WIP: keep actions visible when tree has horizontal scroll
Fixes #251722

* feat(npm): fixed conssitency of right side aligned buttons

* Fix TreeView action alignment during horizontal scrolling

Offset actions using --list-scroll-right-offset so they remain
aligned to the viewport edge. Apply only to rows containing
action items and adjust spacing for correct visual alignment.

* fixed extra space issue on nodes having file decoraters

* Remove known variable - will add back in a separate PR

---------

Co-authored-by: Alex Ross <38270282+alexr00@users.noreply.github.com>
2026-02-17 16:18:40 +00:00
Benjamin Pasero
b1009c98bb Sessions exploration (#294912) 2026-02-17 14:14:39 +00:00
Rob Lourens
f019353b36 Copilot-aided disposable fixes (#295502)
* Copilot-aided disposable fixes

* Undo this, leave it for later

* Undo making some classes disposable when those classes weren't properly tracked
2026-02-16 06:54:19 +00:00
eli-w-king
a3fd9a09a0 Revert "Merge pull request #294021 from microsoft/eli/workbench-motion"
This reverts commit 7e632ad633, reversing
changes made to 386be2607e.
2026-02-13 10:36:28 -08:00
eli-w-king
7392f65cf6 Revert "non-responsive panel content motion (#295011)"
This reverts commit 1443559d93.
2026-02-13 10:35:38 -08:00
mrleemurray
9d1ba054ae Update codicons version to 0.0.45-7 and add new icon 'openInWindow' 2026-02-13 13:52:46 +00:00
Benjamin Pasero
d0061bb5d5 Window control overlay does not dim when modal custom dialog shows (fix #159671) (#295117) 2026-02-13 10:44:17 +00:00
Elijah King
1443559d93 non-responsive panel content motion (#295011)
* fixes animation, non-responsive panels

* Improve error handling during view layout in SplitView animations
2026-02-12 19:42:37 +00:00
Benjamin Pasero
6fb9c86ddc grid - allow to exclude views from maximizeView (#294948) 2026-02-12 17:39:10 +01:00
Benjamin Pasero
855722ab9c Startup perf regression due to top level import of http (fix #294857) (#294894)
* Startup perf regression due to top level import of http (fix #294857)

* Startup perf regression due to top level import of `http` (fix #294857)

* .
2026-02-12 14:58:23 +01:00
Sandeep Somavarapu
a948014acf add name to default account (#294878) 2026-02-12 14:12:55 +01:00