Commit Graph

51 Commits

Author SHA1 Message Date
Alex Ross
4ce5585b4c Use ext host comment value in commands (#144743)
Part of #130107
2022-03-10 10:35:56 +01:00
Johannes Rieken
daf029dfac extract marshalling id into its own file and untable uri from it, https://github.com/microsoft/vscode/issues/142476 2022-02-22 12:38:57 +01:00
Alex Ross
a330b89e5d Finalize comment timestamp API
Fixes #139524
2022-02-09 16:40:31 +01:00
Johannes Rieken
d84b15dd8c dto-ify arguments of proxied types 2022-02-08 11:01:23 +01:00
Alex Dima
6136c815bc Renames 2022-02-04 15:01:44 +01:00
Johannes Rieken
4a130c40ed enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Alex Ross
454dce4c53 Fix string comment body displayed as markdown
Fixes #140967
2022-01-21 14:14:20 +01:00
Alex Ross
8b27820fb2 Comment detail should be timestamp
Part of #139524
2022-01-21 13:21:17 +01:00
Alex Ross
adb8450420 Add timestamps to comments proposal (#139849)
Part of #139524
2022-01-13 11:33:43 +01:00
Alex Ross
4d1d73f6ef Revert "Add timestamps to comments proposal (#139849)"
This reverts commit b978d7150c.
2022-01-12 15:51:57 +01:00
Alex Ross
b978d7150c Add timestamps to comments proposal (#139849) 2022-01-12 14:41:23 +01:00
Alex Dima
973684056e Rename modes to languages 2021-12-30 18:52:15 +01:00
rebornix
38cef76ce7 fix #120680. 2021-11-01 18:10:42 -07:00
rebornix
f6de5208d8 fix #126475 2021-10-19 16:37:00 -07:00
rebornix
9275d0fc5f fix #128312. 2021-07-09 09:22:56 -07:00
rebornix
badabb990c freeze CommentController/Threadd through #value. 2021-07-05 16:09:17 -07:00
rebornix
92e91e9e47 re #115679. hide proxy from exthost comments. 2021-07-05 15:44:48 -07:00
rebornix
01759044cf re #115679. 2021-07-05 14:45:27 -07:00
Connor Peet
751f8729dc protocol: refactor to use enum for marshalled object ids 2021-06-22 18:47:25 -07:00
rebornix
59f0af3bec canReply 2020-10-07 15:27:32 -07:00
rebornix
c49d699aec comment thread readonly 2020-09-25 09:18:46 -07:00
rebornix
0421b831ad Fix #92794. allow customize placeholder for input box 2020-04-27 16:13:10 -07:00
Matt Bierner
1b70625f8c Use import type when importing vscode under src
When the core references `vscode`, we only want to import the types and never generate a real import (which will fail to load). Use `import type` to better enforce this
2020-01-10 14:25:21 -08:00
Jackson Kearl
69fd68da9f Preserve comment thread collapse state across extension host update messages, fixes https://github.com/microsoft/vscode-pull-request-github/issues/1400 2019-10-24 12:00:53 -07:00
Matt Bierner
029009eafd Marking most private emitters as readonly
Emitters should generally not be reassigned as their corresponding event would also be lost. Marking these as readonly just to enforce this
2019-09-23 17:31:18 -07:00
Rachel Macfarlane
8efcc47e18 strictPropertyInitialization, #78168 2019-08-05 09:05:30 -07:00
Peng Lyu
97ce6669fa toggle reaction should work. 2019-07-18 15:38:44 -07:00
Peng Lyu
f1bad37012 Remove Comment Id 2019-07-18 15:34:05 -07:00
Rachel Macfarlane
877235c625 Remove old proposed commenting API 2019-07-10 11:11:14 -07:00
Johannes Rieken
c8843e3b0d final touch at heap service removal, #74846 2019-06-19 10:58:24 +02:00
Peng Lyu
8ef603062f #74846. no CommandsConverter#toInternal 2019-06-14 13:03:41 -07:00
Peng Lyu
63672ffaa7 Merge pull request #74930 from microsoft/rebornix/commentreactions
Comment Reaction API
2019-06-10 10:36:21 -07:00
Peng Lyu
cae0668a0e reactions handler 2019-06-05 21:08:41 -07:00
Rachel Macfarlane
83ef31e6a2 Correctly set extensionId on comment threads 2019-06-04 11:50:47 -07:00
Peng Lyu
c042dabe2b Fix #74641. Update viewzone afterline when position changes. 2019-05-31 10:27:56 -07:00
Peng Lyu
346da6b01a dispose empty comment thread when collapse. 2019-05-23 16:37:42 -07:00
Peng Lyu
e26568b586 Add contextValue support 2019-05-21 16:59:34 -07:00
Peng Lyu
b8c1a34885 thread id is still updatable 2019-05-21 15:08:47 -07:00
Peng Lyu
7554ac4387 Edit comment 2019-05-17 18:16:14 -07:00
Rachel Macfarlane
925426e8b0 Remove activeCommentThread from extHost comments, set context keys on simple comment editor 2019-05-17 16:52:36 -07:00
Peng Lyu
e6152cc29f icons for menu bar 2019-05-17 16:34:47 -07:00
Peng Lyu
4186bc0a44 menu items 2019-05-17 11:49:00 -07:00
Peng Lyu
0683efcf4f Deprecate commands for static contribution later, fixes #73333 2019-05-06 14:17:44 -07:00
Peng Lyu
da3c97f366 Rename username to author name. (#73137)
* Rename user to author for Comment.

* Make Comment interface

* Fix #73170. Introduce CommentAuthorInformation

* Fix #73145. Update range properly.
2019-05-03 18:29:48 -07:00
Peng Lyu
072e9a35ee Comments API Finalization (#73010)
* Comments API Finalization
2019-04-30 14:59:59 -07:00
Peng Lyu
253809c186 Legacy api should still work. 2019-04-28 16:35:01 -07:00
Peng Lyu
6a4805546a Bring back empty comment thread factory. 2019-04-28 14:02:23 -07:00
Peng Lyu
9435d7cc38 support deprecated commentId. 2019-04-28 13:24:58 -07:00
Peng Lyu
2884d2239b Add active comment thread. 2019-04-28 12:30:29 -07:00
Peng Lyu
3d814eb92d Comment Id. 2019-04-28 11:57:37 -07:00