Commit Graph

2465 Commits

Author SHA1 Message Date
Alex Dima
46d1ac2bbc Add "Measure Extension Host Latency" action 2019-01-09 08:38:30 +01:00
Matt Bierner
6ac9ea2af7 Revert "Revert "Add activeSignatureHelp to SignatureHelpContext (#65440)""
This reverts commit 7b375fcb82.

Reapplies 4a38520d59 with a fix for #66202

Fixes #66202
2019-01-08 11:49:32 -08:00
Benjamin Pasero
5a892a6450 return non-zero exit code when testrun produces an error (fixes #66218) 2019-01-08 17:41:59 +01:00
Johannes Rieken
f9dac59254 add warning/'missing name'-message when symbol has no name, fixes #65545 2019-01-08 12:55:42 +01:00
Joao Moreno
7b375fcb82 Revert "Add activeSignatureHelp to SignatureHelpContext (#65440)"
This reverts commit 4a38520d59.
2019-01-08 10:09:47 +01:00
Matt Bierner
4a38520d59 Add activeSignatureHelp to SignatureHelpContext (#65440)
For #33413

Adds the active `SignatureHelp` object (along with the active signature) to the `SignatureHelpContext`.
2019-01-07 13:55:58 -08:00
Alex Dima
9cf36cdf8f Rename CanonicalExtensionIdentifier to ExtensionIdentifier 2019-01-07 12:00:54 +01:00
Andre Weinand
ac39335c81 remove obsolete Tracker API 2019-01-07 10:28:46 +01:00
Matt Bierner
087629786a Mark private service properties declarated in ctors as readonly 2019-01-04 12:03:24 -08:00
Matt Bierner
c109d319fe Second pass converting for index based looping to for-of loops
More manual conversion of index based for loops to for-of loops
2019-01-04 12:03:23 -08:00
Matt Bierner
cd88417f49 Enabling a few more tslint rules in the codebase 2019-01-03 17:39:12 -08:00
Matt Bierner
9e4daf6069 Prefer using explicit function types instead of Function 2019-01-03 17:39:12 -08:00
Rob Lourens
ef2547d547 replace void 0 with undefined 2019-01-03 11:20:19 -08:00
Rob Lourens
7805023eaa Fix #65933 2019-01-02 21:20:14 -08:00
bissonex
36ac195d16 fix typo (#65740)
fix typo for Editor Find, terminalSupport.ts, terminals.ts, extHostDebugService.ts
2018-12-28 12:13:31 -08:00
Johannes Rieken
195fd560a5 undo unneeded change 2018-12-27 11:57:16 +01:00
Johannes Rieken
96d2413a4e Tweak ctor of SelectionRange, https://github.com/Microsoft/language-server-protocol/issues/613 2018-12-27 10:07:23 +01:00
Josh Goldberg
d659000852 Converted about 25 *.test.ts files to --strictNullChecks (mostly automatically) (#65581)
* Manually added strict null checks in around 70 files

* Fixed tsconfig.strictNullChecks.json merge fail

* Touched up a few unnecessary type changes

* Removed files already in other PRs
2018-12-23 20:28:51 -08:00
Daniel Imms
fedf2f8771 Rename experimentalUseConpty to windowsEnableConpty 2018-12-21 12:00:35 -08:00
Daniel Imms
dceb815558 Merge remote-tracking branch 'origin/master' into tyriar/conpty 2018-12-21 10:49:44 -08:00
Alex Dima
25417553be Adopt case insensitive extension identifiers 2018-12-21 12:41:41 +01:00
Matt Bierner
6422adaffe Remove redundant type annotations for generic emitter properties
Code like:

```
private readonly _onDidEncounterLanguage: Emitter<LanguageId> = new Emitter<LanguageId>();
```

Does not need to repeat the `Emitter<LanguageId>` type annotation
2018-12-19 17:10:39 -08:00
Andre Weinand
5fece3f30e do not ignore debggers that lack a label; fixes #61649 2018-12-19 16:03:17 +01:00
Daniel Imms
58f6dc5185 Merge remote-tracking branch 'origin/master' into tyriar/conpty 2018-12-18 17:13:35 -08:00
Rachel Macfarlane
c5c15eb75f Add document parameter to draft methods on comments provider 2018-12-18 14:57:50 -08:00
Johannes Rieken
27fd58c206 refine SelectionRangeKind #63935 2018-12-18 10:57:56 +01:00
Daniel Imms
e110245f13 Merge branch 'master' into kieferrm/terminal-cwd 2018-12-17 11:21:20 -08:00
Johannes Rieken
514ec620de add SelectionRange and SelectionRangeKind, #63935 2018-12-17 15:10:18 +01:00
Johannes Rieken
45e479386b add typings to support Promise#finally 2018-12-14 09:20:49 +01:00
Daniel Imms
ece3a90fb5 Tweak setLocaleVariables setting
- False now really means false
- The default is true for all platforms

Fixes #65037
2018-12-13 18:07:20 -08:00
Matt Bierner
986f924ad5 Prefer using Array<T> for complex array types
Use `Array<T | U>` when dealing with union types instead of  `(T | U)[]`
2018-12-13 16:40:44 -08:00
Matt Bierner
d40fa4a27e Review uses of Promise.resolve(null)
Many `Promise.resolve(null)` should actually be `Promise.resolve(void 0)`. In other cases, we were missing a null return annotation.
2018-12-13 15:41:13 -08:00
Matt Bierner
68a4e01246 Use resolve(void 0) instead of resolve(null) for void promises
Fixes a common type error
2018-12-13 15:20:46 -08:00
Daniel Imms
e6254db320 Recreate pid promise when reusing terminals 2018-12-13 10:02:17 -08:00
Daniel Imms
461bf7207b Merge remote-tracking branch 'origin/master' into pr/g-arjones/60111 2018-12-13 09:33:42 -08:00
Daniel Imms
e7102b1824 Send terminal name with id when it's ready
Fixes #64390
2018-12-13 08:07:55 -08:00
Dirk Baeumer
51f7beb40c Fixes #64918: Remove old task conversion code 2018-12-13 14:45:51 +01:00
Johannes Rieken
c6c7edaa9f debt - asThenable -> asPromise because it returns a promise 2018-12-13 11:45:48 +01:00
Johannes Rieken
653280d133 debt - Thenable -> Promise 2018-12-13 11:31:54 +01:00
Alex Dima
29dd4e77de Keep track of activating extensions 2018-12-13 11:22:26 +01:00
Matt Bierner
0b1d0da7af Prefer to use .then(void 0, ..) over .then(null, ..)
ES6 promises like using undefined as their first argument instead of null. Both should behave the same behavior
2018-12-11 21:59:32 -08:00
Daniel Imms
e417e07b4b Add use conpty setting 2018-12-11 11:46:39 -08:00
Johannes Rieken
48a452dcee towards strict null and completion model, #63454 2018-12-11 17:00:19 +01:00
Joao Moreno
408e03220c event namespace consolidation & docs 2018-12-11 10:14:38 +01:00
Matt Bierner
100adeb3e9 Use more generic word pattern for markdown
Try to better support handle of unicode in markdown by using a word definition that use unicode character class

Fixes #15177
2018-12-10 18:24:10 -08:00
Matt Bierner
0928a6d348 Prefer coalesce over filter
Coalesce has the correct return type of `T[]`. Filter may return `(T | undefined)[]`
2018-12-07 16:32:45 -08:00
Matt Bierner
e2cf8ebc5d Enable strictBindCallApply for VS Code
Fixes #64633
2018-12-07 14:25:14 -08:00
Rob Lourens
9be224980c Make LogLevel converters safer and consistent with other converters, from @jrieken feedback 2018-12-06 11:02:09 -08:00
kieferrm
f8d555167e allow terminal.cwd to be a URI 2018-12-05 14:48:18 -08:00
Rob Lourens
514217add5 Fix #64273 - EH log levels start at 1 2018-12-05 13:29:38 -08:00