Commit Graph

2908 Commits

Author SHA1 Message Date
Julien Richard
f5272fbe6c Merge branch 'main' into fix-context-menu-for-deleted-lines-in-diff-inline 2023-05-26 16:07:54 +02:00
Johannes Rieken
9013a83a87 Merge pull request #183538 from microsoft/joh/available-roundworm
joh/available roundworm
2023-05-26 15:53:41 +02:00
Johannes
a5ab2536d9 log when an editor action doesn't run because of enablement 2023-05-26 15:34:32 +02:00
Henning Dieterichs
397f2e7c34 First draft of diff editor v2. 2023-05-26 15:26:31 +02:00
Henning Dieterichs
ca0abe62ff Small diff editor refactoring 2023-05-25 18:44:10 +02:00
Henning Dieterichs
09f80f4c54 Merge pull request #182379 from r3m0t/fix-170449
Prevent ligatures between inlay hints and editor contents (Fix #170449)
2023-05-22 12:36:33 +02:00
Julien Richard
43adfa4fa6 Fix context menu for deleted lines in diff inline mode 2023-05-15 21:14:16 +02:00
Johannes Rieken
c4ef9df22e Merge pull request #182323 from microsoft/merogge/diff-fix
allow diff actions to apply to embedded interactive session diff widget
2023-05-15 09:12:12 +02:00
Tomer Chachamu
7a135a6acd Prevent ligatures between inlay hints and editor contents (Fix #170449)
https://www.w3.org/TR/2023/CRD-css-text-3-20230213/#boundary-shaping
2023-05-13 11:57:55 +01:00
meganrogge
22e625581d allow diff actions to apply to embedded interactive session diff widget
Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
2023-05-12 09:28:41 -07:00
Peng Lyu
02298ef418 Extract embed diff editor context key. (#182135) 2023-05-10 16:45:05 -07:00
Peng Lyu
19545fea33 Fix isEmbeddedDiffEditor context key. (#182112)
Fix isInEmbeddedEditor context key.
2023-05-10 14:47:31 -07:00
Matt Bierner
18db0394ae Don't generate uri-list entries from files without paths (#181965)
For #181886

The uri-list should contain full uris, not just the file names
2023-05-09 16:23:41 -07:00
Joyce Er
2fa219d00c Center extension glyph margin decorations (#181517)
Fix #181479
2023-05-04 15:53:52 +02:00
Matt Bierner
63f0154cf5 Set text/uri-list when dragging editor resources (#181374)
Fixes #181367
Fixes #181373

This moves the setting of `text/uri-list` to happen on drag instead of on drop. This allows dropping editors as `text/uri-list` across applications

Note that due to https://bugs.chromium.org/p/chromium/issues/detail?id=239745, we can only set a single uri in the real `text/uri-list` type
2023-05-03 08:43:26 +02:00
meganrogge
bf86c14950 fix #181035 2023-05-01 10:05:12 -07:00
Joyce Er
651bd249f9 Set glyph margin decoration width appropriately (#181071) 2023-04-27 15:35:46 -07:00
Henning Dieterichs
c455231128 Revert "Fix: diff editor arrow click enables breakpoint " (#181040) 2023-04-27 13:47:13 -07:00
Johannes Rieken
726b7f51e0 enable live preview for last line of document. for that... (#181029)
- support `ordinal` and `showInHiddenAreas` for `IViewZone`
- adopt in zoneWidget
- adopt for inline chat widgets
- remove code that isn't needed anymore 👯‍♂️

fixes https://github.com/microsoft/vscode-internalbacklog/issues/4024
2023-04-27 15:42:00 +02:00
Henning Dieterichs
1e29d6018a Fixes #181009 (#181011)
* Fixes #181009

* Use isMeasurement: true for boolean
2023-04-27 11:28:05 +02:00
meganrogge
3d04348ffe fix #172465 2023-04-26 15:14:45 -07:00
meganrogge
7c905c6ba0 use editor options 2023-04-24 09:44:08 -07:00
Joyce Er
8df6888367 Show hover message for diff revert arrow (#180378) 2023-04-24 17:02:39 +02:00
Henning Dieterichs
bdf6efedc5 Merge branch 'main' into bug/diff-breakpoint-clash 2023-04-24 14:02:57 +02:00
Johannes
f7eb567525 allow for default sash ratio in diff editor (side-by-side) and use it for inline diff'ing 2023-04-21 11:34:52 +02:00
Alexandru Dima
c29e4b0fdb Revert "add accessibility verbosity settings for terminal and diff editor aria hints" (#180477) 2023-04-21 09:26:33 +02:00
Joyce Er
2c10a8e083 Render both debug frame indicator and breakpoint (#180448) 2023-04-20 15:35:46 -07:00
Megan Rogge
fd5ccc856c Merge pull request #180365 from microsoft/merogge/acc
add accessibility verbosity settings for terminal and diff editor aria hints
2023-04-20 15:03:38 -07:00
Joyce Er
b5e90fd0b1 Support dedicated lane for breakpoint decorations (#180013)
* Add fast path for margin decoration access

* Support glyph margin decoration lanes

* Do not center extension-contributed decorations

* Show breakpoints in dedicated right lane

* Only recompute lane count if glyph margin was affected

* Add explicit type for className / zIndex pair and fix problems in other consumers of `DedupOverlay`

* Avoid arrays of arrays

* Figure out if two lanes are needed in O(N)

---------

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2023-04-19 16:26:20 -07:00
meganrogge
c78f1bc690 config service 2023-04-19 15:15:01 -07:00
meganrogge
f540366768 react to config changes 2023-04-19 14:52:21 -07:00
meganrogge
612c4f17e8 fix issues 2023-04-19 14:19:35 -07:00
meganrogge
0a06187dec add config 2023-04-19 13:42:10 -07:00
Henning Dieterichs
7395a78d08 Fixes #164583. Renames diffAlgo name smart to legacy and experimental to advanced. (#180310) 2023-04-19 16:04:23 +02:00
Aiday Marlen Kyzy
04beb6de9c Merge pull request #178242 from microsoft/aiday/issue52364
Making a standalone color picker appear for inserting colors
2023-04-19 12:39:39 +02:00
Henning Dieterichs
6d4aaec420 Adds changes2: LineRangeMapping[] to IDiffComputationResult 2023-04-19 11:42:25 +02:00
Alex Dima
faefe8d056 Avoid constantly breaking the viewport decoration cache due to the minimap and the glyph margin flags 2023-04-18 05:53:31 -07:00
Joyce Er
ba851f909e Add fast path for margin decoration access 2023-04-18 05:53:31 -07:00
Alexandru Dima
0f194ab067 Fix rendering of lines decorations and margin decorations (#180120)
Fix rendering of lines decorations and margin decorations (fixes #180107)
2023-04-17 12:57:37 +01:00
Johannes
fb91cbdaaf Merge branch 'main' into joh/inlineDiff2 2023-04-14 15:50:58 +02:00
Joyce Er
7bd1368261 Render glyph decorations by zIndex (#179910)
* Render glyph decorations by zIndex

* Use 0 as default zIndex

---------

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2023-04-14 15:15:15 +02:00
Johannes
294bc7b4d0 allow to pass widget options to embedded diff editor,
don't create IE controller inside its nested editors
ensure IE commands run from within nested diff editors

fixes https://github.com/microsoft/vscode-internalbacklog/issues/3911
2023-04-14 14:57:39 +02:00
Aiday Marlen Kyzy
78d4b0f630 Adding code in order to run the function provideDocumentColors on a worker 2023-04-12 21:31:19 +02:00
Matt Bierner
e9262678fa Add drop feedback UX (#179434)
For #179430

Adds two new UX components:

- An inline progress icon shown when a drop operation takes over 500ms. This replaces the notification. You can click on it to cancel the drop

- Post drop, a drop feedback icon that lets you drop the file in a different way. This lets you drop the file as plain text for instance instead of as a markdown link
2023-04-11 13:48:24 -07:00
Alexandru Dima
3ff6310972 Improve StableEditorScrollState (#179402)
Fixes #179368: Never interrupt a pending scroll animation in `StableEditorScrollState` and avoid calling `setScrollTop` if the editor's content height didn't change
2023-04-06 18:46:06 +02:00
Alexandru Dima
5c2438b2c3 Convert IMouseTargetViewZone.detail to model coordinates before emitting the event (#179387)
Fixes #179114: Convert `IMouseTargetViewZone.detail` to model coordinates before emitting the event
2023-04-06 16:22:05 +02:00
maxmmyron
5132503728 fix #179115 2023-04-04 12:51:01 +01:00
Henning Dieterichs
a0c35db9cd Moves viewport tokenization responsibility into GrammarTokenization. Fixes #178582 2023-04-03 11:48:55 +02:00
Henning Dieterichs
b39ea9613d Fixes https://github.com/microsoft/monaco-editor/issues/3217 2023-03-31 12:28:35 +02:00
Henning Dieterichs
8d35ea8c41 Improves timeout handling of diffing algorithm (#178497) 2023-03-28 17:03:46 +02:00