Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 17:19:48 +01:00
Code Issues Packages Projects Releases Wiki Activity
80,530 Commits 3,845 Branches 362 Tags
61f646674b04a9984108a699408ab63aa25f5034
Commit Graph

231 Commits

Author SHA1 Message Date
Johannes Rieken b06388f501 Merge branch 'joh/clean-kernel' into notebook/dev 2021-04-20 11:33:41 +02:00
rebornix d415fc0d0e adopt notebookSelector in status bar API. 2021-04-19 10:15:26 -07:00
Johannes Rieken 11c3ba58af remove NotebookKernelProvider API and its implementation 2021-04-19 16:19:23 +02:00
rebornix 8629b48030 rename transientMetadata to transientCellMetadata. 2021-04-15 17:24:47 -07:00
Johannes Rieken b6cee1ca22 add cancellation to NotebookSerializer, https://github.com/microsoft/vscode/issues/121329 2021-04-15 16:21:06 +02:00
Rob Lourens 3e40e14bc4 Cell statusbar API (#121215) 
Implement provider-based notebook cell statusbar API
 2021-04-14 11:26:23 -07:00
Johannes Rieken 10bf5cfd61 align kernel and kernel2 a little more 2021-04-13 14:48:55 +02:00
Connor Peet 60a7c6a925 notebooks: add initial kernel/renderer constraints 
See https://github.com/microsoft/vscode/issues/119899

Backwards compatible, initially. The implementation should be
pretty unsurprising. Some churn from data wiring.

This does the bulk of the work. The only remaining item is caching
the last renderer used for notebooks in the workspace to avoid running
selection again if the user reopens/reloads the window.
 2021-04-12 16:30:39 -07:00
Johannes Rieken edd36fd64c add and adopt implementsExecutionOrder 2021-04-09 13:03:49 +02:00
Johannes Rieken 1372233695 remove unused service 2021-03-31 16:26:29 +02:00
Johannes Rieken fa48622fdf split mainThreadNotebook up into logical pieces 
* notebookDocumentsAndEditors -> owns the truth of the notebooks and editor that extensions know about
* notebookEditor -> everything about editors
* notebookDocuments -> everything about documents
 2021-03-31 15:44:31 +02:00
Johannes Rieken dd360b25da add notebookEditorModelResolverService.isDirty and use that when forwarding events 2021-03-31 12:06:03 +02:00
Johannes Rieken 29a1cfddcd make sure dirty state of notebooks from simple content provider is reflected in extension host, add integration test 2021-03-30 11:50:20 +02:00
Johannes Rieken 3a8a44f64b implement saveAs and better resolving/loading, move some files around, split some files up 2021-03-25 12:33:13 +01:00
Rob Lourens 7b96cc4c8b Implement Execution API (#116416) 
Implement new execution task API
#106744
Fix #105847
 2021-03-22 11:27:00 -07:00
Johannes Rieken 7d99c47b75 move notebook save event into notebook editor model service, remove resolve/save/backup from notebook service and let editor model use content provider directly 2021-03-19 13:13:40 +01:00
Johannes Rieken 232266aaf2 first cut of IFileWorkingCopy adoption, misses saveAs and backsnapshot are improper... 2021-03-18 15:26:18 +01:00
Johannes Rieken 31283f32b2 keep notebook serializer locally 2021-03-16 14:52:24 +01:00
Johannes Rieken 2de06d768b add INotebookSerializer interfaces and wire up IPC calls 2021-03-16 13:19:33 +01:00
Logan Ramos c72d7612b4 Add an untitled document data property (#115790) 
* Add an untitled document data property

* Dispose of the model passed back

* Fix layer problem

* Add untitledDocumentData to untitled notebooks

* Fix compilation errors

* Switch to using VS Buffer

* Fix threading the untitled document data back through

* Prevent save dialog on untitled reopen with

* Change ignore save setting

* Change setting name and abide by preserve focus

* Add unit test

* Switch to js doc comments

* Consolidate calculating the untitled value, and added test
 2021-03-10 19:54:18 +00:00
Johannes Rieken a6d7d86e85 remove viewType from openNotebookDocument call 2021-03-10 14:30:40 +01:00
Johannes Rieken 0f64ef1b65 remove NotebookDocument#contentOptions 2021-03-09 17:44:22 +01:00
Johannes Rieken 98a22a957a declare cancellation support for openNotebook and wire it up, exempt notebook content provider from provider naming rules 2021-03-09 12:40:37 +01:00
Johannes Rieken 230e0fdc9a clean up, some ground work to support viewColumn, $acceptEditorPropertiesChanged must update all state before sending events, remove active notion from notebook editor 2021-03-05 17:22:06 +01:00
Johannes Rieken 68a6f1c30e look up editor by id, slimmer dtos 2021-03-05 17:22:05 +01:00
Johannes Rieken 3b05017bb8 more 💄, more strict typings 2021-03-05 13:09:18 +01:00
Johannes Rieken 1d8493b203 💄 in mainThreadNotebooks, return types, more private, dispoable store, duplication removal, etc 2021-03-05 12:52:35 +01:00
Johannes Rieken 85c1a17b60 Merge IEditor and INotebookEditor, move editor things into notebook editor service 2021-03-05 12:17:21 +01:00
Johannes Rieken 0e94794c9d debt - remove unneccessary indirections from notebook service 2021-03-03 16:49:33 +01:00
rebornix 6643b5e520 de-dup: uri. 2021-03-02 12:34:30 -08:00
Johannes Rieken 66b7ffaabf simplify $tryShowNotebookDocument further 2021-03-02 13:07:36 +01:00
Johannes Rieken 83f4088681 notebook - simplify group/viewColumn handling when opening a notebook editor via API 2021-03-02 12:29:28 +01:00
rebornix d7f90c7dbc re #114554. 2021-03-01 20:10:09 -08:00
Johannes Rieken b99df4f2b6 don't pass model service to applyEdit but check model version for edit that come from extensions, fixes https://github.com/microsoft/vscode/issues/117683 2021-03-01 09:54:02 +01:00
Peng Lyu 08eac1a22d Merge pull request #117204 from microsoft/rebornix/nb-selections 
Notebook selections/CellRange
 2021-02-22 16:25:10 -07:00
Logan Ramos 413963c489 Remove editorOpenWith (#116856) 
* Move editorOpenWith to the editorService

* Remove custom editor input handling

* Fix open with API command

* adopt master properly

* Remove dnagling comment

* Address some feedback

* Cleanup region comment.

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* Cleanup region comment.

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* Update override typings

* Fix missing picker

* Fix bug with reopen with

* Remove duplicate import

* First round of feedback via changes
- OverrideOptions => EditorOverride
- It is safe to destructure (...) undefined
- Ensure when destructuring, override is always winning
- Not a big fan of shared builtinProviderDisplayName import

* editorservice - static DEFAULT_EDITOR_OVERRIDE_ID

* editors - introduce a editor associations registry

This moves the relevant code out of the editor service.

* cleanup editor picking

* cleanup editor delegate

* final 💄

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
 2021-02-22 17:16:15 -05:00
rebornix ed08a14111 selections[0] is primary. 2021-02-22 10:16:57 -08:00
Benjamin Pasero ae0a103755 :chore: address some todos 2021-02-22 10:50:07 +01:00
rebornix dea95d3e4f map handles to cellrange in UI. 2021-02-21 22:24:20 -08:00
rebornix 1e0adc0da5 unnecessary null -> undefined. 2021-02-21 19:47:27 -08:00
rebornix de956ce8bd differenciate selection and focus. 2021-02-21 19:35:26 -08:00
rebornix e8966ecaa9 notebookeditor.selections 2021-02-19 17:03:33 -08:00
Johannes Rieken 4a74fa81c1 💄 2021-02-19 15:04:17 +01:00
Johannes Rieken 57cd5d4936 🪓 remove unused $acceptDisplayOrder-RPC and everything around it 2021-02-19 15:02:43 +01:00
Johannes Rieken 7e7a71d733 💄 more supportsBackup removal 2021-02-19 14:54:32 +01:00
rebornix 9c77f4d86a add NotebookDocument.save(). 2021-02-18 11:57:49 -08:00
Johannes Rieken 7bca8a91b4 send correct delta after restarting extension host, https://github.com/microsoft/vscode/issues/115698 2021-02-18 18:09:45 +01:00
Johannes Rieken 2a12fd7202 dispose more things, https://github.com/microsoft/vscode/issues/115698 2021-02-18 17:36:29 +01:00
Johannes Rieken a246f643ee debt, copy-paste police 2021-02-18 17:27:32 +01:00
Johannes Rieken 31e3a7794d merge NotebookController#reloadNotebook into notebook editor model, remove NotebookServce#resolve and add create and fetchData "primitives", https://github.com/microsoft/vscode/issues/114263 2021-02-18 16:05:54 +01:00