* Initial plan
* Fix Link component to respond to Space key for accessibility
Added Space key support to the Link component in addition to Enter key.
This fixes the issue where the "Show More" button in chat agent sessions
view was not responding to Space key presses. Elements with role="button"
should respond to both Enter and Space keys per WCAG guidelines.
Also created comprehensive tests for the Link component to verify:
- Enter key activates the link
- Space key activates the link (new behavior)
- Click events work
- Disabled state prevents activation
- Role attribute is properly set for accessibility
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
* Fix test instantiation formatting for Link component tests
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
* Initial plan
* Fix Save As to preserve indentation and EOL settings
When using Save As, the target file now preserves the source file's:
- Indentation settings (insertSpaces, tabSize, indentSize)
- End-of-line sequence (LF vs CRLF)
This ensures that user preferences like using tabs instead of spaces
and LF instead of CRLF are maintained when saving to a new file.
Added test to verify the fix works correctly.
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
* Use EndOfLineSequence enum constant instead of magic number
Improved code readability by using EndOfLineSequence.LF instead of 0.
This addresses code review feedback.
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
* Improve test readability by extracting target options
Extract targetOptions to a variable to avoid repetitive getOptions() calls.
This addresses code review feedback.
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
* undo test
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
- Make IChatRequestVariableEntry readonly in the type signatures where
variables are passed/stored to reduce aliasing issues
- Cache the hash result for variables in ChatRequestViewModel.dataId to
avoid recalculating the same hash repeatedly. This improves performance
when the same variables array is queried multiple times.
Fixes https://github.com/microsoft/vscode/issues/286450
(Commit message generated by Copilot)
rm unused import
- Adopt rename viewport->containerDimensions
- Add some code to fix the postMessage.source validation issues
- Fix apps not restoring when chat is remounted
Resolves#283954.
1. Update workbench.action.chat.import to non-interactively accept filepath for import.
2. Accept `target` for location chat will be revived to.
