Commit Graph

171 Commits

Author SHA1 Message Date
Benjamin Pasero
64eed745f5 💄 move a few services around 2019-09-26 18:37:58 +02:00
Matt Bierner
0506f7f736 Make sure image views (and custom editors) work properly on the web
This fixes an issue where webviews for custom editors did not have any associated extension information, which caused them try reading `file:` uri resources instead of remote uri resources
2019-09-25 16:25:39 -07:00
Matt Bierner
a62b7dabe7 Make resolveExternalUri return just a plain uri instead of a disposable result
For #81131

We had trouble coming up with cases where extensions could actually reliably dispose of the resolved uri
2019-09-23 10:58:21 -07:00
Matt Bierner
a817a588c7 Moving resolve uri logic into openerService
- Add a resolveExternalUri function to the opener service. This service already has to know how to resolve external uris so it makes sense that the function lives there

- Move the tunneling logic for desktop into window.ts

- Make result of resolve disposable
2019-09-20 17:17:42 -07:00
isidor
a9c67d8b82 extHost startDebugging minor polish 2019-09-19 16:08:52 +02:00
Isidor Nikolic
c4a6fc1078 Merge pull request #80673 from dgozman/fix-62419
Allow debug session to share repl with its parent; fixes #62419
2019-09-19 16:05:08 +02:00
Christof Marti
715b6c5792 Add extension id that triggered the activation event 2019-09-19 09:42:17 +02:00
Matt Bierner
27bac598cc Basic implementation of resolveExternalUri 2019-09-18 18:20:26 -07:00
Dmitry Gozman
e4d4b43f35 Allow debug session to share repl with its parent; fixes #62419
Introduced DebugSessionOptions passed to debug.startDebugging which
encapsulated DebugConsoleMode to control this behavior.
2019-09-18 11:45:39 -07:00
Sandeep Somavarapu
7ccfc2dcc5 remove user data api implementation 2019-09-18 12:21:34 +02:00
Sandeep Somavarapu
b44a8ca309 move user data sync store to workbench 2019-09-17 16:56:44 +02:00
Sandeep Somavarapu
5cc29271b5 Introduce id and user data sync store registry 2019-09-17 16:25:06 +02:00
Sandeep Somavarapu
8fbdeb724b move user data sync services to platform 2019-09-16 17:30:47 +02:00
Alex Ross
1c01ce84b5 Refactor extHostTask (#80970)
so that most of it is in common
2019-09-16 12:09:14 +02:00
Sandeep Somavarapu
317ed7e1a5 Merge branch 'master' into sandy081/userDataProvider 2019-09-15 19:52:27 +02:00
Matt Bierner
4546a07196 Working on basic save for custom editors 2019-09-13 22:24:35 -07:00
Benjamin Pasero
f8effd5fad api - introduce env.uiKind (web, desktop) 2019-09-13 17:58:30 +02:00
Johannes Rieken
cf88c7f310 retry command exec when having arguments, when contributes, and not yet activated, #80338 2019-09-13 08:50:12 +02:00
Daniel Imms
678abfe8b2 Remove Terminal.onDidWriteData
Replaced by vscode.window.onDidWriteTerminalData

Fixes #78574
2019-09-12 19:09:12 -07:00
Matt Bierner
7a219ab632 Adding concept of a state for webview editors
#77131

This information will be used to show the dirty indicator and also enable/disable save
2019-09-12 14:04:54 -07:00
Sandeep Somavarapu
88e5a183ae Use ref instead of version 2019-09-12 16:17:05 +02:00
jrieken
6fc8778fdc calls - add CallHierarchyItem to type converter 2019-09-12 13:34:45 +00:00
jrieken
4aa06c2611 calls - remove resolve-function, use document,position tuple when making requests 2019-09-12 10:13:20 +00:00
Johannes Rieken
a97b843f27 Merge pull request #80713 from microsoft/joh/api/callHierarchy2
Call hierarchy API proposal
2019-09-11 15:37:16 +02:00
jrieken
8e5edc0eda use Outgoing/Incoming terminology 2019-09-11 13:25:53 +00:00
Sandeep Somavarapu
65f14490b7 Merge branch 'master' into sandy081/userDataProvider 2019-09-11 13:42:07 +02:00
Alex Ross
462a8be7d4 Add title API for tree views (#80623)
* First pass at set view title

* Change to get/set instead of setTitle

and get the name of the view from the extension contributions
2019-09-11 10:56:45 +02:00
jrieken
e6df99aed8 implement CallsFrom/CallsTo proposal 2019-09-11 08:01:13 +00:00
Matt Bierner
011836a150 Prototyping custom editors (#77789)
* Custom Editor exploration

For #77131

Adds a prototype of custom editors contributed by extensions. This change does the following:

- Introduces a new contribution point for the declarative parts of a custom editor
- Adds API for registering a webview editor provider. This lets VS Code decided when to create a webview editor
- Adds an `openWith` command that lets you select which editor to use to open a resource from the file explorer
- Adds a setting that lets you say that you always want to use a custom editor for a given file extension
- Hooks up auto opening of a custom editor when opening a file from quick open or explorer
- Adds a new extension that contributes a custom image preview for png and jpg files

Still needs a lot of UX work and testing. We are also going to explore a more generic "open handler" based approach for supporting custom editors

Revert

* Re-use existing custom editor if one is already open

* Don't re-create custom editor webview when clicking on already visible custom editor

* Move customEditorInput to own file

* First draft of serializing custom editor inputs

* Use glob patterns instead of simple file extensions for matching custom resoruces for custom editors

* Add descriptions

* Try opening standard editor while prompting for custom editor

* Make sure we hide image status on dispose

* Make sure we restore editor group too

* Use glob patterns for workbench.editor.custom

* Allow users to configure custom editors for additional file types

* Use filename glob instead of glob on full resource path

* Adding placeholder for prompt open with

* Add enableByDefault setting for editor contributions

* Enable custom editors by default and add `discretion` enum

Changes `enableByDefault` boolean to a `discretion` enum. This should give more flexibility if we want other options (such as forcing a given custom editor to always be used even if there are other default ones)

* Allow custom editors to specify both a scheme and filenamePattern they are active for

* Rework custom editor setting

* Don't allow custom editors to be enabled for all resources by a config mistake

* Replace built-in image editor with one from extension

* Adding reopen with command

* Improve comment

* Remove commented code

* Localize package.json and remove image

* Remove extra lib setting from tsconfig
2019-09-10 17:56:57 -07:00
Sandeep Somavarapu
cae7f1c4b9 Merge branch 'master' into sandy081/userDataProvider 2019-09-10 15:17:32 +02:00
Sandeep Somavarapu
c26e198c9c settings sync using remote user data service 2019-09-10 15:16:57 +02:00
Alex Ross
ca4c1bf7a0 Go to ext host for system default shell and args for tasks
Fixes https://github.com/microsoft/vscode-remote-release/issues/1203
2019-09-05 14:59:08 +02:00
Isidor Nikolic
97a05cec1b Merge pull request #80122 from dgozman/fix-79583
Make DebugSession.name writable; fixes #79583
2019-09-05 11:30:30 +02:00
Dmitry Gozman
cb6b17d6f3 Make DebugSession.name writable; fixes #79583 2019-09-04 15:06:26 -07:00
Johannes Rieken
07d19b90a5 remove automatic merging/overwriting of decorations, simplify proposed API, #54938 2019-09-04 11:16:11 +02:00
Sandeep Somavarapu
3dc748ccca Merge branch 'master' into sandy081/userDataProvider 2019-09-03 14:55:28 +02:00
Benjamin Pasero
fa7eba4888 extensions - fully provide keytar API 2019-08-28 15:09:02 +02:00
Matt Bierner
78879b6a81 Log missing csp on extension host instead of main window 2019-08-26 15:42:16 -07:00
Sandeep Somavarapu
bb1866ab4e User data sync: Implement starting flow
- user identity
- user login provider
- user data provider
- activation event
- status bar UI
2019-08-25 20:25:16 +02:00
Johannes Rieken
62c31b7154 add SymbolTag, make tag a propertiy, #23927 2019-08-23 09:03:18 +02:00
Johannes Rieken
8b0bc473cd CompletionItemKindModifier -> CompletionItemKindTag, #23927 2019-08-23 08:12:33 +02:00
Benjamin Pasero
719cdaa87c web - implement callback auth flow 2019-08-22 10:43:41 +02:00
Johannes Rieken
1848b16313 tweak UI for deprecated completions, update API proposal #23927 2019-08-22 10:28:55 +02:00
Johannes Rieken
43aa378a3c better extension host logging 2019-08-21 17:43:49 +02:00
Johannes Rieken
f35f14ffa0 Merge branch 'master' into joh/completionsDeprecated 2019-08-21 10:13:39 +02:00
Matt Bierner
b1dd95c883 Fire a single batched event internally to update all webview view states
Previously we fired one event per webview. This change switches to fire on event per update
2019-08-20 16:20:42 -07:00
Johannes Rieken
78d462bd86 sync diagnostics, fixes #47292 2019-08-19 18:28:09 +02:00
isidor
a7cc79a554 debug: introduce data breakpoints 2019-08-16 17:16:46 +02:00
Johannes Rieken
21de711cdf remove proposed API vscode.commands.onDidExecuteCommand 2019-08-15 15:24:40 +02:00
Alex Ross
cdea3dcf3b Multi-select in custom tree view (#78625)
Part of #76941

The first argument is now the element that the command is executed on. The second argurment is an array of the other selected items
2019-08-15 11:15:31 +02:00