Commit Graph

11 Commits

Author SHA1 Message Date
Johannes Rieken
9683615c00 make ExtHostWindow a service so that it can be consumed in terminal world, fyi @Tyriar 2020-06-18 15:07:06 +02:00
Johannes Rieken
e80c62bdcb allow $openUri to accept URI and string 2019-11-15 10:53:04 +01:00
Johannes Rieken
e51ef85bcb Revert "allow $openUri to accept a URI and string, adopt consumer but keep the API as is"
This reverts commit 544b0abf5b.
2019-11-15 10:29:29 +01:00
Johannes Rieken
544b0abf5b allow $openUri to accept a URI and string, adopt consumer but keep the API as is 2019-11-15 10:28:03 +01:00
Matt Bierner
8079ff0001 Rename resolveExternalUri to asExternalUri
#81131
2019-09-30 14:22:47 -07:00
Matt Bierner
029009eafd Marking most private emitters as readonly
Emitters should generally not be reassigned as their corresponding event would also be lost. Marking these as readonly just to enforce this
2019-09-23 17:31:18 -07:00
Matt Bierner
a62b7dabe7 Make resolveExternalUri return just a plain uri instead of a disposable result
For #81131

We had trouble coming up with cases where extensions could actually reliably dispose of the resolved uri
2019-09-23 10:58:21 -07:00
Matt Bierner
a817a588c7 Moving resolve uri logic into openerService
- Add a resolveExternalUri function to the opener service. This service already has to know how to resolve external uris so it makes sense that the function lives there

- Move the tunneling logic for desktop into window.ts

- Make result of resolve disposable
2019-09-20 17:17:42 -07:00
Matt Bierner
27bac598cc Basic implementation of resolveExternalUri 2019-09-18 18:20:26 -07:00
Matt Bierner
80a2614355 Only try tunneling openExternal when we actually need to 2019-04-15 15:28:03 -07:00
Johannes Rieken
c0821aa5e9 move extHost-files to common 2019-04-10 10:26:52 +02:00