Commit Graph
567 Commits
Author SHA1 Message Date
Benjamin Pasero 66ad45b79a cli - ignore std error unless verbose (#183787) (#184031) 2023-06-01 10:32:33 +02:00
Benjamin Pasero 2a8dea3225 code --status displays a lot of errors before actual status output (fix #183787) (#183915) 2023-05-31 18:47:24 +09:00
Daniel Imms 9d1a210778 Support fish SI automatic injection
Fixes #139400
2023-05-19 15:45:28 -07:00
Connor Peet 773af9641d remote: fix port forwarding not working (#182980)
fix: register a remote socket factory in the shared process

Surprised this didn't fail more verbosely...

Fixes #182749
2023-05-19 19:42:53 +02:00
Daniel Imms 7f4221a955 Merge remote-tracking branch 'origin/main' into tyriar/utility_ptyhost 2023-05-10 08:10:12 -07:00
Sandeep SomavarapuandBenjamin Pasero d4632bb740 unc - adopt setting and handling of allow list (#181916)
* unc - adopt setting and handling of allow list (#5)

* unc - adopt setting and handling of allow list

* unc - set allow list on server too

* unc - pick our patched node.js for now

* bump electron

* unc - ignore sync is not needed with machine scope

* unc - use process set directly

* 🆙 22.5.1

* fix compile

---------

Co-authored-by: Benjamin Pasero <Benjamin.Pasero@microsoft.com>
2023-05-09 19:52:08 +02:00
Sandeep Somavarapu 3b74e3f2bd detect remote loggers in the UI (#181399) 2023-05-03 14:44:06 +02:00
Connor Peet cda21c19a7 cli: fix attach does not always work (#181273)
* fix: don't sync debug.lastExtensionDevelopmentWorkspace

* cli: fix attach does not always work

Seems like reading stdin when it's open but never written to blocks the process. Fix that, both by checking IS_INTERACTIVE_CLI before reading stdin, and by not passing stdin to the tunnel subprocess.

Fixes #179122
2023-05-01 14:58:25 -07:00
Benjamin Pasero 6d5b85427d debt - remove unsupported max_old_space_size option (#180183) 2023-04-17 22:32:23 -07:00
RoboandBenjamin Pasero e5f61433b5 chore: update to Electron 22 (#177600)
* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* sandbox - cleanup from electron 22 update (#178919)

* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* temp: update distro

* sandbox - cleanup from electron 22 update

* missing comile

* more changes

* fix build

* restore

* 💄

* compile

---------

Co-authored-by: deepak1556 <hop2deep@gmail.com>

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-04-03 09:09:31 +02:00
Daniel Imms d600b2e196 Move pty host from shared to main proc 2023-03-31 11:21:14 -07:00
Daniel Imms a9fbd36e4f Start extracting pty host starter into interface
Part of #175335
2023-03-30 11:05:25 -07:00
Martin Aeschlimann adbc695833 cli: fix code tunnel on snap (#177482) 2023-03-20 22:27:33 +01:00
Connor Peet c26e1a7a89 fix: code tunnel using program folder on windows (#177514)
Uses the common cwd() helper which pulls process.env.VSCODE_CWD

Fixes #175748
2023-03-17 13:14:55 -07:00
João Moreno 5bb3880b20 remove telemetry prop: common.source (#176688)
* remove telemetry prop: common.source

* remove extra code

* use interface

* use interface again

* fix tests
2023-03-10 15:22:27 +01:00
Sandeep Somavarapu 34652da5fa cli: more improvements (#176663)
- more logging
- reduce extensions scanning
2023-03-09 10:29:58 -08:00
Martin Aeschlimann f1d871dbf1 getMachineId should not use errors.onUnexpectedError (#176512) 2023-03-08 14:37:38 +01:00
Sandeep Somavarapu af53f2e00d fix #175673 (#175675) 2023-02-28 18:21:16 +01:00
Sandeep Somavarapu 33b821bab2 fix #175396 (#175631) 2023-02-28 00:58:27 -08:00
Sandeep Somavarapu 52dd56689f Improvements to logger and netwok requests logging (#175492)
- Able to create logger by passing id
- Support when conditions for loggers
- Separate logger for all network requests
- Log request and response headers
- Enable request logger on trace
- Add loggerService in CLI
2023-02-27 10:05:20 +01:00
Benjamin Pasero 9bbce647b3 debt - strict layer rules for more services (#175411) 2023-02-25 15:49:47 +01:00
Benjamin Pasero c3100304dd Reduce layer breakers in shared process (#175333)
* move `sharedProcessLifecycleService`

* move `remoteTunnelService`

* move `ExtensionsProfileScannerService`

* move `RequestService`

* move extension recommendations

* move native host service

* move `UserDataAutoSyncService`

* move `ExtensionTipsService`

* move `IMainProcessService`

* move `UserDataProfileStorageService`

* more moves

* move main process service
2023-02-24 16:02:20 +01:00
Benjamin Pasero b83565b135 Improve network requests logging (#175258) (#175325) 2023-02-24 15:58:31 +01:00
Benjamin Pasero ed6bb0790b sandbox - enable utility process in insiders by default (#175326) 2023-02-24 15:41:33 +01:00
Sandeep Somavarapu 2b54ca810f use vscode-userdata scheme for user data (#175212) 2023-02-23 09:22:51 +01:00
Benjamin Pasero 0ef4b66766 partially revert move of node files (#174815) 2023-02-20 18:09:48 +11:00
Benjamin Pasero 31edbf7ca6 sandbox - move shared process to node layer (#174581) 2023-02-17 10:18:01 +01:00
Sandeep Somavarapu 11fcbd051a prepare for server profiles (#174232)
* prepare for server profiles
- make state service available in server
- Intrdouce save stragey in state service - state shall be saved immediately in server
- use UserDataProfilesService that can save profiles in server

* feedback

* - add tests
- register IStateReadService in main
2023-02-14 08:58:44 +01:00
Sandeep Somavarapu 5936a4eb52 Enable profiles by default except web+remote (#171812)
#116740 Enable profiles by default except web+remote
2023-01-20 12:07:30 +01:00
Sandeep Somavarapu a3b2f85ba4 CLI: bail out when profile does not exist (#171646) 2023-01-18 09:57:43 -08:00
Connor Peet dec4735ed6 server: fix cpu loop on SIGPIPE (#170305)
- One missed uncaughtException site was causing a loop (maybe we want
  to handle this error on onUnexpectedError instead?)
- The SIGPIPE listener itself was causing a loop, as well. Only try to log once.
2023-01-17 19:25:58 +00:00
Sandeep Somavarapu 05d59b893e Log: Enhancements and cleaup (#171325)
- Make logger service primary source for log level
- Automatically register output channels for loggers from anywhere
- Use logger channels on remote processes (server, pty)
- clean up loggers and log service
2023-01-14 19:46:46 +01:00
Sandeep Somavarapu 5167c393aa proper fix for #165447 (#169883)
- use extensions location to get relative path
2022-12-23 10:47:34 +01:00
Connor Peet c87fa19f79 cli: avoid interactions when running integrated (#167780)
Fixes https://github.com/microsoft/vscode/issues/167760

The VS Code CLI gets run from a bash/shell script. This prevents interactions--in the former case, it doesn't look like a tty, and in the latter case batch scripts don't seem to support having interactive subprocesses.

This PR avoids interactions if stdin is not a tty, prompting the user to use the flag instead. Use of the flag is also persisted like an interactive agreement prompt.
2022-11-30 23:15:08 +00:00
Logan Ramos a3bde69a35 Allow machne id generation in main process (#167449) 2022-11-28 13:25:19 -08:00
Benjamin Pasero d5e5981ac7 debt - use ITelemetryAppender interface (#167067)
//cc @lramos15
2022-11-23 08:01:54 -08:00
Connor Peet 94ee5f5861 cli: automatically use distro qualities if available (#166961)
A fully-functioning CLI with tunnel capabilities requires product-specific
configuration that is not included in the OSS. This change has the CLI's build
script automatically look for a peer `vscode-distro` folder and, in a debug
build, set its build variables based on that.

It also works to set correct variables if vscode-distro is not found, based on
the OSS product.json (though this is not sufficient to run a fully fledged
tunnel.)
2022-11-22 06:13:16 -08:00
Martin Aeschlimann 0131be02f4 add editorWebUrl to tunnelApplicationConfig (#166872)
* add editorWebUrl to tunnelApplicationConfig

* bump distro & compile 'build'
2022-11-21 09:37:26 -08:00
João Moreno aa461e19a6 add trace logging to NativePolicyService (#166462)
related to #163418
2022-11-16 06:19:57 -08:00
Alex Dima 192c67db71 Always use app root for resource URIs (avoid usage of require) 2022-11-08 17:24:24 +01:00
Sandeep Somavarapu e9db45a0de Fix #164690 #164730 (#165331)
* Revert "Revert "Fix #164690 #164730 (#165279)" (#165302)"

This reverts commit d9ed6d1ef4.

* store migration completion marker in profile
2022-11-03 12:02:53 +01:00
Megan Rogge d9ed6d1ef4 Revert "Fix #164690 #164730 (#165279)" (#165302) 2022-11-02 17:48:32 -07:00
Sandeep Somavarapu 9c0c68c8cf Fix #164690 #164730 (#165279)
- Maintain default installed extensions manifest always
- Adopt to default installed extensions manifest
- Add externally installed extension to default extensions manifest
2022-11-02 22:48:15 +01:00
Connor Peet 578d59eb72 cli: fix code tunnel on macos 2022-10-24 10:55:22 -07:00
Martin Aeschlimann f10e84118b ci: use tunnelApplicationName (#164257)
fix location of tunnel command in CI and in code
2022-10-23 20:12:23 +03:00
Martin Aeschlimann 929c645c9a more tunnel access commands (#164076)
more remote tunnel access commands
2022-10-20 09:37:17 +02:00
Martin Aeschlimann 2bfe9bcd6f Allow to configure machine name for tunnel (#163812)
* Allow to configure machine name for tunnel

* fix tests

* fix tests
2022-10-18 08:36:11 -07:00
Sandeep Somavarapu 845f524e35 Merge pull request #162285 from dtivel/dtivel/verify-packages
Add extension signature verification service
2022-10-18 14:14:05 +02:00
Martin Aeschlimann 17c7a08962 Add cli & command to run the code server on the desktop (#163546)
Add cli & command to run the code server on the desktop
2022-10-13 15:02:42 +02:00
Sandeep Somavarapu 66c63cc8f7 review feedback 2022-10-11 15:32:22 +02:00