Commit Graph

9 Commits

Author SHA1 Message Date
Daniel Imms
a3c8ce1482 Force accept function in dispatchKeybinding
One common source of flakiness is just dispatching a keybinding and
not verifying it did its thing. This change adds a few accept functions
and also forces callers to provide an async function so that the caller
considers adding one as it's the norm, not the edge case.

Fixes #246731
2025-07-10 06:49:16 -07:00
Aiday Marlen Kyzy
fa548237be Adding acceptance condition to dispatchKeybinding in smoketests (#242570)
* adding code for smoke tests

* adding awaits

* changing wait code

* renaming dispatch to send

* moving comment

* update to send
2025-03-05 11:38:48 +01:00
Tyler James Leonhardt
9af6054416 Hide details if there are none (#181384)
* try this again

* use display to follow separator and make smoke tests only grab label not description or detail
2023-05-03 09:34:14 +02:00
Matt Bierner
3a8b7e4276 Highlight label should not create extra span nodes (#164657)
* Highlight label should not create extra empty dom nodes

I noticed that the `HighlightedLabel` class creates extra `span` elements for text ranges. These should not be needed. Using text children directly should be faster for creation and also reduce the number of nodes in the document

I also related the conditional spread with a longer version that uses a simple call to push. This is worth doing since `HighlightedLabel` is so widely used in the editor

* Update tests

* Update smoke test selector

* Update css
2022-11-01 08:00:38 -07:00
Benjamin Pasero
2d77c9e23a smoke - more robust usage of quick input / access (#139367)
* smoke - more robust `openQuickAccessAndWait`

* tweaks

* 💄

* trigger

* fix fluke

* poke

* fix terminal weirdness

* poke

* address feedback
2021-12-17 18:49:17 +01:00
Megan Rogge
00fa317c43 Add terminal profile smoke tests (#137079) 2021-11-17 14:00:01 -08:00
Benjamin Pasero
21431f6117 quick access - cleanup API for quick input 2020-03-24 10:13:45 +01:00
Benjamin Pasero
4f0b2b0689 tests - fix smoketests for new quick open impl 2020-03-24 08:39:53 +01:00
Jason Ginchereau
4f2c387de1 Refactor smoke UI automation into separate package 2019-09-05 09:16:29 -07:00