Commit Graph

9 Commits

Author SHA1 Message Date
Matt Bierner
6902a65a76 Align ext host name with internal name 2021-11-09 16:47:00 -08:00
Matt Bierner
87802c41fb Add readonly to iconPath properties
To update the icon, you have to update the entire object, not just `.light`/`.dark`
2021-11-03 14:48:47 -07:00
Benjamin Pasero
75aa22e7d9 editors - fix cyclic dependency 2021-07-07 13:22:38 +02:00
Matt Bierner
e1f0f8f513 Add override keyword in codebase (#120755)
For #120675

This uses a script to add the override keyword to places that need it in the codebase

Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
2021-04-08 10:05:20 -07:00
Matt Bierner
3499f63dc1 Exploration: Better transferring of TypedArrays used in Webview.postMessage (#115664)
* Improve passing of ArrayBuffers to and from webviews

Fixes #115807

* Serialize and restore typed arrays too

This also makes it so that if you pass the same ArrayBuffer twice in an object, we use a single object on the receiver side too

* Fix spelling

* Require VS Code 1.56+
2021-03-30 06:49:34 +00:00
Matt Bierner
ea5f05a435 Trying to clairify how webview options are used and passed around
- Move protocol types into protocol
- Hold off on combining the options objects until serialization
- Add explicit converstions instead of using `...`
- Make a few methods take property bags to help avoid passing arguments in wrong order
2021-03-05 18:49:17 -08:00
Matt Bierner
72cf134322 Don't transform viewColumn used when creating extHostWebviewPanel programatically
Fixes #111980

We should take the vscode.ViewColumn here, not the internal view column type
2020-12-18 13:57:37 -08:00
Benjamin Pasero
630e706ad2 Add open context to certain commands (#110475)
* editor commands - move API commands to workbench core

* rename EditorViewColumn => EditorGroupColumn

* mixin context to open commands

* address some feedback

* add comment
2020-11-12 17:01:13 +01:00
Matt Bierner
23fe7a39de Split extHost webview panels to own file 2020-08-26 16:46:26 -07:00