Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 18:19:12 +01:00
Code Issues Packages Projects Releases Wiki Activity
125,184 Commits 3,663 Branches 358 Tags
6aadaf13bd8b9ae3e42a328033e6f47b35a1955d
Commit Graph

87 Commits

Author SHA1 Message Date
Benjamin Pasero
6b924c5152 ESM merge to main (#227184) 
Co-authored-by: Johannes Rieken <jrieken@microsoft.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
 2024-08-30 10:31:46 +02:00
Alex Ross
4fa546bc42 CommentController.activeCommentThread seems to be the raw object instead of a proxy (#224282) 
Fixes #223025
 2024-07-30 03:57:06 -07:00
Alex Ross
065459e6e6 API feedback for comment thread reveal/hide (#221338) 
Part of #167253
 2024-07-10 12:15:20 +02:00
Alex Ross
53ed07606e Fix comment threads starting expanded (#218684) 2024-06-27 11:29:37 +02:00
Alex Ross
6ce4315300 Update file comment proposal (#216600) 
Part of  #214327
 2024-06-19 12:31:19 +02:00
Alex Ross
04a79b6ea6 Add API proposal to reveal a comment thread (#214251) 
Fixes #167253
 2024-06-04 10:00:49 -07:00
Alex Ross
a812bde8e5 Fix rapid focus flickering (#212153) 
Fixes #211831
 2024-05-07 10:49:52 +02:00
Matt Bierner
ae91138701 Add eslint rule for potentially unsafe disposable patterns (#209555) 
`DisposableStore`/`MutableDisposable` properties should almost always be `readonly`. Otherwise it's easy to accidentally overwrite the property and leak the previous value. This commonly happens with code such as:

```ts
class Foo {
     private disposables = new DisposableStore();

     bar() {
         this.disposables = new DisposableStore(); // leaks old values
         ...
     }
```

This change adds an eslint rule to enforce this and adopts `readonly` for the caught cases. I only needed to add 2 suppression comments, which seems like an acceptable tradeoff for helping catch a common mistake
 2024-04-04 10:34:45 -07:00
Alex Ross
3c1caff66c Display outdated comments differently in the Comments view (#207410) 2024-03-13 14:37:46 +01:00
Alex Ross
59857a62e6 Add reply to the comments view context menu (#207156) 
Fixes microsoft/vscode-pull-request-github#5698
 2024-03-08 12:39:44 +01:00
Alex Ross
85a26649de Add resource hint API for commenting range provider (#206444) 
Part of #185551
 2024-02-28 16:01:25 +01:00
Alex Ross
729612b22c Enable pre-fetching of comments (#206421) 
* Revert (most of) "Commenting range resource change proposal (#206346)"

This reverts commit 03bd0bb8d1.

* Enable pre-fetching of comments
Part of #185551
 2024-02-28 11:52:22 +01:00
Alex Ross
03bd0bb8d1 Commenting range resource change proposal (#206346) 
Part of #185551
 2024-02-27 15:16:20 +01:00
Alex Ross
2c28a908d4 API feedback for activeCommentThread (#204588) 
Part of #204484
 2024-02-07 12:55:21 +01:00
Alex Ross
f8546bc73f API to find the active comment thread (#204486) 
* API to find the active comment thread
Fixes #204484

* Add issue ref

* Add activeComment proposal to api tests

* Add settimeout to blur event
 2024-02-07 08:59:24 +01:00
Alex Ross
a6659cb883 API feedback for comment reactor (#202098) 
Part of #201131
 2024-01-09 09:41:54 -08:00
Alex Ross
646bb51ab2 Add comment reactors to comment reactions (#201132) 
Add comment reactors proposal
Part of #201131
 2023-12-18 07:57:34 -08:00
Alex Ross
42a991cd43 Various continue on comments fixes (#195260) 
* Various continue on comments fixes
Part of #194288

* Fix continue-on reply being restored before root comment
Fix duplicate continue-on comments

* Include monaco.d.ts changes
 2023-10-10 18:07:08 +02:00
Alex Ross
7ab575fe32 Adopt StorageScope.WORKSPACE in comments (#193098) 
Part of #183449
 2023-09-14 14:24:06 +02:00
Matt Bierner
6e251255fb withNullAsUndefined(x) -> x ?? undefined (#189987) 
Follow up on #189983

Replaces `withNullAsUndefined` with uses of `??`
 2023-08-08 16:45:52 -07:00
Alex Ross
ca24086170 Remove comments when a comment provider is unregistered (#180502) 
Fixes microsoft/vscode-pull-request-github#4566
 2023-04-21 14:36:29 +02:00
Hermann Loose
de3b0db8e8 Allow individual comments to be marked as draft (#173305) 
* Allow individual comments to be marked as draft

This is a proposal for #171166.

* Remove `hasDraftComments` from `CommentThread`

* Rename `CommentVisibility` to `CommentState`

* Rename `CommentVisibility` to `CommentState`

* Add api proposal check

---------

Co-authored-by: Alex Ross <alros@microsoft.com>
 2023-03-28 19:18:22 +02:00
Alex Ross
22c8efe084 Add file level commenting (#178478) 2023-03-28 13:39:05 +02:00
John Murray
14e7b2427e Handle file uri in CommentAuthorInformation.iconPath (fix #174690) (#175361) 2023-03-20 17:01:12 +01:00
Alex Ross
62e74ad047 File level comments API proposal (#177342) 2023-03-17 10:18:01 +01:00
Alex Dima
3d1487099b Add ExtensionIdentifierSet and ExtensionIdentifierMap 2023-02-26 00:13:58 +01:00
Alex Ross
b8e69611bd Finalize comment resolved/unresolved API (#171068) 
Fixes #127473
 2023-01-11 15:50:13 +01:00
Alex Ross
419d026431 Comment thread node so extension can use get/set body (#168605) 2022-12-09 15:57:09 +01:00
Marcus Revaj
aaac6f9a99 Add additional actions to CommentThread (#162750) 
* # Add additional actions to CommentThread

* Add in forgotten property

* # missing declaration

* type change

* Fix merge conflict errors

* # add proposed changes + fix styling

* # Allow "secondary action only" buttons

* # Add dropdown button styling fixes

* # add default button styling

* # add better styling to the dropdown button

* Remove duplicate css rule

Co-authored-by: Alex Ross <alros@microsoft.com>
 2022-11-17 11:16:06 +01:00
Alex Ross
fa2be83ef0 Remove unneeded export (#165178) 
Part of #164933
 2022-11-01 11:02:24 -07:00
Alex Ross
53e89be203 Preserve whether comment body is markdown string in replies (#158569) 
Part of microsoft/vscode-pull-request-github#3776
 2022-08-19 12:24:01 +02:00
Matt Bierner
342394d1e7 Use optional chaining for more method calls (#156938) 
This rewrites code such as:

```ts
if (thing) {
    thing.method();
}
```

To the more concise:

```ts
thing?.method();
```

This was done using a simple find replace. I tried to keep the change pretty conservative so it only touches simple cases like above
 2022-08-03 01:56:56 +02:00
Matt Bierner
13a80e03e2 Last pass using ?.() for method call (#152231) 
Follow up on f17b33faf2

This handles sightly more complex cases, changing:

```ts
if (a) {
    a.b.c();
}
```

to:

```ts
a?.b.c();
```
 2022-06-15 17:49:36 +00:00
Johannes
0656d21d11 auto-fixed prefer-const violation 2022-06-08 17:49:21 +02:00
Alex Ross
02b59c6e3a Comments widget doesn't reveal nicely (#148897) 
Fixes #148774
 2022-05-06 15:18:01 +02:00
Hermann Loose
f6e8ee9cca Introduce themable colors for resolved and unresolved comments (#145230) 
* Make `CommentThread.state` available to `ReviewZoneWidget`

* Apply themable colors for resolved and unresolved comments

* Update color properties in comment widget

* PR feedback

Co-authored-by: Hermann Loose <hermannloose@google.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
 2022-03-17 17:23:45 +01:00
Alex Ross
4ce5585b4c Use ext host comment value in commands (#144743) 
Part of #130107
 2022-03-10 10:35:56 +01:00
Johannes Rieken
daf029dfac extract marshalling id into its own file and untable uri from it, https://github.com/microsoft/vscode/issues/142476 2022-02-22 12:38:57 +01:00
Alex Ross
a330b89e5d Finalize comment timestamp API 
Fixes #139524
 2022-02-09 16:40:31 +01:00
Johannes Rieken
d84b15dd8c dto-ify arguments of proxied types 2022-02-08 11:01:23 +01:00
Alex Dima
6136c815bc Renames 2022-02-04 15:01:44 +01:00
Johannes Rieken
4a130c40ed enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Alex Ross
454dce4c53 Fix string comment body displayed as markdown 
Fixes #140967
 2022-01-21 14:14:20 +01:00
Alex Ross
8b27820fb2 Comment detail should be timestamp 
Part of #139524
 2022-01-21 13:21:17 +01:00
Alex Ross
adb8450420 Add timestamps to comments proposal (#139849) 
Part of #139524
 2022-01-13 11:33:43 +01:00
Alex Ross
4d1d73f6ef Revert "Add timestamps to comments proposal (#139849)" 
This reverts commit b978d7150c.
 2022-01-12 15:51:57 +01:00
Alex Ross
b978d7150c Add timestamps to comments proposal (#139849) 2022-01-12 14:41:23 +01:00
Alex Dima
973684056e Rename modes to languages 2021-12-30 18:52:15 +01:00
rebornix
38cef76ce7 fix #120680. 2021-11-01 18:10:42 -07:00
rebornix
f6de5208d8 fix #126475 2021-10-19 16:37:00 -07:00