Commit Graph

7 Commits

Author SHA1 Message Date
Benjamin Pasero
6b924c5152 ESM merge to main (#227184)
Co-authored-by: Johannes Rieken <jrieken@microsoft.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-08-30 10:31:46 +02:00
Johannes
bf0b4ac976 remove old notebook events from API proposal and implementation 2022-03-28 14:47:56 +02:00
Johannes
1799e12d7b for now, don't deepFreeze the onDidChangeNotebook event, https://github.com/microsoft/vscode/pull/144868, https://github.com/microsoft/vscode-jupyter/issues/9327 2022-03-11 09:21:15 +01:00
Johannes Rieken
52faf21ef2 move/copy onDidSaveNotebookDocument-event into workspace, add onDidChangeNotebookDocument-event which fires for any notebook change: metadata, structure, cell output, cell metadata 2022-03-08 14:15:35 +01:00
Matt Bierner
8b6547aa2c Transfer notebook output as VSBuffer (#130452)
* Transfer notebook output data as a VSBuffer

This PR transfers notebook output as an VSBuffer instead of as a array of numbers. This significantly reduces the message size as well as the serialize/deserialize times

To accomplish this, I've introduced a new `SerializableObjectWithBuffers` type. This specially marks rpc objects that contain VSBuffers. This is needed as our current RPC implementation can only efficently transfer VSBuffers that appears as top level arguments. The rpcProtocol now can also identify top level `SerializableObjectWithBuffers` arguments and ensure these are serialized more efficently.

This is easier than trying to extract the `VSBuffer` proeprties to top level arguments. It also lets us easily support return types that may contain buffers

* use SerializableObjectWithBuffers when dealing with (old) notebook controllers

Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
2021-08-17 09:57:57 -07:00
Johannes Rieken
d0cc52143b change IOutputItemDto to use real bytes, add many dedicated dto-types for transporting output (which cannot be bytes), remove metadata2 from renderer 2021-06-10 11:18:46 +02:00
Johannes Rieken
a31c6c3550 extract ExtHostNotebookDocumentsShape into its own thing 2021-06-07 17:41:12 +02:00