Commit Graph

43177 Commits

Author SHA1 Message Date
Johannes Rieken
f1583f11ab debt - use more ISuggestDataDtoField 2019-10-22 15:27:09 +02:00
isidor
2aa29a9895 Allow preLaunch task for compound list
fixes #45676
2019-10-22 15:14:18 +02:00
isidor
4d71eba647 fixes #81286 2019-10-22 12:13:25 +02:00
Benjamin Pasero
d712aeb26b opn/open should work with app URI scheme too 2019-10-22 12:06:37 +02:00
Benjamin Pasero
21da9e008b 💄 docs for env 2019-10-22 12:06:37 +02:00
isidor
8d2b16c4b1 fixes #74558 2019-10-22 12:06:20 +02:00
isidor
3d84f5ddfb fixes #82964 2019-10-22 11:22:59 +02:00
Joao Moreno
403b81cbe3 fixes #83043 2019-10-22 11:21:41 +02:00
Daniel Imms
c58aaab8a1 Fix lgtm terminal alert 2019-10-21 19:02:03 -07:00
Rachel Macfarlane
c10b3b7426 Improve wording of issue reporter clipboard warning, fixes #82856 2019-10-21 16:08:16 -07:00
Miguel Solorio
d1499b2664 Fix #58531, cleanup viewlet margins 2019-10-21 14:53:14 -07:00
Martin Aeschlimann
19ff2d5393 WSL: Improve formatting on "recent workspaces" list. Fixes microsoft/vscode-remote-release#1633 2019-10-21 23:43:30 +02:00
SteVen Batten
e5dd57a127 add helper function for menubarvisibility
fixes #82907
2019-10-21 14:40:38 -07:00
Matt Bierner
fe3d0a9e56 Marking fields as readonly 2019-10-21 11:43:04 -07:00
Matt Bierner
06def35ca5 Finalize asExternalUri
Fixes #82896
2019-10-21 11:18:36 -07:00
Benjamin Pasero
62ea960353 API: Finalize env.uiKind (fixes #82883) 2019-10-21 18:31:37 +02:00
Joao Moreno
86ef041ef5 fixes #82085 2019-10-21 17:59:05 +02:00
Dhairya Nadapara
0abf6cf816 added split pane options to settings (#82888)
* added split pane options to settings

* moved option to workbench config

* updating description messages

* review changes

* 💄
2019-10-21 17:58:15 +02:00
Joao Moreno
aa28cc6e36 fixes #82229 2019-10-21 16:53:30 +02:00
isidor
06d1b4ad41 accessibility service: log accessibility metrics
fixes #81964
2019-10-21 16:46:07 +02:00
Joao Moreno
53c0d13e17 fixes #82869 2019-10-21 16:37:38 +02:00
Joao Moreno
0b347ca8cf fixes #79635 2019-10-21 16:16:08 +02:00
Johannes Rieken
ec2e234968 fix (workaround) for #82874 2019-10-21 15:50:30 +02:00
Benjamin Pasero
935b0f1c0d debt - optional chaining 2019-10-21 15:44:21 +02:00
João Moreno
cfb88f21c9 Merge pull request #82972 from frobinsonj/fix-80741
Filter out dead keys in tree keyboard navigation
2019-10-21 15:42:50 +02:00
Joao Moreno
dff18ede6c extract CachedListVirtualDelegate 2019-10-21 15:34:25 +02:00
Benjamin Pasero
139dde2e07 web - change environment to payload API 2019-10-21 14:57:58 +02:00
Alex Dima
98cd33b38a Fixes #27801: Make the textarea use a proper font size, line height and height to help with the positioning of input pop-ups 2019-10-21 13:01:16 +02:00
Martin Aeschlimann
2d77f6355a Theme default color is not showing up properly. Fixes #82561 2019-10-21 12:58:36 +02:00
Freddy
130d231fd5 Filter dead keys in tree keyboard navigation
Fixes #80741
2019-10-21 11:56:35 +01:00
Joao Moreno
ab0ab88f81 fixes #69400 2019-10-21 12:33:46 +02:00
Benjamin Pasero
a46824c2e9 add todo to move into servcie 2019-10-21 12:21:56 +02:00
Alex Dima
7f29065158 Fixes #82963: Fix NPE 2019-10-21 12:06:02 +02:00
Isidor Nikolic
2461c3448d Merge pull request #82945 from jeanp413/fix-77837
Fixes debug console stops autoscrolling when a line wraps around
2019-10-21 11:30:04 +02:00
Joao Moreno
6f2a65ec2f Revert "fixes #82677"
This reverts commit 97b2c927c7.
2019-10-21 11:23:24 +02:00
Benjamin Pasero
07ee925337 Web: implement browser extension debug service properly (fixes #81493) 2019-10-21 11:22:32 +02:00
Martin Aeschlimann
715cdf7c63 Empty links in recent workspaces list. FIxes #74363 2019-10-21 11:06:24 +02:00
Alex Ross
fd2133691a Fix tasks depends on for tasks while in a workspace
Fixes #82938
2019-10-21 10:53:48 +02:00
isidor
0bf0936b81 fixes #82863 2019-10-21 10:37:34 +02:00
Andrew Liu
6bba03b84f Fix 30419 and 80649 - Allow Setting the Number of Recent Tasks (#82757)
fixes #30419 and fixes #80649
2019-10-21 10:35:06 +02:00
jeanp413
a18a7bf9c9 Fixes #77837 2019-10-20 21:20:11 -05:00
Matt Bierner
cbda1fdeb7 Fix drag and dropping of editors for webviews (#82813)
* Fix drag and dropping of editors for webviews

Fixes #25854

This change does the following:

- Have the webview editor create an `EditorDropTarget`. This is required because the webview itself is not part of the normal editor dom (it exists as a top level node in the workbench so that we never reparent it). This means that the standard `EditorDropTarget` does not work.

- Make webviews set `pointer-events: none` while a drag is happening. When a drag happens on Electron's webviews or a normal iframe, no  drag and drop events seem to get generated. The fix is to set `pointer-events: none` while the drag is happening. But it's also difficult to detect when the drag is happening because the  `EditorDropTargets` class eats the drop event itself. The only reliable seeming way I could find to determine when a drag starts and ends is looking at global events on the window.

This workaround is pretty ugly. I'm not sure if there's some better approach that would work with webviews

* Add public `createDropTargets` helper on editorPart

Unfortunatly we can't add this method to IEditorGroupsService as it uses the `HTMLElement` type

* Rename function to createEditorDropTarget

* Use instanceof instead of cast
2019-10-19 09:41:21 -07:00
SteVen Batten
2710db93e2 fixes #70893 2019-10-18 18:08:03 -07:00
Rob Lourens
dfaff021a8 Let ListWidget's reveal take no action if the revealed element is already overflowing the viewport
Fix #78237
2019-10-18 17:03:44 -07:00
Rob Lourens
a9640d05a2 Fix gear icon cut off in settings editor sometimes
Fix #81764
2019-10-18 17:03:44 -07:00
SteVen Batten
81d1db9295 remove special case of titlebar visibility change 2019-10-18 15:38:49 -07:00
SteVen Batten
c805ab792e centralize part visibility eventing
add context key for editor area visible
fixes #67707
2019-10-18 15:38:48 -07:00
Rob Lourens
b3eb413eaf Fix refiltering when switching scopes with a search.
Fix #79987
2019-10-18 15:08:42 -07:00
Matt Bierner
e86b622a2f Update monaco for TS 3.7 2019-10-18 14:44:17 -07:00
Matt Bierner
564d47339f Convert to async 2019-10-18 14:36:21 -07:00