Commit Graph

8107 Commits

Author SHA1 Message Date
Baptiste Augrain
6e76e0e1b7 feat: select the folding provider to use (#157434)
* feat: support extension id in property `editor.foldingStrategy`

* work in progress

* use new setting 'editor.defaultFoldingRangeProvider' defined in workspace

* revert editorOptions changes

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-10-23 15:45:34 +02:00
Matt Bierner
93985c5dd6 Don't update webview options if they have not changed (#164202) 2022-10-20 19:40:01 -07:00
Matt Bierner
8cf88f7d8f Mark exthost/main arrays in events as readonly (#164187)
This better aligns the internal types of these event with the public apis
2022-10-20 15:07:11 -07:00
Johannes Rieken
79c00cf98c Merge pull request #164034 from microsoft/joh/markerVersionId
Have the ability to add `modelVersionId` to `IMarkerData` and `IMarker`
2022-10-20 22:53:57 +02:00
Matt Bierner
b1e64a32ae Remove unused property (#164092) 2022-10-20 13:26:37 +02:00
Matt Bierner
c275f7a6d8 Adopt DisposableMap in mainThreadWebviewView (#164091) 2022-10-20 13:26:02 +02:00
Johannes
62e2760ff5 Have the ability to add modelVersionId to IMarkerData and IMarker 2022-10-19 16:08:38 +02:00
Tomer Chachamu
3bd2b70f4a Allow extension authors to set valueSelection in a QuickPick/InputBox (#157022) 2022-10-19 16:05:01 +03:00
Logan Ramos
75cdec29a4 Fix wrong proposed api check (#163964) 2022-10-18 21:16:46 +02:00
Matt Bierner
b6f4df8a5e Run notebook webviews in consistent origins (#163956) 2022-10-18 11:24:30 -07:00
Peng Lyu
301996072b Merge pull request #163519 from debonte/notebookMultiMove
Fix `workspace.onDidChangeNotebookDocument` event for multi-cell moves
2022-10-18 09:34:26 -07:00
Logan Ramos
256aaf296b Don't use @microsoft.com in source code (#163933) 2022-10-18 07:38:15 -07:00
Logan Ramos
6873816408 Test cleaning for telemetry API (#163885) 2022-10-18 13:12:56 +02:00
Matt Bierner
28fcaf139a Start cleaning up structure of code action code (#163875)
- Moves common types into `common`
- Move some command IDs into common
- Moves getCodeActions into `codeAction.ts` instead of `codeActionCommands`
2022-10-17 21:09:37 +02:00
Matt Bierner
337b02953f Move TernarySearchTree to own file (#163684)
* Move TernarySearchTree to own file

This class is taking up most of `map.ts`. I think it's time to split it out into its own file

* Adding missing file change

* Update changed file
2022-10-17 09:21:23 -07:00
Matt Bierner
3f00e7edb8 Add allow list of webview command uris (#163501)
Add allow list of command uris

fixes #163500
2022-10-17 08:57:35 -07:00
Joyce Er
f9a0fdeff2 Tolerate minor edit session identity differences (#163804)
Also add basic support for partial edit session identity matches
2022-10-16 23:51:51 -07:00
Peng Lyu
5612f80f8d Pass associated notebook document to kernel source command (#163701) 2022-10-14 14:33:05 -07:00
Sandeep Somavarapu
7daf9c77ef make access to inspect props delayed (#163679) 2022-10-14 11:38:16 -07:00
Tyler James Leonhardt
f83ad50c89 Load bundle for web from unpkg service (#163641)
* move extensionResourceLoader service into platform

* use the ExtensionResourceLoader to load translations from a language pack

* do join after

* missed a deletion
2022-10-14 16:52:29 +02:00
Logan Ramos
28da8ed1aa Add some tests for extension telemetry (#163584)
* Add some tests for extension telemetry

* Fix failing tests

* More attempts at fixing failing tests

* Ok, I think I fixed the tests this time
2022-10-14 16:38:36 +02:00
Matt Bierner
7ef8e6b87a Use consistent origin for webview views (#163602)
For #132464
2022-10-13 17:40:07 -07:00
Sandeep Somavarapu
2b50ab06b1 support passing extension log level from cli (#163566) 2022-10-13 18:21:47 +02:00
Johannes Rieken
0dd2dc89d2 hook up unhandled extension errors with extension telemetry (#163424)
* hook up unhandled extension errors with extension telemetry

* fix layering

* forward unhandled language provider errors to extension telemetry loggers
2022-10-13 09:04:08 -04:00
Sandeep Somavarapu
894aa9a7a7 Log improvements (#163532)
* - expose log level in the proposed api
- ability to set log level per logger

* fix tests
2022-10-13 03:48:52 -07:00
Don Jayamanne
6527023564 Additional test for handling stream outputs in notebooks (#163502)
* Additional test for nb stream output handling

* test
2022-10-13 18:02:35 +11:00
Erik De Bonte
56d45b269c Merge branch 'main' into notebookMultiMove 2022-10-12 22:18:26 -07:00
Erik De Bonte
74c0ed7459 Fix length in change event 2022-10-12 21:59:04 -07:00
Tyler James Leonhardt
2457d9eb46 Plumbing for desktop to pick up strings from language packs (#163494)
Web will come in the next PR (hence the TODO)

Also this includes the smallest translation change which will be the ultimate test that this is all working.
2022-10-12 17:08:27 -07:00
Erik De Bonte
4f32f4069d WIP 2022-10-12 14:52:24 -07:00
Rob Lourens
cf47b76c63 Finalize notebookDebugOptions API (#163316)
* Finalize notebookDebugOptions API
Fix #147264

* Backcompat for the option from vscode-jupyter

* Undo comment

* Fix build
2022-10-11 20:25:51 -07:00
Matt Bierner
d05d85a78b Move html rewriting for old webviews to (#163367)
The `asWebviewUri` methods was introduced in VS Code 1.38. It's silly that we still force every single webview to pay the cost of trying to rewrite the old style uris we supported in very old versions of VS Code

Instead I've moved this logic into the extension host and disabled it for all extensions that target VS Code 1.60+ or newer. This means it never applies to internal webviews, notebooks, webview views, or custom editors (these public apis were all introduced after the switch to `asWebviewUri`)
2022-10-11 16:08:17 -07:00
Matt Bierner
d9166909b6 Small clean up to mainthread and exthost custom editor code (#163350)
- Align property names
- Move private method to function
- Formatting
2022-10-12 00:36:48 +02:00
Don Jayamanne
43957ccfe1 Compress streams in notebook outputs (#160946)
* Revert "Compress notebook output streams before rendering (#160667)"

This reverts commit 4230c22a08.

* Compress stream output items

* Minor perf improvements

* Misc

* Comments

* Added tests

* Merge issue

* More merge issues

* Misc

* Address code review comments
2022-10-11 14:43:46 -07:00
Logan Ramos
e814cb5c65 Telemetry API (#160902)
* First run of scaffolding out a telemetry API

* Make telemetry config up to date

* Further work on telemetry API

* Implement telemetry logging extension host

* Add logging to exthost logger

* Extract telemetry cleaning

* Add data cleaning

* Update email regex
2022-10-11 15:44:18 -04:00
Tyler James Leonhardt
53785ee45d Finalize localization API (#163344) 2022-10-11 12:39:39 -07:00
Matt Bierner
f4c58486f4 Run all webview panels of a given viewtype in the same origin (#163236)
For #132464
2022-10-10 21:15:14 -07:00
Alex Ross
1c42eb1c3d View badge extension API documentation wrong (#163202)
Fixes #162900
2022-10-10 10:42:46 -07:00
Matt Bierner
d39c1b3ee0 Remove unused field (#163199) 2022-10-10 10:35:58 -07:00
Alex Ross
23e6c032af Start enforcing the tunnels API (#163187)
* Start enforcing the tunnels API

* Fix API test
2022-10-10 10:10:24 -07:00
Matt Bierner
1d45633795 Add DisposableMap helper (#163006)
Adds `DisposableMap` to help manage the lifecycle of maps of  disposable values. This is useful for a few reasons:

- `DisposableMap` is itself disposable, so you can use it with `_register` or add it to a `DisposableStore`
- The implementation of `set` on `DisposableMap` prevents leaking values on override
- The `delete` implementation also makes sure it disposes of the deleted values
2022-10-07 15:28:36 -07:00
Connor Peet
125898b774 testing: ensure discovery happens before "run at cursor" executes (#162980)
With this change, when "run at cursor" is executed, we'll:

1. Save the file
2. Forcefully sync tests from the ext host (normally they're on a
   300ms throttle)
3. Wait for `busy = false` on all tests whose URIs are a parent or equal
   to the current file.

Fixes #157656
2022-10-07 14:48:23 -07:00
Connor Peet
b9ebb059db testing: use real test item instances if available in command args (#162898)
Fixes https://github.com/microsoft/vscode/issues/154659 (for realsies)
2022-10-06 15:56:37 -07:00
Matt Bierner
4affcdb07c Add documentation and clean up IWebviewWorkbenchService (#162792) 2022-10-06 15:00:49 -07:00
Matt Bierner
1a5101ff73 Mark arguments to WorkspaceEdit.set readonly (#162888)
These values are not modified. Mark these readonly to allow using these apis in more cases
2022-10-06 14:19:28 -07:00
Megan Rogge
5ab910f16f no telemetry needed when task end event gets fired twice (#162861)
fix #160572
2022-10-06 13:41:49 -07:00
Megan Rogge
9051852b73 log more info when tasks to terminate is not found (#162839) 2022-10-06 12:32:48 -07:00
Tyler James Leonhardt
0f8068478e Support format2 (#162785) 2022-10-06 15:02:33 +02:00
Johannes
3e02b209de finalize WorkspaceEditMetadata api
fixes https://github.com/microsoft/vscode/issues/112109
2022-10-05 09:05:30 +02:00
Tyler James Leonhardt
d942736bf1 API feedback (#162704)
* align bundle and uri value to be undefined together
* Document everything
2022-10-04 17:27:23 -07:00