Commit Graph

89 Commits

Author SHA1 Message Date
Matt Bierner
f4fe2163a9 Remove any casts in some built-in extensions
For #269213
2025-10-06 10:08:20 -07:00
Matt Bierner
360c9fd134 Add lint rule for as any and bulk ignore all existing breaks
For #269213

This adds a new eslint rule for `as any` and `<any>({... })`. We'd like to remove almost all of these, however right now the first goal is to prevent them in new code. That's why with this first PR I simply add `eslint-disable` comments for all breaks

Trying to get this change in soon after branching off for release to hopefully minimize disruption during debt week work
2025-10-02 23:38:33 -07:00
xymopen_Official
e20adc378e Add node as npm script runner (2nd) (#240527)
* refactor: Separate `createScriptRunnerTask` and `createInstallationTask` from `createTask`

* feat: Add `npm.scriptRunner`

* feat: Add Node.js as script runner

* refactor: Refactor `isPrePostScript`

* refactor: Extract `get*Command`

* fix: Typo

* style: Remove no-op `catch`es

* fix: `node --run` doesn't support `--silent`

* refactor: Use `.map` in `escapeCommandLine`

* chore: Remove TODO

Upstream reviewer is ok with current state

* fix: Fix error the resolved task definition differs from the original
2025-02-17 04:20:07 +00:00
Rob Lourens
0264c2afc0 Revert "Add node as npm script runner (#236967)" (#240413)
This reverts commit 6a5991cfb6.
2025-02-11 20:17:30 +01:00
xymopen_Official
6a5991cfb6 Add node as npm script runner (#236967)
* refactor: Separate `createScriptRunnerTask` and `createInstallationTask` from `createTask`

* feat: Add `npm.scriptRunner`

* feat: Add Node.js as script runner

* refactor: Refactor `isPrePostScript`

* refactor: Extract `get*Command`

* fix: Typo

* style: Remove no-op `catch`es

* fix: `node --run` doesn't support `--silent`

* refactor: Use `.map` in `escapeCommandLine`

* chore: Remove TODO

Upstream reviewer is ok with current state
2025-02-07 17:26:29 +00:00
Johannes
e6f315d2fc eng - use esModuleInterop for extensions 2024-10-01 21:57:30 +02:00
Megan Rogge
ba5f685b65 Merge pull request #124803 from nrayburn-tech/npm-activation
npm extension - check for root package.json before findFiles
2024-01-22 15:04:27 -08:00
susiwen8
d022a7b517 fix: install in npm script shouldn't be opened 2023-12-17 22:09:59 +08:00
weartist
669e5c578c adjust to correct link 2023-06-01 09:40:34 +08:00
Matt Bierner
952bbb6720 Adopt l10n for npm package (#165527)
For #164438
2022-11-04 13:56:39 -07:00
Megan Rogge
cf94d8370d use const instead of literal (#151742)
use const
2022-06-10 13:56:43 +00:00
Johannes
ed9ed45794 Merge branch 'main' into joh/voluminous-lobster 2022-06-10 09:07:30 +02:00
Megan Rogge
4222eb73aa allow excluding npm install script from the npm scripts view (#151647)
fix #149924
2022-06-09 17:15:43 -07:00
Johannes
3622010b64 Merge branch 'main' into joh/voluminous-lobster 2022-06-09 09:08:20 +02:00
jram
6d91b80dd8 [npm extension] exclude top level npm_modules when detecting npm scripts in workspaces (#150205)
* Check if current folder is a path that should be excluded

* update regex to be an exact match
2022-06-08 10:46:54 -07:00
Johannes
0656d21d11 auto-fixed prefer-const violation 2022-06-08 17:49:21 +02:00
Megan Rogge
7c22caad55 Use I prefix for task interfaces (#151350) 2022-06-07 09:27:44 -07:00
Alex Ross
a576b4c066 Fix npm task path now that there's no slash 2022-04-19 15:15:36 +02:00
Alex Ross
5468607181 Make npm task path fix backwards compatible
Fixes #147193
2022-04-12 16:02:47 +02:00
Alex Ross
2381cae3a5 Fix extra character in npm task path
Fixes #146165
2022-03-29 15:47:12 +02:00
Alex Ross
6a9c6c2ff9 Fix npm task resolving to include task group
Fixes #142615
2022-02-09 13:46:05 +01:00
Johannes Rieken
4a130c40ed enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Alex Ross
419d62aa0b Fix multiple lockfile warning with npm workspaces
Fixes #139654
2021-12-23 14:02:18 +01:00
Alex Ross
0c202aa22a Improve multiple lock file warning
Fixes #138174
2021-12-08 14:49:03 +01:00
Nick Rayburn
cea2397e06 npm check for root package.json before findFiles 2021-05-27 23:13:03 -05:00
Alex Ross
f38f90dfe1 Improve package.json file check
Fixes #120279
2021-04-22 17:35:45 +02:00
Alex Ross
3da9f36645 Cancel packagejson search in npm after 1 second 2021-03-18 12:00:20 +01:00
Alex Ross
3c238e71db Add "hasPackageJson" check back to npm view
and let it find files in directories
Fixes #117950
2021-03-04 14:39:04 +01:00
Alex Ross
a4a6607ceb Use weak shell quoting for npm tasks with --
Part of #115876
2021-02-05 16:22:55 +01:00
Connor Peet
5b2dc0cad2 npm: move debug script lens into npm, clean up parsing logic
This keeps our npm logic in one place and avoids activating the heavier-
weight `js-debug` extension on every .json file.

Also, use the same command to debug both from the explorer and
from script lens.

Fixes https://github.com/microsoft/vscode-js-debug/issues/782
2021-02-04 18:41:27 +00:00
Alex Ross
3973012a9c Only getPackageManager once per folder
Part of #115384
2021-02-04 16:45:24 +01:00
Jonathan Mataloni
9441f1c645 Add support for npm scripts with a space (#113840)
This PR fixes #113750
2021-01-18 12:02:53 +01:00
Alex Ross
59ba6494b9 Better timing for multiple lock files warning
Fixes #111635
2020-12-09 10:10:58 +01:00
Alex Ross
8d171e6492 Improve multiple lock files notification
Fixes #111589
2020-12-02 14:39:46 +01:00
Alex Ross
eea8648466 Use vscode.open in NPM scripts view
Part of #110497
2020-11-13 14:42:54 +01:00
Alex Ross
bea76730f1 feat: Autodetect npm.packageManager #102050 (#102494)
Detects the preferred  package manager
and if multiple are present, warns and uses
in priority order: npm => yarn => pnpm
Fixes #102050
Co-authored-by: Alex Ross <alros@microsoft.com>
2020-11-02 14:48:11 +01:00
Alex Ross
8d0ca78841 Revert "feat: Autodetect npm.packageManager #102050 (#102494)"
This reverts commit f8c0e3b612.
2020-10-27 10:07:45 +01:00
Alex Ross
0b148e83db Provide command to get package manager
Fixes #109071
2020-10-21 15:27:18 +02:00
Shivang Tripathi
f8c0e3b612 feat: Autodetect npm.packageManager #102050 (#102494)
Detects the preferred  package manager
and if multiple are present, warns and uses
in priority order: npm => yarn => pnpm
Fixes #102050
Co-authored-by: Alex Ross <alros@microsoft.com>
2020-10-09 11:01:47 +02:00
Connor Peet
916de64d89 fix: debug buttons in a nested package.json
Fixes #108000
2020-10-02 14:17:17 -07:00
Alex Ross
0de8d51904 Finalize task detail API
Fixes #69785
2020-08-27 11:08:48 +02:00
Connor Peet
85b70cc872 npm: enable debugging all scripts
Fixes https://github.com/microsoft/vscode/issues/104403
Fixes https://github.com/microsoft/vscode/issues/102847
2020-08-10 16:24:39 -07:00
Alex Ross
45da8ac9bc Fix resolveTask for npm install
Fixes #97197
2020-05-11 16:20:22 +02:00
Erich Gamma
e77c58dd0b Inform user when 'npm.autoDetect' is off. 2020-02-20 16:17:18 +01:00
Alex Ross
acb595b158 Exclude .vscode-test folder from npm task detection
Part of #88328
2020-01-09 10:36:44 +01:00
Alex Ross
5a1242ab45 Detail for npm: install task (#83765)
Fixes #83654
2019-11-01 15:26:58 +01:00
Alex Ross
87998af618 Add task detail property and adopt in npm extension
Fixes #69785
2019-10-22 15:56:21 +02:00
Erich Gamma
7485ffde50 Some polish for 'Run NPM Script in Folder' 2019-10-14 16:13:06 +02:00
helen3141
cecda63be5 Pull Request feedback: updated documentation and naming, read from cache if available instead of creating new tasks 2019-10-11 15:18:31 -07:00
Helen Choi
1f78795f58 enable running individual npm scripts in the containing folder 2019-08-27 19:25:20 -07:00