Commit Graph

62 Commits

Author SHA1 Message Date
Benno 0b3e54edb1 update #91296 allow multiple workspace roots (#92082)
* update #91296 allow multiple workspace roots

* update #92082
2020-03-09 12:56:54 -07:00
Andrew Liu 37eeb3755a quick fix (#85506) 2019-11-25 11:30:04 -08:00
Matt Bierner cbd414ba58 Don't force refresh the markdown preview's html when changing the active document 2019-11-08 17:00:56 -08:00
Matt Bierner 979e2b0387 Remove duplicate call to dispose 2019-11-08 16:56:06 -08:00
Matt Bierner 43a2ca8840 Remove forceUpdate property 2019-11-08 10:38:51 -08:00
Matt Bierner 1cdb534185 Try to redeuce duplication for create vs refactor 2019-11-08 10:38:51 -08:00
Matt Bierner 886ea7a8b4 💄 2019-11-08 10:38:51 -08:00
Matt Bierner 7ee9aa4757 Rename and move types around to get ready for webview editor based previews 2019-11-08 10:38:51 -08:00
Matt Bierner 21ba436c51 Fix one more case of #81320
The markdown link people write may be uri encoded. We need to decode these before trying to open them
2019-10-09 13:01:30 -07:00
Matt Bierner 36aa903d5a Rewrite how we handle links in the md preview
Try to simplify how we resolve links:

- Move most logic out of the preview itself.
- Simplify the amount of rewriting we do in the markdown engine
2019-10-04 17:57:33 -07:00
Matt Bierner ef698fa6cd Make markdown refresh more stable
Fixes #80680

- Always sync the current preview line number with the editor, even when `scrollEditorWithPreview` is false

- If the md file is focused and refresh is called, do not try resetting the current line to match the editor file. This mainly effects the case where `scrollEditorWithPreview` is false
2019-10-03 13:46:31 -07:00
Matt Bierner 153e063486 Fix markdown preview refresh command potentially resetting preview scroll position to top if focused on preview
Fixes #80680
2019-09-11 20:50:52 -07:00
Matt Bierner 2fe62e7dfe Use the document that contains the md link as the resource for getting config, not the target document 2019-09-10 16:31:53 -07:00
Matt Bierner 7a00ddf9f8 Format files for 3.6
Fixes #80118
2019-09-02 21:29:05 -06:00
Matt Bierner a66e9d4835 Don't dispose markdown preview emitters before firing events
Fixes #79827
2019-08-26 13:40:07 -07:00
Matt Bierner 646d4ddb75 Use _register 2019-08-20 15:07:25 -07:00
Matt Bierner c5dc9d16be Finalize asWebviewUri api
Fixes #79242

As discussed, renames `toWebviewResource` to `asWebviewUri` to be consistent with the `asAbsolutePath` api naming
2019-08-19 20:18:26 -07:00
Salvador Cabrera 34339f92c4 Fix: Markdown Preview scroll remains same after clicking on some other link #78465
Improves the behavior on how markdown preview behaves when clicking a link
2019-08-19 09:35:06 -05:00
Matt Bierner e1d3dd53d1 Mark static readonly 2019-07-22 16:24:53 -07:00
Matt Bierner b850405aa6 Merge pull request #76647 from masliu/master
Save resourceColumn for previews, fixes #74008
2019-07-17 16:01:46 -07:00
Matt Bierner 4c07744817 Make sure we handle loading of markdown resources from UNC workspace correctly
Fixes #48403
2019-07-09 15:52:43 -07:00
Matt Bierner c01a3a718d Use clearer name for csp webview element
#76489
2019-07-09 11:45:20 -07:00
Matt Bierner a558a9504a Adding toWebviewResource api
For #76489
2019-07-08 18:38:47 -07:00
masliu 173d010b0a Rename sourceViewColumn to resourceColumn 2019-07-04 22:29:23 -04:00
masliu 47f9ed5d22 Save source viewColumn for previews, fixes #74008 2019-07-04 21:37:28 -04:00
Miguel Solorio 05ee90f7fd Merge remote-tracking branch 'origin/master' into misolori/new-icons 2019-06-28 11:05:33 -07:00
Matt Bierner 8119b4aee7 Move the webviewResourceRoot property to be set on each webview instead of as a global property
For #72155

This allows  us to potentially change the resource root per webview
2019-06-24 17:07:06 -07:00
Miguel Solorio e998949260 Update markdown icons 2019-06-20 11:53:01 -07:00
Matt Bierner 4470b868a3 Check pending version before updating markdown preview content
For #72671
2019-04-29 13:49:36 -07:00
Matt Bierner 312b09cc6b extract setContent 2019-04-12 14:43:14 -07:00
Matt Bierner 74103c4c8d Don't change preview when click fails but do show an alert 2019-04-12 14:43:14 -07:00
Matt Bierner 3b58a011da Only try/catch openTextDocument 2019-04-12 14:43:14 -07:00
Matt Bierner c79f1cd8e3 Styling 2019-04-12 14:43:14 -07:00
pkoushik 3cef5067be fix-71570 Added logic to handle markdown preview update on file rename and delete 2019-04-05 11:38:18 +05:30
Matt Bierner 038e8d3904 Make markdown extension points dynamic
For #67574

Blocked by #67958
2019-02-05 17:45:11 -08:00
Matt Bierner 8f10101dd4 Create base class for disposable objects 2019-02-05 17:45:11 -08:00
Matt Bierner 476d7fe0ab Refactor markdown contributions
Reducing code duplication and reducing state
2019-02-05 16:56:45 -08:00
Matt Bierner f52f29d65e Add typings for markdown preview messages 2018-12-04 15:54:53 -08:00
Matt Bierner a2893ce678 Fix markdown fragments when opening file in workspace
Fixes #64141
2018-12-04 15:42:17 -08:00
Matt Bierner a529621b3d Disable command uris in preview
We are now using the modern, message passing approach to handling actions in the markdown preview. No more need for command uris
2018-10-04 19:01:34 -07:00
Matt Bierner e19c9ba82d Addd option to open markdown preview links in markdown preview
Fixes #19339
2018-09-21 15:08:42 -07:00
Matt Bierner a101ececf4 Remove onCommand from markdown preview 2018-09-21 15:08:41 -07:00
Matt Bierner 7185906189 Reduce usage of postCommand in markdown preview 2018-09-21 15:08:41 -07:00
SteVen Batten f8f4d3af30 improve markdown preview scroll sync (#58852)
* improve markdown preview scroll sync
2018-09-18 15:08:37 -07:00
Matt Bierner 4be0f07230 Add WebviewPanel.iconPath (#54912)
* Add WebviewPanel.iconPath

Allows webviews to provide icons used in UI. Adds a new `WebviewPanel.iconPath` property for this.

Replaces the static contribution approach from #49657

Fixes #48864

* Fix doc

* Move icon into mainthreadwebview

* Cleaning up implementation

* Cleaning up implementation
2018-07-24 15:08:46 -07:00
Matt Bierner 78f410ce39 Make sure we correctly update local resource roots when switching previewed markdown file
Fixes #49859
2018-06-20 15:48:14 -07:00
Matt Bierner 68afee908e Allow updating webview settings after creation
Fixes #51733
2018-06-13 15:20:18 -07:00
Matt Bierner 21ee81c03b Working on webview persistence API
#49022
2018-05-14 10:34:59 -07:00
Matt Bierner 91191fb866 Promote webview Api to stable (#47989)
* Promote webview Api to stable

Fixes #43713
Fixes #28263

* Rename position back to viewColumn and mark viewColumn as deprecated

This allows us to more easily re-introduce a `position` property once we have gridlayout

* Move dispose methods onto webview itself

Also better hide a few 'internal' methods / properties on the panel / webview

* Revert "Move dispose methods onto webview itself"

This reverts commit 8fab6cc1a1.

* Move title onto webview panel

* Use _ names for private setters

* Remove unused emitter and dispose onMessageEmitter

* Preview internal emitters with _
2018-04-19 10:55:49 -07:00
Matt Bierner 3a14fde91d Fix double click md preview when source document is not showing
Fixes #47188
2018-04-16 15:21:24 -07:00