Commit Graph

764 Commits

Author SHA1 Message Date
Johannes Rieken
16ea2f2894 remove "getter" wrapping for proposed API types (classed, enums). These checks needed to be disabled because of an TS issues 2021-03-04 12:32:06 +01:00
Johannes Rieken
f79a0df4db api todos, remove long outdated proposal 2021-03-04 12:26:22 +01:00
Matt Bierner
49d05f998f Add CodeActionTriggerKind api proposal
For #118084
Fixes #118087
2021-03-03 17:36:07 -08:00
Ladislau Szomoru
14fd07d57a Workspace trust api feedback 2021-03-03 12:41:22 +01:00
SteVen Batten
ff225b9fcc add telemetry enablement api (#117944) 2021-03-02 07:59:50 -08:00
Rachel Macfarlane
763bfde29a Remove proposed API check for registerAuthenticationProvider, fixes #117427 2021-02-23 09:52:41 -08:00
Benjamin Pasero
e4364e5f5d fix #117254 2021-02-23 08:27:52 +01:00
Ladislau Szomoru
05ea4c5e4e Removed optional message, and added modal parameter (#117241) 2021-02-22 14:10:01 +00:00
Connor Peet
5a0bf3751a testing: add method to publish extension-provided results 2021-02-18 17:33:24 -08:00
Connor Peet
b09a71dce7 testing: update test results api to spec
Refs https://github.com/microsoft/vscode/issues/107467#issuecomment-780776814
2021-02-17 16:34:01 -08:00
Johannes Rieken
5870204e95 make notebook and cell metadata classes, https://github.com/microsoft/vscode/issues/116333 2021-02-17 14:19:49 +01:00
Alex Ross
7a0caf4d86 Let Remote extensions set port source (#116838) 2021-02-17 10:33:46 +01:00
Matt Bierner
52d1b626f3 Pick up latest TS version for building VS Code 2021-02-16 14:06:58 -08:00
Andre Weinand
e537fd9e31 first cut of proposed "inline values provider" API 2021-02-16 16:31:33 +01:00
Johannes Rieken
18c04a5716 make vscode.NotebookCellRange a class 2021-02-15 16:06:48 +01:00
Johannes Rieken
868fb4c39f rename CellKind to NotebookCellKind 2021-02-12 10:25:12 +01:00
Rachel Macfarlane
eceff53351 Rename login/logout to createSession/removeSession 2021-02-11 16:46:47 -08:00
Johannes Rieken
cf7fc3918f remove CellOutputKind type 2021-02-10 19:14:22 +01:00
Connor Peet
9070508076 Merge branch 'connor4312/refactor-test-states' 2021-02-09 16:15:16 -08:00
Connor Peet
3d4cabb608 testing: refactor to new runState API
Fixes: https://github.com/microsoft/vscode/issues/115101.
See issue for details.

- Adopts the new API
- Test results now persist across reloads (last 64 runs).
- Removed state grouping in favor of sorting option.
- Code lenses are disabled for now
2021-02-09 16:12:37 -08:00
Johannes Rieken
efd5a000c0 add InlineHintKind to InlineHint-type 2021-02-09 15:56:24 +01:00
SteVen Batten
afd102cbd2 Trusted Workspaces Feature Branch Merge (#115961)
* draft trusted workspace service / model

* renaming

* add request model and action

* err fix

* add request handlers with mock actions

* some quick fixes

* adding badge icon to activity bar gear

* Add Statusbar item to indicate trust

* Cleanup code

* Add background color

* Use theme color for the status background color

* adding basic editing experience

* observe trust with startup tasks

* Extension enablement

* Add capability to provide a custom message

* Remove old actions

* explorer: if you can not undo, pass undo to editor

fixes #111630

* Remove plug icon from ports view
Part of https://github.com/microsoft/vscode-internalbacklog/issues/1689

* Fixed compilation error

* Handle extension uninstall

* Handle extension install

* Ability to prompt when state is untrusted

* Do not change state is the modal dialog is dismissed or the Cancel button is pressed

* Refactored enablement code

* Prompt when installing from VSIX

* Prompt when installing from the Gallery

* Move file into the browser folder

* fixes and polish

* restructure workspace contributions

* restructure actions and use confirmations

* Initial draft of the proposed APIs

* Added stubs for the proposed api

* Trusted Workspace proposed API

* Fix a regression introduced by merge

* status bar indicator improvements

* remove helper command as we now have hooks

* verbose messaging for the immediate request

* add indication to global activity icon of pending request

* try personal title

* Add configuration setting

* Add additional extension actions

* Fix contributions

* Removed context key that is not needed

* Fixed issue with the dialog

* Reduce arbitrary event limiter from 16ms down to 4.16666 (support for monitors up-to 240hz) #107016

* Fixes #115221: update emoji tests

* Give a higher priority to language configuration set via API call (#114684)

* debug console menu action polish

* Avoid the CSS general sibling combinator ~ for perf reasons

* more notebook todos

* Use label as tooltip fallback properly
Part of #115337

* Fixes microsoft/monaco-editor#2329: Move `registerThemingParticipant` call to `/editor/`

* Fix port label not always getting set
Part of microsoft/vscode-remote-release#4364

* simplify map creation, fyi @bpasero

* Fix #114432: Multiple save dialogs appearing on Windows if Ctrl+S is pressed multiple times (#114450)

* fix multiple save dialogs appearing on Windows when spamming Ctrl+S

* remove old fix and instead keep track of windows with open dialogs in the dialogMainService

* keep initialisation of activeWindowDialogs in constructor

* remove unused variable

* some changes

* queue dialogs based on hash of options

* simplify structure, fix comment typo

* Apply suggestions from code review

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* remove unnecessary async/await for aquireFileDialogLock method

* don't acquire file dialog lock for message boxes

* use MessageBoxReturnValue | SaveDialogReturnValue | OpenDialogReturnValue instead of any type for getWindowDialogQueue

* Apply suggestions from code review

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* 💄 dialog main service locks

* debt - adopt some ? operator

* Better hiding of custom hover in icon label

* Limit to 8ms (120fps)

* more API todos for notebooks

* 💄

* Update grammars

* chore - group notebook specific api proposals together

* added unreleased fixes to endgame notebook

* Add changes back to the modal dialog

* Add back the workspace trust proposed APIs

* Adjust dialog buttons

* Standardize on WorkspaceTrust name across interfaces, classes, variables

* Renamed some of the missing keys

* Add TestWorkspaceTrust stub and fix failing tests

* Add requiresWorkspaceTrust property to fix test failure

* remove notebook change

Co-authored-by: Ladislau Szomoru <lszomoru@microsoft.com>
Co-authored-by: isidor <inikolic@microsoft.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: TacticalDan <gorksorf@gmail.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
Co-authored-by: Cameron <cameron532@gmail.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2021-02-06 00:38:32 -08:00
Christof Marti
cbc01b9a7b Don't leak RPC objects from API (#115679) 2021-02-05 10:52:02 +01:00
Johannes Rieken
a60beb9d7a don't leak proxies in editor land, also remove indentSize property which isn't API 2021-02-01 12:01:50 +01:00
Johannes Rieken
3114b1c4c5 hide rpc proxies 2021-02-01 12:01:20 +01:00
Johannes Rieken
4cfd5f8508 clipboard changes 2021-02-01 12:01:14 +01:00
Matt Bierner
9ee751e859 Error if registering an unsupported scheme for external opener
Fixes #115168
2021-01-26 17:46:09 -08:00
Connor Peet
bd7dff7f07 testing: add test result to proposed api, ids for correlation 2021-01-25 12:20:28 -08:00
Matt Bierner
542de8e009 Move schemes to opener metadata 2021-01-21 14:41:25 -08:00
Johannes Rieken
e9263cc826 some API proposal for open editors 2021-01-20 12:35:18 +01:00
Matt Bierner
c42b385bce Disable contributed openers by default in calls to openExternal
Fixes #114543

External and internal callers to openExternal may not expect (or want) their urls to be handled by a contributed opener. This change makes it so you have to explicitly enable using contributed openers when calling openExternal.

It also enables using contributed openers for a few places in our codebase
2021-01-19 12:16:34 -08:00
Johannes Rieken
756337d48a Merge branch 'master' into signaure_arguments_label 2021-01-18 16:01:38 +01:00
Wenlu Wang
3c2c937f99 Merge branch 'master' into signaure_arguments_label 2021-01-18 17:38:35 +08:00
Matt Bierner
cc5e8b22fa Continue work on url opener api
For #109277

- Add `option` opener priority. This means the oper will only be shown if requested but will not replace the default opener
- Persist registered openers for IntelliSense suggestions
2021-01-14 17:06:14 -08:00
Matt Bierner
5d6cba5cbc Reworking external opener implementation to allow configured openers to be called directly without a canOpen check
If the user has configured a specific external uri opener, we should always try to use that without first calling `canOpen` to filter down the list of openers.

This change also adds `ExternalUriOpenerEnablement` which allows an opener to mark itself as the preferred opener for a given uri. If only a single preferred opener is returned, it will be used automatically for that uri (although user configuration can override this)
2021-01-14 10:37:00 -08:00
Johannes Rieken
152d0ec8f0 finalize CancellationError API, fixes https://github.com/microsoft/vscode/issues/93686 2021-01-13 11:19:35 +01:00
Matt Bierner
47a135e715 Rework opener api proposal
For #109277

- Add more explicit two phase structure to api
- Make opener pass along label when registered
2021-01-12 16:14:42 -08:00
Rachel Macfarlane
c85297669e Move id, label, and options to authentication provider registration 2021-01-11 10:53:17 -08:00
Wenlu Wang
4331023088 Merge branch 'master' into signaure_arguments_label 2021-01-11 18:15:40 +08:00
Matt Bierner
acda4aed82 Make the external opener a two phase process
This changes makes a few changes to the openers:

- Move the opener prompting from the extension host into the main thread
- Make the external opener process two phases: get openers and then open. This would let us skip the trusted domain validation for extension handled links if we want to in the future
- Add lifecycle to commands used by the uri opener

For #109277
2021-01-07 17:42:12 -08:00
João Moreno
f054767eb4 remove unnecessary line 2021-01-06 14:19:28 +01:00
Rachel Macfarlane
7db413d4c1 Move secrets API to extension context 2021-01-04 22:04:40 -08:00
Rachel Macfarlane
4d8895c7b7 Just kidding, keep proposed onDidChangeAuthenticationProviders API for now 2021-01-04 17:01:25 -08:00
kingwl
f93a2b62ef fix cr issues 2021-01-04 21:15:59 +08:00
kingwl
2db89c75e6 rename to inline hints 2020-12-25 01:15:16 +08:00
kingwl
d24ab0a201 Improve comments and code style 2020-12-24 15:28:27 +08:00
kingwl
3de96fd237 Simplify code 2020-12-23 18:51:15 +08:00
kingwl
9f5cfc246b Add dummy support 2020-12-23 15:07:33 +08:00
Johannes Rieken
ad362089be add proposal of CancellationError, https://github.com/microsoft/vscode/issues/93686 2020-12-16 16:15:32 +01:00
Matt Bierner
6d3c2e6835 Adding proposed external uri opener API
For #109277
2020-12-15 16:26:47 -08:00