Commit Graph

31 Commits

Author SHA1 Message Date
SteVen Batten
9f7309348f workpace 2021-07-01 10:45:28 -07:00
Ladislau Szomoru
480f3c0b35 Return undefined if dialog is cancelled (#122234) 2021-04-26 15:28:25 -07:00
SteVen Batten
a9f70f7919 finalize basic workspace trust api 2021-04-21 09:56:35 -07:00
SteVen Batten
c5fab4faa3 Boolean Trust State (#121141)
* move to boolean-based trust state

* update api based on feedback
2021-04-13 12:54:52 -07:00
Ladislau Szomoru
c41460cba5 Split WorkspaceTrustService (#120974)
* Split WorkspaceTrustService into WorkspaceTrustManagementService, WorkspaceTrustRequestService, WorkspaceTrustStorageService
2021-04-10 07:20:58 +00:00
Ladislau Szomoru
49a164e886 Workspace trust API polish 2021-04-01 15:59:04 +02:00
Ladislau Szomoru
648ea3d1e0 Refactor requireWorkspaceTrust to requestWorkspaceTrust 2021-04-01 15:59:04 +02:00
Ladislau Szomoru
c55aff6379 API feedback (WorkspaceTrustRequest -> WorkspaceTrustRequestOptions) (#119658) 2021-03-24 10:30:31 +01:00
Ladislau Szomoru
14fd07d57a Workspace trust api feedback 2021-03-03 12:41:22 +01:00
Ladislau Szomoru
05ea4c5e4e Removed optional message, and added modal parameter (#117241) 2021-02-22 14:10:01 +00:00
SteVen Batten
afd102cbd2 Trusted Workspaces Feature Branch Merge (#115961)
* draft trusted workspace service / model

* renaming

* add request model and action

* err fix

* add request handlers with mock actions

* some quick fixes

* adding badge icon to activity bar gear

* Add Statusbar item to indicate trust

* Cleanup code

* Add background color

* Use theme color for the status background color

* adding basic editing experience

* observe trust with startup tasks

* Extension enablement

* Add capability to provide a custom message

* Remove old actions

* explorer: if you can not undo, pass undo to editor

fixes #111630

* Remove plug icon from ports view
Part of https://github.com/microsoft/vscode-internalbacklog/issues/1689

* Fixed compilation error

* Handle extension uninstall

* Handle extension install

* Ability to prompt when state is untrusted

* Do not change state is the modal dialog is dismissed or the Cancel button is pressed

* Refactored enablement code

* Prompt when installing from VSIX

* Prompt when installing from the Gallery

* Move file into the browser folder

* fixes and polish

* restructure workspace contributions

* restructure actions and use confirmations

* Initial draft of the proposed APIs

* Added stubs for the proposed api

* Trusted Workspace proposed API

* Fix a regression introduced by merge

* status bar indicator improvements

* remove helper command as we now have hooks

* verbose messaging for the immediate request

* add indication to global activity icon of pending request

* try personal title

* Add configuration setting

* Add additional extension actions

* Fix contributions

* Removed context key that is not needed

* Fixed issue with the dialog

* Reduce arbitrary event limiter from 16ms down to 4.16666 (support for monitors up-to 240hz) #107016

* Fixes #115221: update emoji tests

* Give a higher priority to language configuration set via API call (#114684)

* debug console menu action polish

* Avoid the CSS general sibling combinator ~ for perf reasons

* more notebook todos

* Use label as tooltip fallback properly
Part of #115337

* Fixes microsoft/monaco-editor#2329: Move `registerThemingParticipant` call to `/editor/`

* Fix port label not always getting set
Part of microsoft/vscode-remote-release#4364

* simplify map creation, fyi @bpasero

* Fix #114432: Multiple save dialogs appearing on Windows if Ctrl+S is pressed multiple times (#114450)

* fix multiple save dialogs appearing on Windows when spamming Ctrl+S

* remove old fix and instead keep track of windows with open dialogs in the dialogMainService

* keep initialisation of activeWindowDialogs in constructor

* remove unused variable

* some changes

* queue dialogs based on hash of options

* simplify structure, fix comment typo

* Apply suggestions from code review

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* remove unnecessary async/await for aquireFileDialogLock method

* don't acquire file dialog lock for message boxes

* use MessageBoxReturnValue | SaveDialogReturnValue | OpenDialogReturnValue instead of any type for getWindowDialogQueue

* Apply suggestions from code review

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* 💄 dialog main service locks

* debt - adopt some ? operator

* Better hiding of custom hover in icon label

* Limit to 8ms (120fps)

* more API todos for notebooks

* 💄

* Update grammars

* chore - group notebook specific api proposals together

* added unreleased fixes to endgame notebook

* Add changes back to the modal dialog

* Add back the workspace trust proposed APIs

* Adjust dialog buttons

* Standardize on WorkspaceTrust name across interfaces, classes, variables

* Renamed some of the missing keys

* Add TestWorkspaceTrust stub and fix failing tests

* Add requiresWorkspaceTrust property to fix test failure

* remove notebook change

Co-authored-by: Ladislau Szomoru <lszomoru@microsoft.com>
Co-authored-by: isidor <inikolic@microsoft.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: TacticalDan <gorksorf@gmail.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
Co-authored-by: Cameron <cameron532@gmail.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2021-02-06 00:38:32 -08:00
Rob Lourens
98106c48a0 No need to create fake workspace folder for query builder
Fix #111348
2020-12-31 12:19:09 -08:00
Alex Dima
3c77120d88 Fixes #75284: Run a real search when enabling/installing an extension with workspaceContains 2020-07-06 23:35:08 +02:00
Alex Dima
d432126ecf Extract workspaceContains related logic to a separate file (#75284) 2020-07-06 23:15:52 +02:00
Matej Urbas
d4c2e7d8c5 file search: include workspace folder in filter
"Go to File..." search can now filter files based on the workspace folder name.

This feature is activated only when the workspace contains more than one folder.

This is particularly useful when your workspace contains multiple files with the same name, each of them in another workspace folder.

A common example is the `README.md` file. Say you want to find a `README.md` file from a particular folder, say `my-folder`. Before this change you'd have to press the `Down` button a few times before you could get to the file.

With this change you'd instead search for `mfREADME.md`. The desired readme file should now appear closer to the top of the file search popup.
2020-02-25 09:54:37 +00:00
Rob Lourens
7cc88f5caa Handle RelativePattern in findTextInFiles correctly
Fix #85722
2019-11-27 15:43:28 -08:00
Matt Bierner
d4ab1fcda5 Fixes more node 12 typing errors (#85420)
* Fixes more node 12 typing errors

For #82514

* Remove Symbol.toStringTag usage for now

* Reverting a few fixes that are not comptible with current node typings

* Revert one more use of StringDecoder

Must wait until we actually pick up the new typings
2019-11-25 19:30:21 -08:00
Benjamin Pasero
00688bf051 working copies - properly implement save, saveAs, saveAll (#84672) 2019-11-17 17:44:57 +01:00
Benjamin Pasero
aab2b1bd37 web - do not show untitled workspaces in history 2019-10-23 09:32:11 +02:00
Benjamin Pasero
6ee1da3dc5 debt - shuffle things around 2019-09-27 09:44:35 +02:00
Benjamin Pasero
3334b82562 debt - remove resolveProxy from window service 2019-09-19 18:19:16 +02:00
Benjamin Pasero
753de26cd6 debt - remove some internal commands 2019-09-17 07:44:34 +02:00
Dirk Baeumer
8ac1c0b5ae Support code-workspace files coming from a file system provider 2019-09-16 13:01:46 +02:00
Rob Lourens
65fdc745ae Use null across EH boundary instead of undefined 2019-07-23 15:39:03 -07:00
Sandeep Somavarapu
b3422b98b7 Merge pull request #76377 from microsoft/sandy081/fix74859
trigger workspace contains activation event on new folders
2019-07-12 16:42:56 +02:00
Matt Bierner
ae2cc878f8 Using DisposableStore in mainThread class
#74250
2019-07-02 16:37:35 -07:00
Sandeep Somavarapu
34d245ed44 trigger workspace contains activation event on new folders 2019-06-30 20:10:28 +02:00
Benjamin Pasero
01423e458d debt - move status message into notification status 2019-06-05 11:38:54 +02:00
Benjamin Pasero
c72cfe0c65 Provide API to get access to the workspace configuration file (#37421) (#72490)
* Provide API to get access to the workspace configuration file (#37421)

* fix untitled ID

* update docs
2019-04-17 14:24:10 +02:00
Martin Aeschlimann
1ca3959faf refactor IURIToOpen 2019-04-02 17:32:11 +02:00
Johannes Rieken
c514d9e783 move mainThread[W], #70319 2019-03-19 17:37:07 +01:00