Matt Bierner
52556f9742
Auto converting let -> const where possible in mainthread and extHost
...
Const provides better type guards and can make logic clearer
2019-03-05 16:53:41 -08:00
Benjamin Pasero
622b3d62dd
paths - paths.node.ts => path.ts
2019-02-12 20:36:23 +01:00
SteVen Batten
5ebd625b40
use new path implementation ( #68538 )
...
* adopt paths.node over path
* fix strict null
* remove hacky typing inlabel.test.ts
2019-02-12 20:14:50 +01:00
Benjamin Pasero
7c1fe9a7d6
debt - move search out of platform
2019-02-09 17:02:31 +01:00
Johannes Rieken
02248a4d4e
Merge pull request #65059 from Microsoft/joh/promise-finally
...
Add typings for Promise#finally
2019-01-23 09:14:46 -08:00
Matt Bierner
93ebd40953
Continue Strict null check for Map.get may return undefined
2019-01-09 17:37:42 -08:00
Rob Lourens
7805023eaa
Fix #65933
2019-01-02 21:20:14 -08:00
Johannes Rieken
45e479386b
add typings to support Promise#finally
2018-12-14 09:20:49 +01:00
Matt Bierner
0928a6d348
Prefer coalesce over filter
...
Coalesce has the correct return type of `T[]`. Filter may return `(T | undefined)[]`
2018-12-07 16:32:45 -08:00
Rob Lourens
6f9b2d7593
Fix #59922 - changes needed to support a cache in a FileSearchProvider
2018-12-03 16:19:37 -08:00
Rob Lourens
6ba5f8f9f3
Final search TPromise removal #53526
2018-11-07 11:46:29 -08:00
Johannes Rieken
45f4904378
debt remove TPromise from extHost-files #53526
2018-10-19 09:49:05 +02:00
Rob Lourens
b17e21d0ad
Split text and file search interfaces
2018-10-18 16:49:58 -07:00
Rob Lourens
d47f6b4f99
Fix #61041
2018-10-17 20:22:12 -07:00
Rob Lourens
5c23d38a09
Refactor search - move file search code out of ExtHostSearch
...
Not generic now, maybe in the future
2018-10-15 21:35:10 -07:00
Rob Lourens
c26d6e6c93
Refactor text seach
...
To allow better code sharing between EH and search proc
2018-10-15 16:28:31 -07:00
Rob Lourens
38a2c24ca2
Merge pull request #59717 from skprabhanjan/fix-59364
...
Fix #59364 : Respect global .gitignore when searching
2018-10-04 11:40:23 -07:00
Matt Bierner
8087b0a8d8
Remove use strict directives in main vs code ts files (part 2)
...
We compile using the alwaysStrict flag so these directives are not needed
This part removes most `use strict` directives that are right after the file header
2018-10-02 16:11:05 -07:00
pkoushik
c4928076b7
fix #59364 - Review #2
2018-10-02 19:35:18 +05:30
Rob Lourens
a0f1543c00
Fix fileIndex error handling
2018-09-21 09:56:12 -07:00
Rob Lourens
b7e684c508
Fix TPromise#cancel in FileIndexProvider #56137
2018-09-10 11:21:47 -07:00
Johannes Rieken
2d452e0a7e
uri - replace usages of default export with named export
2018-09-03 10:54:50 +02:00
Rob Lourens
4f162b7b6e
Fix typo in search telemetry
2018-08-27 16:20:08 -07:00
Rob Lourens
dd13d47e02
#56950 - add search telemetry for EH-based search
2018-08-21 19:58:55 -07:00
Rob Lourens
23f5f3e8d6
Remove unneeded PPromise progress callback... #53487
2018-08-06 16:51:45 -07:00
Rob Lourens
49bbb88160
Fix FileSearchProvider unit tests for progress change
2018-08-01 13:39:21 -07:00
Rob Lourens
866bc0aa4c
Fix #55224 - use different cacheKeys per folder in FileIndexProvider
2018-07-27 11:26:04 -07:00
Rob Lourens
0dea26f6e7
Search provider - avoid unnecessary joinPath in some cases
...
Maybe fixes liveshare issue
2018-07-26 21:42:24 -07:00
Rob Lourens
28fd1cc007
Search provider - clean up file index search, remove PPromise
2018-07-26 12:28:15 -07:00
Rob Lourens
d36a3d2395
Search provider - implement FileIndexProvider
2018-07-26 12:28:15 -07:00
