Commit Graph

66 Commits

Author SHA1 Message Date
Matt Bierner
3f68d38c9b Fix strict null error in webview 2019-03-01 21:06:15 -08:00
Matt Bierner
5b98f71146 Fix webview deserialization potential crash 2019-02-13 10:47:56 -08:00
Johannes Rieken
44b7588362 remove getNamedCustomer, connect MainThreadWebview with CodeInsetController 2019-02-13 12:47:46 +01:00
Rob DeLine
066dfef8f7 Add Code Inset Feature 2019-02-13 12:46:25 +01:00
Matt Bierner
614ad268cb Fix another case where typeConverters.ViewColumn.to could be passed undefined 2019-02-11 17:24:26 -08:00
Matt Bierner
b6087b2021 Fixing more strict null errros in extHost and related files 2019-02-05 15:59:38 -08:00
Matt Bierner
d3d16d2b34 Don't return symbolic columns for webview panels
Fixes #56097

When a symbolic column is used while creating a webview panel, instead set the `viewColum` as `undefined` and then resolve it once we know the real (non-symbolic) column
2019-01-11 15:32:15 -08:00
Rob Lourens
ef2547d547 replace void 0 with undefined 2019-01-03 11:20:19 -08:00
Alex Dima
25417553be Adopt case insensitive extension identifiers 2018-12-21 12:41:41 +01:00
Johannes Rieken
653280d133 debt - Thenable -> Promise 2018-12-13 11:31:54 +01:00
Rachel Macfarlane
317fe8088c Log an event on webview panel creation 2018-10-29 14:54:43 -07:00
Johannes Rieken
45f4904378 debt remove TPromise from extHost-files #53526 2018-10-19 09:49:05 +02:00
Matt Bierner
e19c9ba82d Addd option to open markdown preview links in markdown preview
Fixes #19339
2018-09-21 15:08:42 -07:00
Johannes Rieken
2d452e0a7e uri - replace usages of default export with named export 2018-09-03 10:54:50 +02:00
Matt Bierner
b297efad40 Extract interface 2018-07-25 12:52:07 -07:00
Matt Bierner
f8870d79d6 Formatting and extration 2018-07-25 12:52:06 -07:00
Matt Bierner
4be0f07230 Add WebviewPanel.iconPath (#54912)
* Add WebviewPanel.iconPath

Allows webviews to provide icons used in UI. Adds a new `WebviewPanel.iconPath` property for this.

Replaces the static contribution approach from #49657

Fixes #48864

* Fix doc

* Move icon into mainthreadwebview

* Cleaning up implementation

* Cleaning up implementation
2018-07-24 15:08:46 -07:00
Matt Bierner
a85c0b6669 Introduce webview.active
The current `.visible` property actually means active. Rename this value to `.active` and introduce a real `.visible`
2018-06-15 15:51:46 -07:00
Matt Bierner
68afee908e Allow updating webview settings after creation
Fixes #51733
2018-06-13 15:20:18 -07:00
Benjamin Pasero
2bfb2763fd grid - 💄 for viewcolumn conversion 2018-05-22 08:53:28 +02:00
Benjamin Pasero
249da81b04 grid - move EditorPosition to exthost 2018-05-20 14:09:00 +02:00
Matt Bierner
21ee81c03b Working on webview persistence API
#49022
2018-05-14 10:34:59 -07:00
Alex Dima
0252ac49bc Introduce and adopt extensionLocation 2018-05-07 17:28:59 +02:00
Johannes Rieken
c47296282a type converters, use namespace for ViewColumn 2018-05-04 18:49:40 +02:00
Matt Bierner
8578f0241e Add preserveFocus option for webviews
Fixes #14311
2018-04-27 16:40:45 -07:00
Matt Bierner
216151379f Make webview options optional
Fixes #48594
2018-04-27 16:02:48 -07:00
Matt Bierner
d770ce503a Make sure we handle webview position updates when an entire editor group moves 2018-04-19 16:35:17 -07:00
Matt Bierner
91191fb866 Promote webview Api to stable (#47989)
* Promote webview Api to stable

Fixes #43713
Fixes #28263

* Rename position back to viewColumn and mark viewColumn as deprecated

This allows us to more easily re-introduce a `position` property once we have gridlayout

* Move dispose methods onto webview itself

Also better hide a few 'internal' methods / properties on the panel / webview

* Revert "Move dispose methods onto webview itself"

This reverts commit 8fab6cc1a1.

* Move title onto webview panel

* Use _ names for private setters

* Remove unused emitter and dispose onMessageEmitter

* Preview internal emitters with _
2018-04-19 10:55:49 -07:00
Matt Bierner
52a75ecf23 Use correct $name for onDidDisposeWebviewPanel event
Fixes #48127
2018-04-18 11:32:29 -07:00
Matt Bierner
cdd9a731f9 Use standard 'postMessage' name 2018-04-17 16:22:44 -07:00
Matt Bierner
fbd3a08369 Pass Webview into ExtHostWebviewPanel instead of creating it inside the ctor 2018-04-17 16:20:27 -07:00
Matt Bierner
ea680fae1c Update to use more consistent WebviewPanel naming 2018-04-17 10:36:56 -07:00
Matt Bierner
e4c975592b Webview panels start out as visible 2018-04-16 11:50:51 -07:00
Matt Bierner
71c09a6c4c weview -> webview 2018-04-16 11:50:51 -07:00
Matt Bierner
06c070690e Also fire webview dispose event when dispose is called 2018-04-16 11:50:51 -07:00
Matt Bierner
4f880aaf59 Rename webview.viewColumn to the more generic webview.position 2018-04-12 14:25:55 -07:00
Matt Bierner
e16ec3c1ff Tweak WebviewPanelOnDidChangeViewStateEvent to only provide a webview panel
Expose a webview panel's view state as properties. Make WebviewPanelOnDidChangeViewStateEvent only fire an event with the webview who's state changed
2018-04-12 14:22:42 -07:00
Matt Bierner
23113a4443 Using consistent internal name 2018-04-12 14:22:42 -07:00
Matt Bierner
a2346c606d Rename WebviewEditor to WebviewPanel 2018-04-12 12:06:07 -07:00
Matt Bierner
8cb7e80544 Split out Webview from WebviewEditor in proposed API (#47370)
* Split out `Webview` from `WebviewEditor` in API

**Problem**
The current proposed `Webview` interface has a few methods and properties that are very editor specific, such as `.reveal` and `.onDidChangeViewState`. These properies will not make sense if we ever allow webview to be displayed in other locations, such as in widgets

**Proposal**
Split the concepts of a `Webview` and of a `WebveiwEditor`. A webview is the html content itself. A `WebviewEditor` is an editor that displays a `Webview`

This would allow us to easily add other types of `Webview` owning objects in the future without having to document that some methods only apply when a webview is used as an editor vs as a widget
2018-04-11 11:49:02 -07:00
Matt Bierner
52c293a050 Fix webview type name casing 2018-04-06 17:09:41 -07:00
Matt Bierner
d855ec8060 Reduce duplicate state for active webviews 2018-04-06 16:06:44 -07:00
Matt Bierner
75ecc5ef29 Delete now unused webview.state 2018-04-05 23:14:04 -07:00
Matt Bierner
6c139ab333 Move all private properties together 2018-04-05 23:14:04 -07:00
Matt Bierner
c14e30aeb4 Show error when webview restore fails 2018-04-05 19:18:55 -07:00
Matt Bierner
e873a42e27 Fix possible webview exception 2018-04-05 19:02:35 -07:00
Matt Bierner
d0f7d2e8da Fix compile error 2018-04-05 10:23:23 -07:00
Matt Bierner
caee7a5789 Working on progress indicator when loading webview 2018-04-05 10:16:39 -07:00
Matt Bierner
dd21d3520a Add webview restoration api proposal (#46380)
Adds a proposed webiew serialization api that allows webviews to be restored automatically when vscode restarts
2018-04-03 18:25:22 -07:00
Matt Bierner
67d8eebaf4 Rename webview.show to webview.reveal
Make it more clear that this command only reveals an existing webview

Fixes #44580
2018-03-20 16:16:05 -07:00