Commit Graph
87341 Commits
Author SHA1 Message Date
Sandeep Somavarapu 562580cd8a #131893 activate config based recommendations 2021-09-06 11:11:25 +02:00
Benjamin Pasero 9857cd9740 side by side editor - allow to configure and flip layout (#36700) 2021-09-06 11:10:54 +02:00
Johannes Rieken a3fce6207d bad workaround for https://github.com/microsoft/vscode/issues/132430 2021-09-06 09:45:35 +02:00
Johannes Rieken b55a53add4 Merge pull request #131976 from heartacker/toggleSuggestion
add cmd+i (mac), ctrl+i (linux/win) as additional intellisense toggleSuggestionDetails
2021-09-06 08:37:18 +02:00
Johannes Rieken 78cd8ff8fd fix https://github.com/microsoft/vscode/issues/132179 2021-09-06 08:34:32 +02:00
Benjamin Pasero fac852f4ac statusbar - allow to show hover on click
//cc @jrieken
2021-09-06 07:57:14 +02:00
Benjamin Pasero 8ce218ca26 bootstrap - fix loader paths for running out of sources 2021-09-06 07:57:13 +02:00
Benjamin Pasero 05cc11ed98 editors - fix one bad usage of columnToEditorGroup 2021-09-06 07:48:43 +02:00
Tyler Leonhardt 997228d528 verify uri is correct 2021-09-04 08:58:31 -07:00
Tyler Leonhardt 15dfc742a6 ensure event comes from edit 2021-09-03 18:25:25 -07:00
Tyler Leonhardt e415d6ff35 revert test to unblock build 2021-09-03 17:59:05 -07:00
Tyler Leonhardt 3ccb217338 add additional logging 2021-09-03 16:18:03 -07:00
Tyler Leonhardt 319a72459f fix windows CI failure 2021-09-03 16:06:37 -07:00
Tyler Leonhardt 4735c328d7 add confidence correction for language detection 2021-09-03 14:49:53 -07:00
David Anthoff 426d60625c Add language_info to setKernelSpec 2021-09-03 14:17:27 -07:00
Matt Bierner 87260247dc Remove use of createTextEditor directly
For #126960

I believe we should always have a resource for these
2021-09-03 13:27:56 -07:00
Matt Bierner a19d95f961 Avoid extra cast
DiffEditorInput now takes an IEditorInput
2021-09-03 13:27:56 -07:00
Matt Bierner a9bac5adb6 Remove defaultCustomEditor types
For #126960

This type no longer seems to be used now that we've generalized editor selection
2021-09-03 13:27:56 -07:00
deepak1556 fdea088e0a Revert "temp fix for #132238"
This reverts commit 4e37c907d2.
2021-09-04 05:26:50 +09:00
deepak1556 cbf2c4a5f6 Revert "chore: bump electron@13.2.3"
This reverts commit 70f3c712be.

Refs https://github.com/microsoft/vscode/issues/132238
2021-09-04 05:26:50 +09:00
David Anthoff 4f7a2ddf75 Add setKernelSpecAndLanguageInfo to ipynb ext 2021-09-03 13:17:09 -07:00
SteVen Batten 9901910447 use gte or lt only 2021-09-03 13:07:42 -07:00
SteVen Batten 8fb7bbabf1 fixes telemetry levels 2021-09-03 13:05:14 -07:00
Logan Ramos 9408062d1a Add active tab test 2021-09-03 15:46:07 -04:00
Matt Bierner 8b7264a91d Add MarkdownString.supportsHtml (#132182)
Fixes #40607

This change introduces a new `supportsHtml` property on `MarkdownString` that can be used to enable rendering of a safe subset of tags and attributes inside of markdown strings

For backwards compatibility, `supportsHtml` will default to false and must be explicitly enabled by extensions

This PR will need to go in after we adopt dompurify (#131950) which should provide better control over how we actually go about sanitizing rendered html
2021-09-03 12:33:00 -07:00
Matt Bierner 474d4951d8 Switch to dompurify for sanitizing markdown content (#131950)
* Switch to dompurify for sanitizing markdown content

Switches us from using `insane` to instead use `dompurify`, which seems to be better maintained and also has some nice features, such as built-in trusted types support

I've tried to port over our existing sanitizer settings as best as possible, but there's not always a 1:1 mapping between how insane works and how dompurify does. I'd like to get this change in early in the iteration to catch potential regressions

* Remove logging and renaming param

* Move dompurify to browser layer

* Fixing tests and how we check valid attributes

* Allow innerhtml in specific files

* Use isEqualNode instead of checking innerHTML directly

innerHTML can return different results on different browsers. Use `isEqualNode` instead

* Reapply fix for trusted types

* Enable ALLOW_UNKNOWN_PROTOCOLS

I beleive this is required since we allow links to commands and loading images over remote

* in -> of

* Fix check of protocol

* Enable two more safe tags
2021-09-03 12:17:02 -07:00
Logan Ramos 82a3d2645f Skip tabs test 2021-09-03 14:56:52 -04:00
rebornix 94f8309414 separate internal notebook editor api 2021-09-03 11:39:37 -07:00
rebornix 96be44fe33 Common notebook editor delegate 2021-09-03 11:39:37 -07:00
Tyler Leonhardt 155460920b only run language detection of extension-less files if it has plaintext mode (ref #132173) 2021-09-03 11:33:16 -07:00
Logan Ramos 5d7f4d3461 Add todo and remove test.only 2021-09-03 14:29:28 -04:00
SteVen Batten 4e37c907d2 temp fix for #132238 2021-09-03 10:55:49 -07:00
Logan Ramos 22ca6611bd Add get tabs tests 2021-09-03 13:47:01 -04:00
rebornix 330ef435e2 remove side by side editor input. 2021-09-03 10:05:27 -07:00
Benjamin Pasero f8eb737b82 loader - configure path to be node_modules.asar (#130302) 2021-09-03 18:44:49 +02:00
Logan Ramos fc1a1e8f13 Up distro 2021-09-03 09:26:16 -04:00
Johannes Rieken 70e30bc64e disable flaky/failing smoketest, https://github.com/microsoft/vscode/issues/132233 2021-09-03 11:38:14 +02:00
Benjamin Pasero bf0a66f7f2 🆙 distro 2021-09-03 11:33:50 +02:00
Benjamin Pasero 3a4e16cac1 tests - skip release notes 2021-09-03 11:32:11 +02:00
heartacker 0adbf29ccb build 2021-09-03 17:27:42 +08:00
Benjamin Pasero 66f523d9b0 web - iOS tweaks for playground 2021-09-03 11:19:19 +02:00
Johannes Rieken 796afd5237 fix https://github.com/microsoft/vscode/issues/132113 2021-09-03 10:50:45 +02:00
Johannes Rieken d1353440df use latest version of references view,https://github.com/microsoft/vscode/issues/15533 2021-09-03 10:45:11 +02:00
Benjamin Pasero f6de4ed250 web - fix welcome banner icon 2021-09-03 09:58:07 +02:00
Benjamin Pasero a3acef919f smoke - ignore any failure from capturing screenshot 2021-09-03 09:31:01 +02:00
Benjamin Pasero 3084de82e9 editors - deprecate typed openEditor and add IEditorGroupService.sideGroup (#127747) 2021-09-03 09:05:19 +02:00
Benjamin Pasero 6b9d5150dc editors - reduce deprecated method usages (#127747) 2021-09-03 08:14:14 +02:00
Benjamin Pasero 2d50df638c editors - less use of EditorInput, more use of IEditorInput 2021-09-03 07:52:55 +02:00
Benjamin Pasero aeb2840610 editors - tweak side by side matches method when editors are the same 2021-09-03 07:36:09 +02:00
Benjamin Pasero c54650cb45 editors - implement new text editor service and adopt (#126960) 2021-09-03 07:17:17 +02:00