Johannes Rieken
4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391
2022-02-02 14:35:33 +01:00
Logan Ramos
c047af40b2
Fix compilation
2022-01-19 16:18:14 -05:00
Tyler Leonhardt
e8a26d3ebf
ensure we treat scopes sorted and we only return a single session since GH only supports a single log in
2021-12-20 17:12:53 -05:00
Tyler James Leonhardt
f67a8b753f
Use device flow over PAT when we are running in a server full environment but not in a supported uri ( #139255 )
...
* initial attempt
* use github-authentication instead
* rework error handling
* update copy
* explain why Workspace
2021-12-15 22:07:49 -05:00
Tyler Leonhardt
4d496f61bc
remove keytar fallback in keychain and add a ton more logging to microsoft auth. ref #133201
2021-10-25 11:16:37 -07:00
Tyler Leonhardt
ab184912e6
make sure we splice the sessions if they have the same set of scopes for github authentication
2021-09-23 16:46:31 -07:00
Tyler Leonhardt
520fa49e68
refactor github auth to be a bit simpler. Remove PAT for GitHub auth since Settings Sync doesn't allow for it and add timeout so that GitHub Auth is not stuck.
2021-08-16 16:34:21 -07:00
Tyler Leonhardt
a8332b75e4
delete extra afterTokenLoad
2021-08-03 16:24:28 -07:00
Tyler Leonhardt
37a8fe959c
no longer call /user to verify tokens
2021-08-03 14:50:07 -07:00
Tyler Leonhardt
c7e45c4fa4
Add a bunch of logging to github-authentication
...
Co-authored-by: Eric Amodio <eamodio@users.noreply.github.com >
2021-07-23 15:28:06 -07:00
Tyler Leonhardt
c1b4cf00b9
update auth extensions to use packageJSON property instead
2021-07-23 11:48:39 -07:00
Tyler Leonhardt
a8134002cd
lazily load experimentation service in github-authentication
2021-07-23 09:07:41 -07:00
Tyler Leonhardt
54a2e15f6b
remove unused variable
2021-07-22 17:40:13 -07:00
Tyler Leonhardt
3ed425bef9
Rework github authentication extension to make less HTTP requests.
...
Co-authored-by: Eric Amodio <eamodio@users.noreply.github.com >
2021-07-22 17:25:59 -07:00
VocalTrance
715798221b
Fix typo in github-authentication/github.ts ( #129100 )
2021-07-21 06:30:45 -07:00
Tyler James Leonhardt
87d692b7bf
Add scopes property to login telemetry ( #128261 )
...
* Add scopes property to login telemetry
2021-07-08 21:48:44 -07:00
Tyler Leonhardt
1d1b9961d7
sort scopes on filter for getSessions in the github auth provider. Fixes https://github.com/github/codespaces/issues/3109
2021-06-30 10:15:24 -07:00
Tyler Leonhardt
4a011b5297
add additional logging around github auth
2021-06-28 16:27:52 -07:00
Oleg Demchenko
61f34055fa
Auth session API fix ( #125792 )
...
* Adjust "provider is not registered" exception behavior
* Process cancellation in GH auth provider
`e.message` is always `undefined`
2021-06-10 20:14:08 +00:00
Matvii Hodovaniuk
67561036cf
Replace map with forEach ( #115378 )
...
The callback provided to the map call on this array should return a value, otherwise map will always return an array of undefined values. If the desired behaviour is to just iterate through all elements, then consider using forEach or a for-of loop instead.
2021-06-07 11:01:10 -07:00
Tyler Leonhardt
e0c8a76b7a
don't sort scope list. Fixes Microsoft/vscode-pull-request-github#2751
2021-05-27 16:45:59 -07:00
Kevin Abel
4978a1891e
Implement GitHub Enterprise authn provider ( #115940 )
2021-05-07 14:13:11 -07:00
Rachel Macfarlane
94589129a2
Add experimentation service to github auth extension
2021-04-20 09:25:01 -07:00
Rachel Macfarlane
2f277cb41e
Add github session telemetry event
2021-02-12 15:39:04 -08:00
Rachel Macfarlane
14669c2e45
Make scopes parameter optional to getSessions and remove getAllSessions
2021-02-12 09:13:11 -08:00
Rachel Macfarlane
eceff53351
Rename login/logout to createSession/removeSession
2021-02-11 16:46:47 -08:00
Rachel Macfarlane
650906c369
Pass scopes through to authentication providers
2021-02-11 14:15:36 -08:00
Rachel Macfarlane
9118a3461c
Make onDidChangeSessions event for auth providers fire complete session
2021-02-11 10:14:28 -08:00
Rachel Macfarlane
ced3bb4bb9
Secrets API feedback
2021-01-05 10:17:05 -08:00
Rachel Macfarlane
998e5e2ea6
onDidChangePassword -> onDidChange in secrets API
2021-01-04 22:20:07 -08:00
Rachel Macfarlane
7db413d4c1
Move secrets API to extension context
2021-01-04 22:04:40 -08:00
Rachel Macfarlane
03c38e6702
Add more logging to github auth provider
2020-11-06 15:10:09 -08:00
Rachel Macfarlane
928e79f838
Verify GitHub tokens on auth provider start, fixes #108680
2020-10-26 16:01:58 -07:00
Rachel Macfarlane
31419adc34
Polish onDidChangePassword changes
2020-10-12 10:31:16 -07:00
Rachel Macfarlane
4c0811c9c2
Removing polling from auth extensions, fixes #107480
2020-10-09 16:33:53 -07:00
Rachel Macfarlane
dafce599a6
Add getPassword, setPassword, and deletePassword APIs, #95475
...
Co-authored-by: SteVen Batten <sbatten@microsoft.com >
2020-10-06 14:57:16 -07:00
Rachel Macfarlane
12f63d9c66
Stabilize authentication consumer side, fixes #100993
2020-07-28 09:58:16 -07:00
Rachel Macfarlane
a155fcf762
Address feedback on auth provider API
2020-07-16 16:03:17 -07:00
Rachel Macfarlane
348e2b4c6e
displayName -> label, use providerIds in favor of getProviderIds, #100993
2020-07-06 18:23:12 -07:00
Rachel Macfarlane
629e1d7e16
Remove old getSessions and login methods from auth provider API
2020-06-24 15:33:09 -07:00
Eric Amodio
774c4baa8f
Adapts extension to work on the web/serverless
2020-06-08 18:13:26 -04:00
Rachel Macfarlane
a79822ac0a
Remove old auth provider migration code
2020-05-28 12:55:52 -07:00
Rachel Macfarlane
a6c47beb1b
Remove unused code in github auth provider
2020-05-27 09:37:54 -07:00
Rachel Macfarlane
87b0c54586
Make AuthenticationSession a class and remove getAccessToken method, fixes #91554
2020-05-15 14:34:04 -07:00
Rachel Macfarlane
b05b32bfd8
Use github auth server for provider
2020-04-27 08:10:46 -07:00
Rachel Macfarlane
badd41f04a
Better error handling in github auth provider
2020-04-23 12:16:33 -07:00
Rachel Macfarlane
2e5312cd61
Add account id to authentication session object
2020-04-22 18:00:16 -07:00
Rachel Macfarlane
fd88fb9667
Await keychain write on logout for github auth
2020-04-21 11:16:45 -07:00
Rachel Macfarlane
917c420302
Improvements to 'manage trusted extensions' flow
2020-04-01 23:13:50 -07:00
Rachel Macfarlane
852df3025d
Revert "Issue distinct sessions per extension, remove session when extension is removed from trusted list"
...
This reverts commit 85119afc7b .
2020-03-30 17:03:29 -07:00