Commit Graph

1738 Commits

Author SHA1 Message Date
Peng Lyu
777075998b fix failure for api change 2018-05-18 17:03:12 -07:00
Peng Lyu
9acfd66aa0 Merge remote-tracking branch 'upstream/master' into rebornix/review 2018-05-18 10:16:19 -07:00
Rob Lourens
912fff91ac Change File search result API to only return a string relative path to the search folder 2018-05-17 21:51:10 -07:00
Rob Lourens
707a20f4af Change TextSearchResult API to only return a string relative path to the search folder 2018-05-17 21:25:47 -07:00
Matt Bierner
8bb27cd255 Add unused diagnostic subtype (#49646)
* Add unused diagnostic subtype

Fixes #15710

Adds a new `DiagnosticTag` class that provide additional information about a diagnostic. Introduce `DiagnosticTag.Unnecessary` to mark when a diagnostic is for unused / unnecessary code

The design comes from Rosyln's diagnostic object and allows us to modify how a diagnostic is rendered without changing its serverity.

Hooks up JS and TS to use this new tag. This is controlled by the `javascript.showUnused.enabled` setting which is enabled by default

- Introduce a new diagnostic severity for unused.

    However, using this approach, if a user sets `noUnusedLocals` in their `tsconfig.json`, the resulting diagnostic could only show the squiggly OR be grayed out. Using `customTags` allows us to support both graying out and showing the squiggly

- Custom JS/TS implementation using decorators

    Not themable. We want a standard experience across languages.

* - Move to proposed
- Use numeric enum
2018-05-17 15:43:59 -07:00
Rob Lourens
a9d3a477dd EH search - remove slow ES5 async/await from inner loop 2018-05-17 11:56:05 -07:00
Rob Lourens
9b4656e6bc EH search - send limitHit result back to frontend 2018-05-17 11:56:05 -07:00
Rob Lourens
cf06508603 EH search - implement max results for text search on the ExtHostSearch side 2018-05-17 11:56:05 -07:00
Sandeep Somavarapu
fbf1fefaae Merge pull request #49970 from Microsoft/sandy081/treeViewApi
Add following to TreeView
2018-05-17 16:48:45 +02:00
Sandeep Somavarapu
58064599c5 Call selected elements - selection 2018-05-17 16:48:09 +02:00
Sandeep Somavarapu
7ed2a1d3d7 #47262 Fix tests 2018-05-17 15:50:15 +02:00
Sandeep Somavarapu
aa54908ca2 FIx #47262 2018-05-17 12:58:33 +02:00
Johannes Rieken
cc83c18dd9 fix #49582 2018-05-17 12:00:30 +02:00
Johannes Rieken
49323b3798 explore Hierarchy<T> idea, #34968 2018-05-17 10:40:08 +02:00
Rob Lourens
0fb960478e EH search - add fileSearch telemetry 2018-05-16 21:59:42 -07:00
Peng Lyu
41f1722166 use explict api instead of commands for commenting. 2018-05-16 19:14:24 -07:00
Rob Lourens
3de1e91694 EH search - respect sibling clauses in text search 2018-05-16 17:07:13 -07:00
Rob Lourens
e3d54a7101 EH search - simplify code that handles excludes across multiple folders in a workspace 2018-05-16 11:10:35 -07:00
Rob Lourens
9be64e3602 EH search - fix max results in file search, add tests 2018-05-16 11:10:35 -07:00
Sandeep Somavarapu
664d97c950 Add following to TreeView
- Events to listen to when an element is expanded/collapsed
- Property to access selected elements
2018-05-16 12:56:53 +02:00
Dirk Baeumer
37319680b3 Incooperated API review for tasks 2018-05-16 10:21:25 +02:00
Rob Lourens
81c11b822c EH search - file search sibling clauses and test 2018-05-15 18:05:16 -07:00
Rob Lourens
32783ae284 EH search - factor out pfs so it can be mocked for testing 2018-05-15 18:05:15 -07:00
Johannes Rieken
abf25ad143 Merge branch 'master' into joh/outline 2018-05-15 18:12:33 +02:00
Johannes Rieken
e538ec0945 synthesize a hierarchy based on range containment 2018-05-15 18:12:00 +02:00
Sandeep Somavarapu
0b77964b6a #49511 Access selected elements 2018-05-15 16:54:16 +02:00
Sandeep Somavarapu
43ac4e244f #30535 expand and collapse events 2018-05-15 16:54:16 +02:00
Johannes Rieken
be6d1d7de9 fix dto/revive issue 2018-05-15 09:59:17 +02:00
Rob Lourens
0d376d890c Fix NPE when search returns no results 2018-05-14 17:02:35 -07:00
Dirk Baeumer
0505ae0749 Add events to listen on process start / end for task executions. 2018-05-14 21:56:04 +02:00
Matt Bierner
21ee81c03b Working on webview persistence API
#49022
2018-05-14 10:34:59 -07:00
Johannes Rieken
2a270de217 add extensionId to DocumentSymbolProvider interface 2018-05-14 14:27:26 +02:00
Christof Marti
e142962e1b Multi-step input API (#49340) 2018-05-14 12:53:38 +02:00
Alex Dima
5348062d3d Small tweaks 2018-05-14 11:04:35 +02:00
Johannes Rieken
183154feba Merge branch 'master' into joh/outline 2018-05-14 09:18:57 +02:00
Rob Lourens
ae223635fe Merge pull request #49736 from Microsoft/roblou/ehSearch
Search implemented in extensionHost
2018-05-11 23:31:33 -07:00
Rob Lourens
93dc156ad3 EH search - fix file paths on windows 2018-05-11 22:31:25 -07:00
Rob Lourens
3bc1b42ad7 EH search - File search tests and fixes 2018-05-11 20:05:19 -07:00
Rob Lourens
03b76b2e8e EH Search - add extHostSearch.test.ts 2018-05-11 18:09:36 -07:00
Rob Lourens
3f2fc7343c EH search - promisify File Search 2018-05-11 15:51:27 -07:00
Rob Lourens
288268ec8b EH search - clean up types used for file search 2018-05-11 14:34:58 -07:00
Rob Lourens
0825cd49ca EH Search - File search working with cache, sorting, filtering, all in EH 2018-05-11 11:36:01 -07:00
Alex Dima
30cf40c452 Remove extensionFolderPath 2018-05-11 13:48:16 +02:00
Alex Dima
f993947a88 Reduce usage of extensionFolderPath 2018-05-11 13:48:16 +02:00
Matt Bierner
49170e54b1 API allowing CodeActionProviders to reliably get the current editor selection (#49081)
Fixes #49024
Fixes #49060

See #49024 for details on the problem. Makes code action providers take a range | selection. Always pass the selection if one is available.
2018-05-10 15:09:26 -07:00
Matt Bierner
5b6d54a4b2 use _ to mark some unused params 2018-05-10 10:53:15 -07:00
Rob Lourens
a84db4acde EH search - quickopen basically working (without filtering, batched results, etc) 2018-05-09 17:09:05 -07:00
Rob Lourens
57e95597d1 EH search - extension API updates 2018-05-09 14:18:17 -07:00
Rob Lourens
2d08462e17 #47058 - Search provider running in EH with switch to enable 2018-05-09 12:56:57 -07:00
Christof Marti
a348936683 Better compile (#49340) 2018-05-09 12:17:14 +02:00