Johannes Rieken
2cd36100c4
Revert "Update more places where we are using an IDispoable[]"
...
This reverts commit 869e5921d8 .
2019-06-06 15:31:23 +02:00
Benjamin Pasero
12fb60ec2e
status - make id/name a static thing that cannot change
2019-06-06 10:27:07 +02:00
Benjamin Pasero
8a97df9520
status - change to id/name instead of category
2019-06-06 10:12:27 +02:00
Benjamin Pasero
943b78238b
paper cut - offer a menu to control visibility of status bar entries
2019-06-06 07:36:06 +02:00
Peng Lyu
cae0668a0e
reactions handler
2019-06-05 21:08:41 -07:00
Matt Bierner
a1c5ded681
Remove n-arg version of dispose
...
This overload was not heavily used and added complexity
2019-06-05 15:41:46 -07:00
Matt Bierner
6b7b5c0e0c
Extend lifecycle/Disposable in more places instead of re-implementing it
...
`lifecycle/Disposable` includes some important fixes that can help catch common programming mistakes
2019-06-05 15:41:46 -07:00
Matt Bierner
88e7b22359
Use clearer name
2019-06-05 15:41:46 -07:00
Matt Bierner
2c8de04126
Fix merge error related to disposables
2019-06-05 15:41:45 -07:00
Matt Bierner
869e5921d8
Update more places where we are using an IDispoable[]
...
Either extend `Disposable` or use a readonly `DispoableStore`
2019-06-05 15:41:45 -07:00
Christof Marti
3460fb97b0
Avoid __nodeRequire() ( #74398 )
2019-06-05 12:50:43 +02:00
Benjamin Pasero
01423e458d
debt - move status message into notification status
2019-06-05 11:38:54 +02:00
Johannes Rieken
35643d80e0
add lifecycle to code lens, #74846
2019-06-05 08:52:31 +02:00
Rachel Macfarlane
83ef31e6a2
Correctly set extensionId on comment threads
2019-06-04 11:50:47 -07:00
Johannes Rieken
6f1da34c2e
debt - decouple webviews from code insets, move things to /browser/-layer, change inset api proposal to push style, re #66418
2019-06-04 12:31:18 +02:00
Peng Lyu
039b3e0a1a
Merge pull request #74688 from microsoft/rebornix/fix#74641
...
Fix #74641 . Update viewzone afterline when position changes.
2019-06-03 13:45:04 -07:00
Rachel Macfarlane
0284236851
Fix #74668 , old comment API not adding comments
2019-05-31 12:00:24 -07:00
Peng Lyu
c042dabe2b
Fix #74641 . Update viewzone afterline when position changes.
2019-05-31 10:27:56 -07:00
Matt Bierner
483e48d875
Fix sorting of source code actions being reversed
...
Fixes #73344
2019-05-30 11:30:45 -07:00
Alex Dima
022835ea42
Connect to the remote extension host
2019-05-24 18:33:29 +02:00
Daniel Imms
93f93d0961
Merge remote-tracking branch 'origin/master' into tyriar/72518_runInBackground
2019-05-24 06:16:37 -07:00
Benjamin Pasero
1ce1371dc3
debt - distinguish progress services
2019-05-24 15:03:55 +02:00
Matt Bierner
0f32f0ef5f
Clean up some usages of IDisposable[]
...
Part of #74250
- Extend `Disposable` in classes where it makes sense
- Use `DisposableStore` for lists of disposables
- Make `combinedDisposable` take arguments instead of an array (so that you can't pass in an array and then modify the array after the fact)
2019-05-23 22:58:16 -07:00
Peng Lyu
346da6b01a
dispose empty comment thread when collapse.
2019-05-23 16:37:42 -07:00
Daniel Imms
9b3544000e
Merge remote-tracking branch 'origin/master' into tyriar/72518_runInBackground
2019-05-23 12:08:42 -07:00
Peng Lyu
7b078e1165
Merge pull request #74089 from microsoft/rr/comments
...
Comment API
2019-05-23 09:42:56 -07:00
Daniel Imms
f68625b600
Support running terminals in background
...
Part of #72518
2019-05-22 17:22:50 -07:00
Peng Lyu
e26568b586
Add contextValue support
2019-05-21 16:59:34 -07:00
Andre Weinand
9af6cea057
remove support for running DA in renderer
2019-05-21 18:46:03 +02:00
Rachel Macfarlane
925426e8b0
Remove activeCommentThread from extHost comments, set context keys on simple comment editor
2019-05-17 16:52:36 -07:00
Peng Lyu
4186bc0a44
menu items
2019-05-17 11:49:00 -07:00
Benjamin Pasero
4a146406f9
Merge branch 'ben/hot-exit' into ben/preserve-mode
2019-05-12 05:51:46 -07:00
Matt Bierner
4875cc00d5
Use correct sorting for code action on save
...
Fixes #73344
2019-05-10 15:43:38 -07:00
Matt Bierner
af722a281a
Use finally
2019-05-10 15:43:38 -07:00
Johannes Rieken
34a7c300f7
allow empty string to be inserted...
2019-05-08 17:07:34 +02:00
Benjamin Pasero
dac56c1816
allow to provide a language mode when opening text editors
2019-05-07 15:05:54 +02:00
Peng Lyu
072e9a35ee
Comments API Finalization ( #73010 )
...
* Comments API Finalization
2019-04-30 14:59:59 -07:00
Peng Lyu
253809c186
Legacy api should still work.
2019-04-28 16:35:01 -07:00
Peng Lyu
67fc5ba4e1
Empty Comment Thread Factory works
2019-04-28 14:23:12 -07:00
Peng Lyu
2884d2239b
Add active comment thread.
2019-04-28 12:30:29 -07:00
Benjamin Pasero
0157b3c155
fix #72558
2019-04-18 16:26:14 +02:00
Peng Lyu
004894a5b5
Dispose comment thread properly
2019-04-17 11:27:19 -07:00
Benjamin Pasero
c72cfe0c65
Provide API to get access to the workspace configuration file ( #37421 ) ( #72490 )
...
* Provide API to get access to the workspace configuration file (#37421 )
* fix untitled ID
* update docs
2019-04-17 14:24:10 +02:00
Johannes Rieken
2335966361
use encodeURI on non-encoded uri when 'leaving' vscode, https://github.com/Microsoft/vscode/issues/25852
2019-04-17 14:11:53 +02:00
Daniel Imms
84f3cfab2b
Fix terminal workspace shell/args
2019-04-16 11:25:38 -07:00
Matt Bierner
80a2614355
Only try tunneling openExternal when we actually need to
2019-04-15 15:28:03 -07:00
Daniel Imms
e4b5bccf93
Improve terminal launch
2019-04-15 11:34:55 -07:00
Johannes Rieken
261fa9f939
fix #71992
2019-04-12 09:59:30 +02:00
Johannes Rieken
ba4735d7cb
debt - don't use Buffer in extHost-protocol
2019-04-10 15:42:45 +02:00
Matt Bierner
07f2fecd98
More webview ports
2019-04-10 11:47:11 +02:00