Commit Graph
73433 Commits
Author SHA1 Message Date
Rob Lourens 1893b55c25 Skip smoketest #105330 2020-09-16 17:06:40 -05:00
Rob Lourens 6527a51220 Revert "Merge branch 'roblou/revertSettingsEditorChanges'"
This reverts commit 3c448ca5b3, reversing
changes made to 8ce1c41cb9.
2020-09-16 17:06:40 -05:00
Matt Bierner 6b083b455b Finalize the WebviewView Api
Fixes #46585

This new api allows extensions to contribute webviews to the sidebar or panel
2020-09-16 14:59:13 -07:00
Martin Aeschlimann a8581d60f2 fix wsl selfhosting in scripts/code.sh 2020-09-16 23:55:52 +02:00
rebornix 289bce5e1a nb decoration api first cut. 2020-09-16 14:27:04 -07:00
Matt Bierner 50cc1d0e97 Update to use TS 4.1 for building VS Code 2020-09-16 11:58:01 -07:00
Matt Bierner d1b49cd8b9 Adding more explicit typings for TS 4.1 new Promise logic 2020-09-16 11:58:01 -07:00
Matt Bierner 240afbde58 Use array.equals 2020-09-16 11:58:01 -07:00
Eric Amodio 7bf5773eb2 Changes to use fsPath 2020-09-16 13:07:54 -04:00
Eric Amodio d8baf61913 Adds resourcePath & resourceFolder context keys
Allows for more powerful use of the new in operator
2020-09-16 13:07:54 -04:00
Jonathan Belcher 822ca5f07b don't declare a variable that isn't used
textInput is no longer used. This removes the declaration as it is not used or needed.
2020-09-16 13:00:36 -04:00
Alan Ren 844321a7f2 normalize eol for build folder 2020-09-16 12:58:46 -04:00
Eric Amodio 989f251ff1 Fixes #106829 2020-09-16 12:52:22 -04:00
Rob Lourens a9a9512290 Remove unused import 2020-09-16 11:45:34 -05:00
Jonathan Belcher 2f1c0213d3 Fix composition logic for Firefox
Fixes: https://github.com/microsoft/vscode/issues/106392

In Firefox when inserting Emoji's using the macOS emoji input or using the compositor for characters with accents è, ë, î, etc. the character is inserted twice. Additionally, when adding an accented character the base character was also inserted.

Examples:

🏅 inserts 🏅🏅
è inserts eèè

This change does two things:

- It removes `this._onType.fire(typeInput);` from the compositionupdate event listener. If you are in the middle of a composition there is no need to fire off the event. This change fixes the unaccented character from being inserted. `è` no longer inserts `eè`.

- In the composition end function `browser.isFirefox` is added to the conditional that resets this._textAreaState to the value of the text area. This is needed as the insert of the composition is handled by L294. The textarea needs to be updated correctly when the compositions ends.

Tested in Firefox (Windows 10, Ubuntu, macOS), Safari (macOS), Chrome (macOS), Edge Legacy (Windows 10), Edge (Windows 10)
2020-09-16 12:36:58 -04:00
Daniel Imms 44965ebf05 Show terminal hover on top 2020-09-16 09:10:50 -07:00
Daniel Imms f17d014457 Support IHoverOptions.anchorPosition
Fixes #106871
2020-09-16 09:09:52 -07:00
isidor d80f324ecb action bar: introduce respectOrientationForPreviousAndNextKey and by default respect both up/down and left/right for prev and next navigation
fixes #106439
2020-09-16 17:50:26 +02:00
Benjamin Pasero 90a9985d51 Remove some deprecated code in ./src/vs/base #103454 2020-09-16 17:13:50 +02:00
Benjamin Pasero ef169aecd7 Remove some deprecated code in ./src/vs/base #103454 2020-09-16 17:01:16 +02:00
Benjamin Pasero 18a6a88ee3 debt - remove some deprecated CSS method usages (#103454) 2020-09-16 16:46:33 +02:00
isidor 909760587f do not use strings.pad
#103454
2020-09-16 16:44:54 +02:00
Alex Dima fc8805df08 Adopt new APIs (for #103454) 2020-09-16 16:28:31 +02:00
isidor 953d32c4e2 debug: use asCannonicalUri when opening editors
#106382
2020-09-16 16:03:17 +02:00
isidor fe660760bb fileActions: polish how strings. methods are used 2020-09-16 16:03:17 +02:00
Martin Aeschlimann 78bad9989e Merge pull request #106813 from joshbolduc/jenkinsfile-groovy
Detect Jenkinsfile as groovy
2020-09-16 06:42:29 -07:00
Alex Dima b3ebf8bd5b Fix unit test 2020-09-16 15:31:20 +02:00
Alex Ross 032e9a33ba Update go grammar and fix update script
Fixes #106798
2020-09-16 15:24:28 +02:00
Alex Ross 2a77a2f7a5 Don't update title area for filterview (#106775)
Fixes microsoft/vscode-remote-release#3676
2020-09-16 15:23:04 +02:00
Benjamin Pasero fcb916f02c debt - remove array.first (#103454) 2020-09-16 14:20:25 +02:00
Martin Aeschlimann 02cf31cda7 Duplicated file extension in save dialog. Fixes #106858 2020-09-16 14:11:51 +02:00
Johannes Rieken f8ad845310 Allow executeCodeActionProvider API command to set the number of items to resolve, unit test to check that and the whole resolve machinery 2020-09-16 13:52:26 +02:00
Dirk Baeumer 21d010d6c7 Exclude LSIF files from Git 2020-09-16 13:50:44 +02:00
Dirk Baeumer 2787b25873 Update distro commit id 2020-09-16 13:50:30 +02:00
Benjamin Pasero 76156dd0e4 web - 🆙 version 2020-09-16 13:43:36 +02:00
Benjamin Pasero 955abaef00 🆙 distro 2020-09-16 13:41:59 +02:00
Sandeep Somavarapu cf30c0478f remove deprecated builtinExtensionsServiceUrl api 2020-09-16 13:41:39 +02:00
Benjamin Pasero 9904d73c82 debt - avoid node.js path module 2020-09-16 13:39:47 +02:00
Benjamin Pasero 8f9f454231 sandbox - avoid direct use of node.js OS module 2020-09-16 13:38:04 +02:00
Sandeep Somavarapu 2c674e3994 update distro 2020-09-16 13:36:33 +02:00
Sandeep Somavarapu 20dd07ae66 support web overrides for configuration sync store 2020-09-16 13:36:33 +02:00
Sandeep Somavarapu 67bd821c07 control selecting settings service through canSwitch property 2020-09-16 13:36:32 +02:00
Benjamin Pasero f3bf1d1778 fix type 2020-09-16 12:43:11 +02:00
Benjamin Pasero 593e17873d sandbox - make timer service available in electron-sandbox
cc @jrieken
2020-09-16 12:41:31 +02:00
Benjamin Pasero add7bbfaa3 sandbox - use preload safe process in workbench common props 2020-09-16 12:41:31 +02:00
Johannes Rieken 136cc276d1 proposed API for CodeActionProvider#resolveCodeAction and all the wiring 2020-09-16 12:34:20 +02:00
Alex Dima 135b38e3a4 Fixes #106740: Improve description message 2020-09-16 12:16:53 +02:00
Alex Dima 2441447b02 Fixes #106524: Normalize AND expressions with a single operand 2020-09-16 12:10:46 +02:00
Benjamin Pasero 30143ab81b debt - move workbench telemetry properties to workbench 2020-09-16 11:58:40 +02:00
Benjamin Pasero 13356e24ec sandbox - lift configuration export helper to electron-sandbox 2020-09-16 11:58:40 +02:00