Commit Graph
1174 Commits
Author SHA1 Message Date
Matt Bierner 79d7a9569d Undoing exthost side of the webview serializer split 2020-08-26 16:46:25 -07:00
Matt Bierner 51ba70d426 Undo split of serializers into own main thread class
The serializers belong with the panels, not in their own class
2020-08-26 16:46:25 -07:00
Matt Bierner 4d88b39b7d Split up main thread webview services 2020-08-26 16:46:25 -07:00
Alexandru Dima f59e0c1460 Merge pull request #105437 from microsoft/rmacfarlane/earlyAuth 2020-08-26 20:43:24 +02:00
Alex Dima df5d0e588f Rename ActivationKind.Eager to ActivationKind.Immediate 2020-08-26 20:18:10 +02:00
Alex Dima 27082f3dbb Use an enum instead of a boolean to signal eager activation 2020-08-26 20:17:04 +02:00
rebornix 32f29cfdca transient outputs. 2020-08-26 10:51:46 -07:00
rebornix 7c986e94f4 transient metadata 2020-08-26 10:16:22 -07:00
Johannes Rieken 600d8a51cb tweak workspace edit dto and handling https://github.com/microsoft/vscode/issues/105283 2020-08-26 18:31:16 +02:00
Rachel Macfarlane 8871a28963 Make github-authentication a UI extension again 2020-08-26 09:01:42 -07:00
Johannes Rieken 0681925277 refactor bulk edit service a little so that it is fit for new edit types, https://github.com/microsoft/vscode/issues/105283 2020-08-26 12:29:26 +02:00
Matt Bierner c5134d83f7 Fix updating of a webview view's title 2020-08-25 15:17:09 -07:00
Matt Bierner 8ba70d8bdc Revert "Make github-authentication a UI extension again"
This reverts commit cd55420e7e.

This change seems to have caused issues activating extensions
2020-08-24 20:19:58 -07:00
Rachel Macfarlane cd55420e7e Make github-authentication a UI extension again 2020-08-24 18:44:14 -07:00
Matt Bierner 32dde5598d Use addWebviewInput
Fixes #105295
2020-08-24 08:43:11 -07:00
Johannes Rieken ac4de7bbb3 add NotebookEditorCellEdit#replaceOutputs, https://github.com/microsoft/vscode/issues/105283 2020-08-24 15:19:21 +02:00
Johannes Rieken ab8cf002d2 chore - remove unused code fyi @rebornix 2020-08-24 11:44:12 +02:00
Johannes Rieken db1f946073 chore - use $-prefix for IPC call onlys, fyi @rebornix 2020-08-24 11:33:06 +02:00
Johannes Rieken 834a380d93 add replaceCells to notebook edit builder, also refactor cell source to only be a string, not an array 2020-08-24 11:33:05 +02:00
40164f1f5b Add to WorkingCopyCapabilities enum to reflect usage. (#105020)
* Add to WorkingCopyCapabilities enum to reflect usage.

The capabilities field was being used with a value of 0 in a few places that implemented the IWorkingCopy interface. This inconsistency wasn't picked up by the compiler because the value in the enum was specified as `1 << 1` and not as `2`. This changes the value to be specified as `2` (for better type checking) and makes the 0 to use the new enum value.

* some polish on top

Co-authored-by: Maksym Taran <maksym.taran@gmail.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
2020-08-24 08:14:40 +02:00
Matt Bierner c50b5acd37 Fix local resources in webview views
Ensure we use the correct id for identifying the webview internally
2020-08-21 16:42:31 -07:00
Matt Bierner 041cf5dd0f Split main thread webview views to own file 2020-08-21 16:42:31 -07:00
Matt Bierner 5ec7e96238 Spelling 2020-08-21 16:42:31 -07:00
Rob Lourens 2489ff75c9 Add setting to control cell toolbar position
Fix #105195
2020-08-21 14:48:21 -07:00
Matt Bierner d192ba8806 Extract main thread custom editors to own file 2020-08-21 12:22:08 -07:00
Matt Bierner b2107a2d87 Extract MainThreadWebviewSerializers to own file
Fixes #105127

This time make sure to avoid cycles too
2020-08-21 12:22:08 -07:00
Connor Peet d20e086afc Merge branch 'connor4312/rm-old-renderer-api' 2020-08-21 09:12:08 -07:00
Martin Aeschlimann fae07df7c3 onTypeRename: wordPattern (for #104823) 2020-08-21 13:54:43 +02:00
Benjamin Pasero 44ad54d9fa Revert "Split main thread webview serializer code into own file"
This reverts commit 04de465524.
2020-08-21 07:37:34 +02:00
Matt Bierner 04de465524 Split main thread webview serializer code into own file 2020-08-20 16:45:45 -07:00
Matt Bierner daf5143e35 Split webview serializers into own ext host service 2020-08-20 16:45:45 -07:00
Matt Bierner 6db81f6ab2 Move custom editors into own ext host services 2020-08-20 16:45:45 -07:00
Matt Bierner 4fd7f660a4 Move webview views into own ext host class
Also fixes message passing for webview views
2020-08-20 16:45:45 -07:00
Matt Bierner 61f799f53b Add proposed webview view API (#104601)
Add proposed webview view API

For #46585

This adds a new `WebviewView` proposed api to VS Code that lets webview be used inside views. Webview views can be contributed using a contribution point such as :

```json
    "views": {
      "explorer": [
        {
          "type": "webview",
          "id": "cats.cat",
          "name": "Cats",
          "visibility": "visible"
        }
      ]
    },
```

* Use proper activation event

* Transparent background

* Fix resize observer

* Adding documentation

* Move webview view to new directory under workbench

* Remove resolver

By moving the webviews view into their own fodler, I was able to avoid the cycle the resolver was originally introduced for

* Use enum in more places

* Hook up title and visible properties for webview views

* Remove test view

* Prefer Thenable

* Add unknown view type error to collector
2020-08-20 13:59:22 -07:00
Alex Ross 640caaef05 Finalize task custom execution variable resolving
Fixes #81007
2020-08-20 13:49:20 +02:00
Alex Ross 73d583f759 Move task definition variable resolving to be early
Part of #81007
2020-08-20 13:34:09 +02:00
Connor Peet 24b712d7c2 notebooks: remove impure renderer API
This removes the initial notebook renderer API and keeps the 'pure'
renderer API described in #102644 and hacked-in previously.

Remaining work in this area, in no particular order:

- Add messaging context to postMessage as requested by Don (API proposal TBA)
- Cleanups around how state is managed internally in the backLayerWebView
- Deprecate the renderer `viewType` in favor of calling it the `id` or `rendererId`

Q: I kept around some of the "transform" functions since the mime type
picking happens there, not sure if there's a better place for this
to happen now, or whether these methods should simply be renamed.
2020-08-19 15:47:02 -07:00
Andre Weinand c233bf87bc add API to access DAP breakpoints; see #99716 2020-08-17 12:30:02 +02:00
Alex Ross 8418e06a5b Resolve customExecution task definition before going to exthost
Part of #81007
2020-08-14 16:31:44 +02:00
rebornix 25499ff969 fix #101871. 2020-08-13 16:57:47 -07:00
Daniel Imms f542cd1f76 Queue initial term data events for ext host delayed init
Fixes #103697
2020-08-13 11:00:40 -07:00
Alex Ross 52e38713f2 Allow workspace tasks to be executed through API
Fixes #104408
2020-08-12 14:46:45 +02:00
Johannes Rieken bae64052f4 unit test for document remove 2020-08-12 09:05:18 +02:00
rebornix 391bca591e re #104262. add log for execution and cancel. 2020-08-10 14:30:58 -07:00
rebornix 03467e96ff re #104262. Add logging for notebook. 2020-08-10 14:30:58 -07:00
Daniel Imms 2b353aac93 Remove terminal link handlers
Fixes #91606
2020-08-10 14:19:55 -07:00
João Moreno c466365768 Merge branch 'master' into pr/90952 2020-08-09 11:04:43 +02:00
João Moreno 92a861199c Merge branch 'joao/scm-perf' 2020-08-08 11:27:44 +02:00
João Moreno 6c7ff2bb3a scm: throttle resource group creation 2020-08-05 18:10:35 +02:00
Alex Ross a2b259cfa6 Improve documentation for visible
Fixes #104065
2020-08-05 16:31:53 +02:00