Commit Graph
3411 Commits
Author SHA1 Message Date
Justin Chen a35d42b8b5 Issue reporter display fixes (#196485)
* Update issue reporter service to display extension
data.

* added fix for duplicate templating:

* removes extension data when switching extensions:
2023-10-25 15:38:24 -07:00
Justin ChenandTyler James Leonhardt 8887abd9fc Allow additional extension data from Issue Reporter API (#196103)
* issue-reporter-main merge into branch (#13)

* laying the groundwork for issue reporter API

* working version 1

* added additional support, checkbox

* smol change with disabling edits and cleanup

* added blocker, timeout of 5 seconds, instead of rejecting we return

* added working template data as well

* removed test code

* cleaning up commit

* working with injecting template and allowing editing

* cleanup pass 1

* added progress bar and code cleanup

* cleanup and adding docs

* added default data in issuereporter test

* extension data hidden by default, better loading indication

* cleanup

* added codicons

* added codicon styling, removed progress bar:

* code cleanup

* better preview button handling

* cleaning up part 4

Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>

---------

Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
2023-10-23 22:09:33 +02:00
Benjamin Pasero 860056cdc3 💄 protocol confirmation checkbox label (#196193) 2023-10-22 12:34:57 +02:00
Benjamin Pasero 45dda0e1da debt - remove old style voice transcriber (#195883) 2023-10-18 14:42:02 +02:00
Isidor NikolicandBenjamin Pasero 9d32835bd7 add sqm id for windows (#195377)
* add sqm id for windows

* Update src/vs/platform/windows/electron-main/windowsMainService.ts

* Update src/vs/platform/sharedProcess/node/sharedProcess.ts

* react on review comments

* The reg entry is called MachineId not MachineGuid

* fix compile error

* no need for \\ prefix in reg path

* Wait for 1s max (as to not block the startup) to read the SQM value

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-10-12 13:47:40 -07:00
Benjamin Pasero df8c4d4537 Confirm for protocol links opt-out is not being honored (fix #195373) (#195437) 2023-10-12 08:59:22 +02:00
Benjamin Pasero 57b677dbe5 aux window - implement focusWindow via native host service 2023-10-11 11:29:10 +02:00
Benjamin Pasero 5b0739684d aux window - cleanup changes 2023-10-11 10:33:55 +02:00
Benjamin Pasero 0c52fb443b aux window - introduce main process service and use in some cases 2023-10-11 09:23:08 +02:00
Benjamin Pasero 91e59a296e aux window - better focus and reveal handling for editors (#194828)
* first cut focus handling

* 💄

* implement moveToTop

* cleanup
2023-10-05 09:51:10 +02:00
Benjamin PaseroandAlex Dima 73cc570f58 Allow for multiple editor parts (#193425)
* demo

* wip

* polish

* allow to toggle

* compile

* enable devtools

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* Avoid using global document, global window

* Fix exception caused by reading the size of the newly created window before it is available

* cleanup

* make it more useful

* apply zoom

* first cut editor parts

* cleanup

* scaffold some services

* preserve view state

* simple label distinction

* introduce accessor

* support dnd

* fix open editors view

* share window options

* cleanup

* 💄

* 💄

* 💄

* 💄

* cleanup on unload

* add todo

* stylescleanup

* avoid instanceof checks

* share more styles

* revert changes partially

* fix custom menus

* more alignment to main window

* codicon does not seem to be needed anymore

* no need for isHTMLElement

* fix icon error on macOS

* prevent `document.createElement`

* close child window when main window closes

* better active groups tracking

* cleanup

* pass along editor parts viewer

* eslint rule for instanceof checks

* add dom tests

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

---------

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2023-10-03 12:20:06 +02:00
Benjamin Pasero 8f382227e0 Add confirm for protocol links but allow to opt-out (#194405)
* wip

* simplify

* 💄
2023-10-02 15:20:30 +01:00
João Moreno 45358184ef Introduce trustedExtensionProtocolHandlers (#194304)
* remove url

* use trustedExtensionProtocolHandlers
2023-09-27 15:35:55 +01:00
Logan Ramos 8a7288ffe4 Enable logging only for ext test telemetry (#194056)
Attempt to enable logging only for ext test telemetry
2023-09-26 00:13:33 +02:00
Sandeep Somavarapu 35a34cd1f3 report profiles info event (#194055) 2023-09-25 23:21:34 +02:00
Benjamin Pasero c72447e8d8 Cannot read properties of null (reading 'b') (fix #193773) (#193774) 2023-09-22 09:48:12 +01:00
Justin Chen 444399e23b Lets issues of the "don't know" variety be filed from the issue reporter. (#193733)
makes string value not null
2023-09-21 22:31:10 -04:00
Justin Chen 85134de902 Fixes issue reporter bug with extension selection (#193719)
checks if we pre-existing extension information
2023-09-21 19:55:20 +01:00
Justin ChenandTyler James Leonhardt 6bd11d0301 Added placeholder for extensions dropdown (#193504)
* disable code actions specifically for autosave after delay:

* added fix for placeholder

* cleanup and removed empty option

* code cleanup

* specify htmlelement type

Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>

---------

Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
2023-09-19 14:52:40 -07:00
Benjamin Pasero a3c288eea5 debt - keep main services in electron-main (#193516) 2023-09-19 21:46:37 +02:00
Benjamin Pasero 9a9ef69e1f voice - cleanup disposables (#193199) 2023-09-15 13:05:57 +01:00
Benjamin Pasero f0a61fd8f6 voice - add a basic sliding window transcription approach based on silence detection 2023-09-15 12:40:07 +02:00
Benjamin Pasero 17c5355652 voice - still handle silence on the transcriber 2023-09-15 11:14:35 +02:00
Benjamin Pasero ea27cc09a8 voice - implement super simple vad 2023-09-15 10:05:34 +02:00
Sandeep Somavarapu 3b60c12380 fix #192970 (#193128) 2023-09-15 03:55:43 +10:00
Sandeep Somavarapu 6fce0c6cb6 Add settings sync troubleshoot tooling (#193114)
fix #192271
2023-09-14 15:03:52 +01:00
João MorenoandBenjamin Pasero 39de20e8a3 ensureNoDisposablesAreLeakedInTestSuite: ipc (#192570)
* ensureNoDisposablesAreLeakedInTestSuite: ipc

related to #190503

* debt - proxy services need to ask for disposables

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-09-11 21:01:46 +02:00
Tyler James Leonhardt 5134662139 Remove CredentialsService & keytar (#192224)
* Remove CredentialsService & keytar

ref https://github.com/microsoft/vscode/issues/115215
fixes https://github.com/microsoft/vscode/issues/143395

* compile

* remove imports

* rip the bandaid
2023-09-05 17:47:30 -07:00
Benjamin Pasero 14555a5123 app - ensure to remove windowId=_blank from protocol links (fix #191902) (#191990) 2023-09-01 16:40:42 +02:00
Benjamin Pasero 4f424db46e debt - ensure file scheme when using .fsPath (#191960) 2023-09-01 15:33:06 +02:00
Tyler James Leonhardt e7756c8870 reinstate github-auth parameter that was accidentally removed (#191862)
Fixes https://github.com/microsoft/vscode/issues/191861
2023-08-31 02:19:18 +02:00
Connor Peet 8ef6961789 server-web: implement secret storage provider (#191538)
Works quite similarly to vscode.dev. The client has a key stored in
secret storage. The server has a key stored server-side, and issues
an http-only cookie to the client. The client can ask the server to
combine its key and the http-only cookie key to a key component, which
it combines with its local key to encrypt and decrypt data.

This logic kicks in if the web server bits see a `vscode-secret-key-path`
cookie set when it loads.
2023-08-28 17:48:09 -07:00
Benjamin Pasero 85f166e053 voice - use LimitedQueue to prevent parallel transcriptions (#191311) 2023-08-25 15:04:59 +02:00
Benjamin Pasero d8f9194040 voice - limit media permission to insiders 2023-08-25 07:23:07 +02:00
Benjamin Pasero c21b0e9d56 Merge branch 'main' into ben/voice 2023-08-24 06:21:19 +02:00
Connor Peet 1fe8359ed0 cli: implement 'server of server' for a local web server (#191014)
Closes https://github.com/microsoft/vscode/issues/168492

This implements @aeschli's 'server server' concept in a new
`code serve-web` command.

Command line args are similar to the standalone web server. The first
time a user hits that page, the latest version of the VS Code web server
will be downloaded and run. Thanks to Martin's previous PRs, all
resources the page requests are prefixed with `/<quality-<commit>`.

The latest release version is cached, but when the page is loaded again
and there's a new release, a the new server version will be downloaded
and started up.

Behind the scenes the servers all listen on named pipes/sockets and the
CLI acts as a proxy server to those sockets. Servers without connections
for an hour will be shut down automatically.
2023-08-22 17:29:51 -07:00
Benjamin Pasero c71094a794 voice - stop processing after 30s 2023-08-18 12:03:18 +02:00
Benjamin Pasero 088f7cf832 voice - only send new data to voice transcriber 2023-08-18 11:50:37 +02:00
Benjamin Pasero 733530d9e5 voice - implement sequential transcriptions 2023-08-17 14:36:19 +02:00
Benjamin Pasero ce752f607a voice - better ports lifecycle 2023-08-17 14:10:01 +02:00
Benjamin Pasero e36739b66d voice - some cleanup and 💄 2023-08-17 12:13:14 +02:00
Benjamin Pasero b96621b58c voice - implement direct MessagePort communcation between audio worklet and shared process 2023-08-17 11:47:14 +02:00
Benjamin Pasero 03ffebe2fc voice - drop VSFloat32Array and encode float32 into a VSBuffer 2023-08-10 12:43:37 +02:00
Benjamin Pasero bb61acf43c Merge branch 'main' into ben/voice 2023-08-10 08:53:24 +02:00
Matt Bierner 6e251255fb withNullAsUndefined(x) -> x ?? undefined (#189987)
Follow up on #189983

Replaces `withNullAsUndefined` with uses of `??`
2023-08-08 16:45:52 -07:00
Benjamin Pasero 707bffbdae voice - scaffold a basic voice recorder service 2023-08-08 17:08:44 +02:00
Tyler James Leonhardt 1e0b12d1ca Remove vscode-encrypt from node.js side (#189252)
* Remove vscode-encrypt from node.js side

Now that we've had a version of the product that has done the migration logic, we no longer need vscode-encrypt on the node side.

This removes all references of vscode-encrypt from the node side. I will also remove it from the package.jsons in distro.

* remove machineId
2023-08-01 11:30:48 +10:00
Tyler James Leonhardt 2b5bf2176e Call toLower on a few places to align navigator.language behavior (#188714)
ref https://github.com/microsoft/vscode/issues/187795
2023-07-24 13:02:48 -07:00
Logan Ramos ef42b49e80 Support proxies in the telemetry service (#187952) 2023-07-14 11:53:47 -07:00
Tyler James Leonhardt 8dcddb4124 Have auth proxy use application storage service (#187094)
* Have auth proxy use application storage service

Since this code is already using the encryption service, it already takes advantage of the better encryption provided by Electron so it can be stored in the normal storage service.

With that said, we do need a migration path, so this handles that migration.

* re-encrypt to force using the new electron algorithm

* it should already be removed from the old location
2023-07-14 19:39:24 +02:00