Commit Graph

217 Commits

Author SHA1 Message Date
rebornix
7c986e94f4 transient metadata 2020-08-26 10:16:22 -07:00
Johannes Rieken
ac4de7bbb3 add NotebookEditorCellEdit#replaceOutputs, https://github.com/microsoft/vscode/issues/105283 2020-08-24 15:19:21 +02:00
Johannes Rieken
ab8cf002d2 chore - remove unused code fyi @rebornix 2020-08-24 11:44:12 +02:00
Johannes Rieken
db1f946073 chore - use $-prefix for IPC call onlys, fyi @rebornix 2020-08-24 11:33:06 +02:00
Johannes Rieken
834a380d93 add replaceCells to notebook edit builder, also refactor cell source to only be a string, not an array 2020-08-24 11:33:05 +02:00
Rob Lourens
2489ff75c9 Add setting to control cell toolbar position
Fix #105195
2020-08-21 14:48:21 -07:00
Connor Peet
24b712d7c2 notebooks: remove impure renderer API
This removes the initial notebook renderer API and keeps the 'pure'
renderer API described in #102644 and hacked-in previously.

Remaining work in this area, in no particular order:

- Add messaging context to postMessage as requested by Don (API proposal TBA)
- Cleanups around how state is managed internally in the backLayerWebView
- Deprecate the renderer `viewType` in favor of calling it the `id` or `rendererId`

Q: I kept around some of the "transform" functions since the mime type
picking happens there, not sure if there's a better place for this
to happen now, or whether these methods should simply be renamed.
2020-08-19 15:47:02 -07:00
rebornix
25499ff969 fix #101871. 2020-08-13 16:57:47 -07:00
Johannes Rieken
bae64052f4 unit test for document remove 2020-08-12 09:05:18 +02:00
rebornix
391bca591e re #104262. add log for execution and cancel. 2020-08-10 14:30:58 -07:00
rebornix
03467e96ff re #104262. Add logging for notebook. 2020-08-10 14:30:58 -07:00
rebornix
2d3d5208de re #102503. send out save event after notebook content provider handles saving. 2020-08-03 15:12:25 -07:00
Rob Lourens
057c1f141e Fix cell cancellation with kernel in provider 2020-07-30 18:02:38 -07:00
rebornix
d586f701ec kernel provider settings. 2020-07-20 17:17:50 -07:00
Rob Lourens
90363c2f9d Change cell execution/cancel API
Fix #99203
2020-07-20 14:43:20 -07:00
rebornix
6c5037f425 handle notebook text model creation in notebook service 2020-07-17 19:18:59 -07:00
rebornix
7704b6936e make mainthreadnotebook controller object literal 2020-07-17 19:04:12 -07:00
rebornix
80eee2dc94 mainthreadnotebook does not talk to mainthreadnotebook controller 2020-07-17 18:41:02 -07:00
rebornix
27c96b7a55 slim main thread notebook document 2020-07-17 17:20:40 -07:00
rebornix
2392bf40af model changes are always sent to ext host. 2020-07-17 17:16:10 -07:00
rebornix
7251526c06 no longer handle notebook backup in the core 2020-07-17 17:10:00 -07:00
rebornix
f475511726 kernel change event. 2020-07-17 12:02:08 -07:00
rebornix
847a98f34c Merge remote-tracking branch 'origin' into rebornix/multi-kernel 2020-07-16 17:26:00 -07:00
Johannes Rieken
80a3310946 add eol to IMainCellDto, no more attach/dettach text document but use the actual (sync'd) document or a fallback cell document 2020-07-16 12:55:39 +02:00
rebornix
05144a3d4e new kernel provider works side by side 2020-07-15 17:01:48 -07:00
rebornix
4fc84b3a11 sketch for notebook kernel 2020-07-15 16:18:17 -07:00
rebornix
5dc851f308 Fix #101378. De-ref text model from celltextmodel when it's disposed. 2020-06-30 14:45:58 -07:00
rebornix
573a528d72 Merge remote-tracking branch 'origin/master' into rebornix/separate-textmodel-selection 2020-06-23 08:07:17 -07:00
Connor Peet
a57cb45be8 notebooks: pipe renderer API postmessages to the renderer itself (#100414)
* notebooks: pipe renderer API postmessages to the renderer itself

Previously the postMessage on acquireNotebookRenderer API was just
a proxy to the global vscode postmessage. Now, it's linked to the
renderer and will cause an optional `onDidReceiveMessage` method on
the renderer to be called.

The message still _also_ goes to the global webview message handling
for advanced use cases, but this change allows the webview<->renderer
communication to be more nicely contained
and separate for most use cases.

* wip

* fixup! pr comments
2020-06-22 09:35:16 -07:00
rebornix
ac9e97aaa5 delay cells change from revert. 2020-06-19 13:52:59 -07:00
rebornix
5d9e565557 📓 Separate selections and text model 2020-06-18 19:22:08 -07:00
rebornix
6c68514534 Fix #100329. Content providers can contribute to undo/redo stack of a notebook document. 2020-06-17 17:08:09 -07:00
rebornix
ca7f2683fd resolve notebook editor with comm object. 2020-06-16 17:21:11 -07:00
rebornix
8ad77ef2b6 mimetype and remove revert. 2020-06-16 14:55:20 -07:00
rebornix
98c3065160 Fix #96840. Support backup/revert from notebook content provider. 2020-06-12 18:00:15 -07:00
rebornix
af949eff9d ignore empty notebook events. 2020-06-08 15:09:11 -07:00
rebornix
31101e83ff no layout after list view being disposed. 2020-06-05 14:53:33 -07:00
rebornix
11848b40d3 re #99240. 2020-06-04 14:46:37 -07:00
rebornix
adae0e5b4e Fix #98841. Open file should only emit document open event, no cells change event. 2020-06-02 15:13:32 -07:00
rebornix
0bf860564a Diffing editors/documents/visibleEditors/activeEditor. 2020-05-30 17:59:14 -07:00
rebornix
7fccb0d608 use updateState/compute instead of sending delta directly. 2020-05-30 17:57:48 -07:00
Johannes Rieken
5721d63eb6 notebooks - wire up onDidChange event from notebook providers, fyi @rebornix, https://github.com/microsoft/vscode/issues/96403 2020-05-29 13:20:28 +02:00
rebornix
8bac4d17ad combine events from edits from ext host. 2020-05-27 16:00:49 -07:00
rebornix
315807911c transform outputs for backup 2020-05-27 14:34:15 -07:00
rebornix
714991ce95 switch mimetype now should be done async. 2020-05-26 20:35:22 -07:00
rebornix
914fa13e26 support renderer and content provider registered in different extension host. 2020-05-26 20:11:49 -07:00
rebornix
b26e0bcf39 send out missing selection change event when moving cells. 2020-05-26 08:08:00 -07:00
rebornix
23f5231511 asWebvewUri requires guid. 2020-05-20 12:17:26 -07:00
rebornix
5c928428df notebookEditor.visible 2020-05-19 17:20:20 -07:00
rebornix
025bd27df7 webview comm based on editor other than document. 2020-05-18 18:13:45 -07:00