Commit Graph

19 Commits

Author SHA1 Message Date
Johannes Rieken
c04ac5a5df add property-init-order-check and run during CI (just like valid layers check) (#243042)
Enable ignore list which capture current violations and todo list
2025-03-10 10:22:18 +01:00
Robo
b5a6aa14a8 feat: switch to npm as default package manager (#226927)
* feat: move from yarn to npm

* chore: skip yarn.lock files

* fix: playwright download

* chore: fix compile and hygiene

* chore: bump vsce@2.17.0

Refs 8b49e9dfdf

* test: update results for bat and sh colorizer tests

* fix: add missing lock files for windows

* fix: switch to legacy-peer-deps

* chore: update markdown-it@14.1.0

Refs 737c95a129

esbuild step in extensions-ci-pr was previously using markdown-it
from root which had userland punycode and was able to compile successfully.

* ci: increase pr timeout for windows integration tests

* chore: fix product build

* build: ignore extension dev dependency for rcedit

* build: fix working directory inside container

* build: fix dependency generation

* npm: update dependencies

* ci: use global npmrc

* ci: update cache

* ci: setup global npmrc for private npm auth

* build: fix extension bundling

* chore: sync npm dependencies

* ci: debug env variables for container

* ci: fix win32 cli pipeline

* build: fix npmrc config usage for build/ and remote/ dirs

* fix: windows build

* fix: container builds

* fix: markdown-language-features tests and bundling

```
[03:58:22] Error: Command failed: /Users/demohan/.nvm/versions/node/v20.15.1/bin/node /Users/demohan/github/vscode/extensions/markdown-language-features/esbuild-notebook.js --outputRoot /Users/demohan/github/vscode/.build/extensions/markdown-language-features
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds userland package based on beed9aee2c

* fix: container builds for distro

* chore: update yarn occurrences

* fixup! chore: bump vsce@2.17.0

Uses the closest version to `main` branch that does not
include d3cc84cdec
while still having the fix 8b49e9dfdf

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: throw error when yarn is used for installation

* chore: add review feedback

* chore: switch exec => run where needed

* chore: npm sync dependencies

* fix: markdown-language-features bundling

```
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds missing userland package based on markdown-it/markdown-it@beed9ae,
can be removed once we update markdown-it >= 14.1.0

* ci: rename no-yarn-lock-changes.yml

* chore: sync npm dependencies

* ci: restore no-yarn-lock-changes.yml

We can disable it in a separate PR to keep the required
checks happy and also need workflow edit perms.

* chore: sync npm dependencies

* ci: rebuild cache

* ci: fix no-package-lock-changes.yml

* chore: bump distro

* chore: rm yarn.lock files

* chore: rm yarn.lock files without dependencies

* chore: add vscode-selfhost-import-aid to postinstall dirs

* chore: bump distro
2024-09-06 22:18:02 +09:00
dependabot[bot]
42c4cb5036 Bump actions/cache from 3 to 4 (#202999)
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-23 08:40:51 -07:00
João Moreno
79cb8061ed fix: use correct max-old-space-size flag syntax, increase mem limit for extensions-ci (#202862)
fixes #202720
2024-01-19 17:04:06 +01:00
dependabot[bot]
a0b228b51c Bump actions/setup-node from 3 to 4 (#196967)
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-03 17:41:14 +01:00
Rob Lourens
7d4027b62b Test using nvmrc in CI (#194836)
* Test using nvmrc in CI

* Force run yarn

* fix

* Bump nvmrc to latest

* Revert "Force run yarn"

This reverts commit af741f37d5.

* Make all jobs use node from nvmrc
And install node-gyp where needed
2023-10-04 19:08:50 -07:00
dependabot[bot]
01f471f25c Bump actions/checkout from 3 to 4 (#192764)
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-09-12 09:04:53 -07:00
Connor Peet
d0ff4f5353 build: update pipelines to node 18 (#189871)
build: update pipelines to node 16
2023-08-07 16:14:31 -07:00
Jongwoo Han
e4b995061d Replace deprecated set-output command with environment file (#172691)
Replace deprecated command with environment file

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
2023-01-31 11:23:08 +00:00
Alexandru Dima
7041b71cd6 Retire basic checks GH action (#161376)
* Add /build/ folder checks (just like GH action)

* Add more checks that were only present in the GH action

* Disable basic checks GH action
2022-09-21 00:58:06 -07:00
deepak1556
cdf6e99020 ci: don't restore stale cache 2022-08-01 20:25:29 +09:00
deepak1556
a347bd1a11 chore: update github workflow cache 2022-07-07 21:25:31 +09:00
Alexandru Dima
edc585edf6 Save some time and skip installing packages that are already there only in the Basic Checks build (#153487)
This reverts commit 42584f105e.
2022-06-28 14:22:45 +00:00
Alexandru Dima
5a43663aed Avoid downloading builtin extensions (#152339) 2022-06-16 17:15:49 +02:00
Alexandru Dima
0547fdbe65 Avoid installing playwright (#152335) 2022-06-16 14:42:28 +00:00
Alexandru Dima
1c3221183b No need to compile browser integration tests (#152061) 2022-06-14 09:43:37 -04:00
deepak1556
ad91296488 chore: update cache key 2022-06-10 19:45:16 +09:00
Alexandru Dima
c4870970ab Run a job on main which only warms up the node modules cache (#150007) 2022-05-20 10:52:56 +02:00
Alexandru Dima
14925e336d Add a basic check (#149832)
* Add a basic check

* Fix yaml error

* Another attempt to fix the yaml

* update actions versions

* let -> const

* Add hygiene and layering check

* update name
2022-05-19 11:18:22 +02:00