Commit Graph

11 Commits

Author SHA1 Message Date
Christof Marti
8031c495a6 Add option to skip sorting QuickPick items (#73904) 2019-11-18 17:09:31 +01:00
Peter Elmers
e9c0aeb8b0 Add optional sortByLabel to QuickPick to control whether to re-sort items when query changes
Summary:
Address issue #73904 by adding an optional `sortByLabel` to the QuickPick class which determines whether the picker re-sorts the result list when the user types in the input field.

If true, the picker applies a sort to order results by the index of the first appearance of the input in the label.

For backwards compatibility, this field is true by default.

https://github.com/microsoft/vscode/issues/73904

Test Plan:
attached video shows behavior both before and after

{F167292605}

note: there aren't any existing tests on what happens when the query input changes in the QuickPick

Reviewers: dalongi, ericblue, hchau

Reviewed By: ericblue

Differential Revision: https://phabricator.intern.facebook.com/D16203434

Signature: 16203434:1562878837:5413e3852f2bd04c8e81b9fe5c4a08127dfe3b65
2019-11-18 17:09:29 +01:00
Benjamin Pasero
e02e20c3ce strict property init (#78168) 2019-10-17 08:10:43 +02:00
Johannes Rieken
904ab2364e in extension land prefer URI.isUri, fixes #81819 2019-10-07 08:30:18 +02:00
Matt Bierner
029009eafd Marking most private emitters as readonly
Emitters should generally not be reassigned as their corresponding event would also be lost. Marking these as readonly just to enforce this
2019-09-23 17:31:18 -07:00
Christof Marti
044a5f9206 Remove suppressImplicitAnyIndexErrors (#76442) 2019-07-02 16:38:39 +02:00
Matt Bierner
bd39f3d7a1 Revert disposing of emitter change for extHostQuickOpen since it was breaking integration tests 2019-06-05 19:30:04 -07:00
Matt Bierner
a6ea8be992 Make sure we dispose of emitters in a few more places
Emitters should be disposed of properly in order to help prevent leaks
2019-06-05 15:41:45 -07:00
Johannes Rieken
c0821aa5e9 move extHost-files to common 2019-04-10 10:26:52 +02:00
Johannes Rieken
81456a7212 move api/common to api/browser 2016-01-11 14:44:13 +01:00
Benjamin Pasero
788201b268 debt - move quick open service to common 2015-12-21 19:07:56 +01:00