Commit Graph

8806 Commits

Author SHA1 Message Date
João Moreno
c7fec92849 Merge pull request #96069 from microsoft/joao/github-auth
Provide automatic git authentication to GitHub
2020-04-27 12:23:16 +02:00
João Moreno
bce93beff7 move github credential provider to git 2020-04-27 12:14:23 +02:00
Daniel Imms
7f5bada046 Move EnvironmentVariableCollection API into ExtensionContext (#96061)
* Move env var collection to ext context

* Remove dispose, fix persistent passing

* Fire collection change on persistence change

* Fix tests by forcing activation and getting ctx

* chore: bump js-debug

Co-authored-by: Connor Peet <connor@peet.io>
2020-04-24 16:45:30 -07:00
Rob Lourens
9b995534bc Add tests for metadata 2020-04-24 17:49:49 -05:00
Matt Bierner
4862602c4c Align custom editor API proposal with notebook API
Fixes #95854
Fixes #95849
For #77131

- Move all editing functionality back onto the provider. This better matches the notebook API.

- Rename `CustomEditorProvider` to `CustomReadonlyEditorProvider`.  `CustomEditorProvider` is now how editable custom editors are implemented

- Give extension a full suggested backup path instead of just a folder
2020-04-24 14:47:08 -07:00
rebornix
cea1d2f91f fix notebook integration test 2020-04-24 13:04:14 -07:00
Liying
ec5c1264bc Update compilerOptions returned by host for javascript.implicitProjectConfig.experimentalDecorators. (#95923)
Co-authored-by: liyche <liyche@umich.edu>
2020-04-24 11:34:03 -07:00
Rob Lourens
12e92983ad Update notebook test command IDs 2020-04-24 12:59:06 -05:00
Andre Weinand
795050f81b serverReady fix for #95108 2020-04-24 18:37:32 +02:00
João Moreno
065bb1b5d6 wip: use registerCredentialsProvider in github-authentication extension 2020-04-24 18:04:47 +02:00
João Moreno
cab6f958a2 git extension api: registerCredentialsProvider 2020-04-24 18:04:36 +02:00
João Moreno
77d7351226 add log to askpass ipc 2020-04-24 15:40:03 +02:00
Daniel Imms
ae1670d4ea Disable terminal tests in remote
Too flaky they're not useful.

See #96057
2020-04-24 06:27:59 -07:00
Daniel Imms
aa91f911f9 Suppress exit code notification in terminal test 2020-04-24 06:08:58 -07:00
Matt Bierner
a4597e1905 Enable JS/TS workspace symbol search for all projects
Fixes #11026

Adds a new `typescript.workspaceSymbols.scope` setting that enables searching all known projects when using TS 3.9+
2020-04-24 00:42:55 -07:00
Matt Bierner
f35758ab21 Rename supportsMultipleEditorsPerResource -> supportsMultipleEditorsPerDocument
For #77131
2020-04-23 17:33:06 -07:00
rebornix
9b11e5d500 avoid conflict with jupyter in OSS 2020-04-23 14:30:54 -07:00
Matt Bierner
7d238f4281 Add 'open with' to the explorer context menu (#95805)
This change primarly adds a new `Open with...` entry to the explorer context menu. To do this however, I had to make a few other changes:

- Add a new explorer context key for availible editors
- Moved the editor select prompt into a new function called `openEditorWith`
- Use `openEditorWith` for the new `open with` explorer command as well as for the `reopen with` command
2020-04-23 14:16:36 -07:00
rebornix
600528da86 Fix #96007. 2020-04-23 13:53:58 -07:00
Peng Lyu
582ced0089 Merge pull request #96001 from microsoft/rebornix/integration-test
Notebook integration test and undo/redo
2020-04-23 13:06:21 -07:00
Rachel Macfarlane
badd41f04a Better error handling in github auth provider 2020-04-23 12:16:33 -07:00
Peng Lyu
dc6f64a0d0 Merge branch 'master' into rebornix/integration-test 2020-04-23 11:59:59 -07:00
rebornix
b9eafe5f66 intergration tests. 2020-04-23 11:55:23 -07:00
Daniel Imms
87c0080c3a Merge pull request #95969 from microsoft/tyriar/95945
Make terminal echo integration test more reliable
2020-04-23 11:04:01 -07:00
Connor Peet
66744e3b25 debug: enable js-debug to auto attach (#95807)
* debug: enable js-debug to auto attach

This modifies the debug-auto-launch extension to trigger js-debug as
outlined in https://github.com/microsoft/vscode/issues/88599#issuecomment-617242405

Since we now have four states, I moved the previous combinational logic
to a `transitions` map, which is more clear and reliable. The state
changes are also now a queue (in the form of a promise chain) which
should avoid race conditions.

There's some subtlety around how we cached the "ipcAddress" and know
that environment variables are set. The core desire is being able to
send a command to js-debug to set the environment variables only if they
haven't previously been set--otherwise, reused
the cached ones and the address.

This process (in `getIpcAddress`) would be vastly simpler if extensions
could read the environment variables that others provide, though there
may be security considerations since secrets are sometimes stashed
(though I could technically implement this today by manually creating
and terminal and running the appropriate `echo $FOO` command).

This seems to work fairly well in my testing. Fixes #88599.

* fix typo

* clear js-debug environment variables when disabling auto attach
2020-04-23 09:49:29 -07:00
Daniel Imms
3d7745d6fc Dispose data listener before disposing terminal
Fixes #95945
2020-04-23 07:29:47 -07:00
Daniel Imms
84a884a97a Return after done(e)
Part of #95945
2020-04-23 07:27:29 -07:00
João Moreno
ab42ffc44c add git api to init 2020-04-23 16:26:24 +02:00
João Moreno
c7d7b0dc88 fix clone from 2020-04-23 15:26:47 +02:00
João Moreno
888f89b40a add renameRemote 2020-04-23 14:37:39 +02:00
Alex Dima
786d4dab94 Fix integration tests 2020-04-23 12:11:58 +02:00
João Moreno
df1a7b0e8a Merge pull request #95780 from fleck/patch-1
remove duplicate git.pullFrom command
2020-04-23 11:10:25 +02:00
Martin Aeschlimann
e26a0dd2c3 Dark+/Light+: constant color that is closer to the variable color (for #95346) 2020-04-23 09:52:30 +02:00
Rachel Macfarlane
2e5312cd61 Add account id to authentication session object 2020-04-22 18:00:16 -07:00
Rachel Macfarlane
006cfcd949 Rename microsoft auth provider output channel 2020-04-22 14:21:25 -07:00
Rachel Macfarlane
93cff0f3b6 Change key for microsoft auth provider 2020-04-22 14:17:36 -07:00
Matt Bierner
0d5ed6bfde Add logging of service state
For #95122
2020-04-22 14:01:30 -07:00
Duncan Walter
c7c2301bc2 TS: Add setting to prompt users about workspace tsdk (#95566)
* add a setting to prompt users to switch to tsdk version

* version manager in control

Co-authored-by: Duncan Walter <dwalter@hubspot.com>
2020-04-22 10:57:22 -07:00
João Moreno
3b0ba06a7b RemoteSourceProvider.icon 2020-04-22 17:16:35 +02:00
João Moreno
97b2fe2f7e show git repo details 2020-04-22 16:56:33 +02:00
Martin Aeschlimann
389e9dd5e8 Merge pull request #95751 from iliazeus/95584-additional-json-file-extensions
add more json file extensions #95584
2020-04-21 23:38:44 -07:00
Rachel Macfarlane
8fdb90a496 Add .vscodeignore file to github auth extension 2020-04-21 12:13:23 -07:00
Rachel Macfarlane
fd88fb9667 Await keychain write on logout for github auth 2020-04-21 11:16:45 -07:00
Jonathan Fleckenstein
f12f21d320 remove duplicate git.pullFrom command 2020-04-21 10:44:38 -04:00
João Moreno
d1e315f5e1 fix git clone 2020-04-21 15:35:10 +02:00
João Moreno
3d04c5558e support multiple URLs 2020-04-21 14:20:30 +02:00
João Moreno
106552963c handle remote source provider errors 2020-04-21 12:13:56 +02:00
Ilia Pozdnyakov
dbdf8bb075 add more json file extensions #95584 2020-04-21 14:45:05 +07:00
Miguel Solorio
8409851de0 Update default sidebar section header colors (fixes #93764) 2020-04-20 10:30:40 -07:00
João Moreno
479b3dafb5 Merge branch 'joao/git-remote-providers' 2020-04-20 17:33:16 +02:00