Commit Graph

232 Commits

Author SHA1 Message Date
Gus Hurovich
1b4886dda9 Adding setting for disabling partial parsing in stylesheets (#46979)
* Adding setting for disabling partial parsing in stylesheets

* Added description
2018-03-30 11:24:54 -07:00
Gus Hurovich
e252da3861 Adding tests for stylesheets partial parsing (#46977) 2018-03-29 17:48:32 -07:00
Ramya Rao
2de91fdce5 Css partial parse refactoring (#46894)
* Refactor parsePartialStylesheet

* More refactoring

* To avoid errors, parse line comments char by char and no when getting to previous line.

* Revert "To avoid errors, parse line comments char by char and no when getting to previous line."

This reverts commit f353dba4c7.

* Fix for inline comments inside block comments
2018-03-28 18:12:07 -07:00
Gus Hurovich
95b0cffe72 Fix for #46745 (#46788)
* Fix for #46745

* If { found in selector, don't partial parse.
Adding sanity checks
2018-03-27 18:32:46 -07:00
Ramya Achutha Rao
c2dc46c1ce Offset is relative to position when finding comment 2018-03-27 12:28:20 -07:00
Ramya Achutha Rao
c07abc03f7 Avoid parsing file when abbr is invalid #43470 2018-03-27 12:12:22 -07:00
Ramya Achutha Rao
f5b569b633 Use partial parsing for stylesheets for Emmet command #43470 2018-03-27 09:51:19 -07:00
Ramya Achutha Rao
65e502e8ef Remove unused variables 2018-03-26 21:19:35 -07:00
Ramya Achutha Rao
2792b8f437 Skip emmet inside comments in stylesheets when running the command 2018-03-26 20:47:09 -07:00
Ramya Achutha Rao
4f10555e3c Skip emmet inside comments in stylesheets #46434 2018-03-26 18:30:37 -07:00
Gus Hurovich
91416ffab8 Stylesheet partial parse (#46376)
* First draft at partial parsing of css for emmet

* Partial parsing of stylesheets for Emmet

* Addressing feedback

* Refactoring and fixing little bug

* Liitle fix

* Equals are now equals

* We don't want emmet in selectors

* Skip comments when preparsing

* Addressing feedback, refactoring and cleaning up code.

* Update endPosition only if not eof

* Use function to find closing comment

* Don't check more than 5000 characters back
2018-03-26 18:14:28 -07:00
Ramya Achutha Rao
871e610848 Respect selfClosingStyle when joining tags Fixes #44417 2018-03-26 15:05:04 -07:00
Ramya Achutha Rao
7db6419d78 Avoid re-parsing for emmet completions when triggered for incomplete completions 2018-03-26 13:33:38 -07:00
Ramya Achutha Rao
e7ce1f53ea Do not lookahead when extracting css abbreviations Fixes #46452 2018-03-23 17:38:38 -07:00
Jean Pierre
af21dc7925 Fix for #46106 (#46309) 2018-03-22 14:19:53 -07:00
Gus Hurovich
a716373aaa Adding Live Preview for Wrapping Individual Lines with Abbreviation (#45453)
* Adding Live Preview to wrapIndividualLinesWithAbbreviation

* Refactoring

* Re-arranging code
2018-03-13 21:34:52 -07:00
Ramya Achutha Rao
fa6a57bf47 Fix emmet tests 2018-03-13 00:07:05 -07:00
Ramya Achutha Rao
6d5739d3ec Remove obsolete code as html emmet completions are now coming from html extension 2018-03-12 23:47:09 -07:00
Ramya Achutha Rao
9d578694d0 Validate position for emmet using best guess fixes #45634 2018-03-12 23:39:38 -07:00
Ramya Achutha Rao
b7cf44841a Remove obsolete code as html emmet completions are now coming from html extension 2018-03-12 23:39:25 -07:00
Gus Hurovich
16b91c78f4 Emmet: when wrapping, skip lines with no characters selected (#45224)
* When wrapping using Emmet, don't consider lines with no characters selected.

* Adding unit tests

* Adding support for multicursors in wrapIndividualLinesWithAbbreviation

* Moving check in multicursor wrapIndividualLines

* Make sure when expanding several abbreviations with different snippets that the edits are applied in reverse order.
2018-03-09 16:49:07 -08:00
Gus Hurovich
2e746d8118 Emmet - Wrap with abbreviation with live preview (#45092)
* Revert "Fix for Emmet's wrap with abbreviation inserting extra spaces (#43345)"

This reverts commit 7420a04c64.

* Adding ability for emmet to wrap with abbreviation in real time.

Currently it's only working for single cursor.

* Fixes to wrap in real time:

- Removed flickering when typing abbreviation
- Removed tabstops
- Fixed bug when wrapping multiline text

* Fixes to a few issues.

- Added checks for not reverting previews more times than needed, that was causing extra text to be deleted.
- Fixed issue when wrapping nodes with multiple level of indentation.
- Removed all the undo commands. Now all the logic of going back to the original state is handled by revertPreview.

* Ammend for previous revert

* Reapplying reverted commit, fixing the bug for this branch's version

Refactoring some of the code, now a single object contains the current and original ranges, as well as the original content to wrap

* Adding multicursor support

* Renaming, refactoring and other stuff

* More refactorings

* More renaming and refactoring

* Replacing placeholders when previewing, simplifying the extracting of preceeding whitespace, added a check for validity of expandedtext on each selection.

* More refactoring

* Adding a comment.

* Readding test removed by mistake.

* Refactoring

* Carefully reverting changes in yarn.lock

* carefully but right
2018-03-06 17:11:07 -08:00
Ramya Achutha Rao
6e1574671a Use copy of config object to avoid making changes to the readonly objects 2018-03-05 10:22:01 -08:00
Ramya Achutha Rao
4392d2efff Trigger emmet in js files on ! Fixes #43841 2018-03-02 16:22:07 -08:00
Ramya Achutha Rao
c16869d804 Revert move of emmet to css extension Fixes #44840 2018-03-01 12:59:47 -08:00
Gus Hurovich
7420a04c64 Fix for Emmet's wrap with abbreviation inserting extra spaces (#43345)
* Fixing trailing spaces in expansion

* Emmet - Fixing extra spaces when wrapping with abbreviation

* Avoid fetching tag if there's no need to ezpand again

* Replacing several 'indexof's with regexp

* Making regexp for tagname stricter. Removing unnecessary check.

* Removing extra call to expand.

* tiny changes

* tinitiny changes
2018-02-14 17:08:44 -08:00
Ramya Rao
00f2d8ed71 Get emmet completions from css extension (#41652)
* Get emmet completions from html,css extensions

* Resolve extensionsPath, use emmet results even if empty

* Support css abbr with :

* Refactoring

* Add some basic emmet tests

* Refactoring

* More tests
2018-02-12 21:40:10 -08:00
Ramya Achutha Rao
bfbbe132cf Fix css emmet abbreviations with : Fixes #43544 2018-02-12 14:48:56 -08:00
Matt Bierner
308c1887df Update extensions for TS 2.7
Update src to build with TS 2.7

Explicitly assign this.message in the else body
2018-02-08 14:28:55 -08:00
gushuro
e10ce07e3a Emmet - Fixing bug in toggle comment with multi cursor (#42857)
* Fixing issue with toggleComment on multiple nested cursors

* Fix error when an edit is empty

* reordering

* adding a test for toggleComment on nested selections

* Adding test for stylesheet files

* Removing change that was making integration tests fail
2018-02-08 11:45:52 -08:00
Ramya Achutha Rao
a31d226c54 Fix emmet for sass,stylus #42904 2018-02-03 20:12:25 -08:00
Ramya Achutha Rao
611b4b365f Support vendor prefix in emmet #35951 2018-01-31 17:05:02 -08:00
Ramya Achutha Rao
02526ccf61 Semicolon is nolonger required to reset emmet 2018-01-31 17:05:01 -08:00
Ramya Achutha Rao
7a5045618e Skip emmet in selectors #42245 2018-01-27 22:10:58 -08:00
Ramya Achutha Rao
f57b024b18 Use latest emmet helper that has fixes #33818 2018-01-19 10:51:24 -08:00
Pascal Fong Kye
b36655544f fix: wrap current node when no selection and cursor on opening or closing tag (#41602) 2018-01-14 16:52:47 -08:00
Ramya Achutha Rao
05854360cc Fix typo 2018-01-14 12:35:38 -08:00
Ramya Achutha Rao
65f1bd4b25 Allow hex color completions from emmet 2018-01-12 16:07:53 -08:00
Ramya Achutha Rao
ca023a700f Move absolute path check to avoid dependency on path in emmet helper 2018-01-11 19:01:53 -08:00
Ramya Achutha Rao
f4ed56b0d6 Ignore php tag when deciding if cursor is inside open tag Fixes #41216 2018-01-08 18:56:51 -08:00
Ramya Achutha Rao
bdeb370602 Apply comment filter when wrap with abbr fixes #40471 2017-12-19 13:46:42 -08:00
Ramya Achutha Rao
4913e7f68f Split emmet abbreviation tests 2017-12-15 15:25:58 -08:00
Ramya Achutha Rao
5503b0b92f Avoid emmet when typing css property values Fixes #34162 2017-12-14 16:02:52 -08:00
Ramya Achutha Rao
4199874acb Skip parsing docs when emmet suggestions are disabled 2017-12-12 14:24:03 -08:00
Ramya Achutha Rao
a1b377e423 Skip emmet when open tag is not closed even when no parent node #35128 2017-12-06 15:05:06 -08:00
Ramya Achutha Rao
f4d549e757 Fix unused code errors 2017-12-04 15:43:35 -08:00
Ramya Achutha Rao
813b2d91a7 Fix broken emmet tests 2017-12-04 15:14:17 -08:00
Ramya Achutha Rao
021e95d747 Fix #39578 Add completion provider tests for emmet 2017-12-04 14:29:56 -08:00
Ramya Achutha Rao
8a12b294de Skip emmet when open tag is not closed Fixes #35128 2017-12-03 18:14:07 -08:00
Ramya Achutha Rao
699a12cb78 Mapped languages shld be excluded if in emmet excludes for expand cmd #39369 2017-12-01 11:36:49 -08:00