Commit Graph

29 Commits

Author SHA1 Message Date
Daniel Imms
a3c8ce1482 Force accept function in dispatchKeybinding
One common source of flakiness is just dispatching a keybinding and
not verifying it did its thing. This change adds a few accept functions
and also forces callers to provide an async function so that the caller
considers adding one as it's the norm, not the edge case.

Fixes #246731
2025-07-10 06:49:16 -07:00
Robo
7e4d8e92bc (Reland) fix: smoke tests for stable with editcontext enabled (#251074) 2025-06-10 00:44:09 -07:00
Robo
12326f9906 chore: update to Electron 35 (#245423)
* chore: bump electron@35.0.1

* chore: update types/node@22.x

* chore: update web types for node v22.x

* chore: bump electron@35.1.2

* chore: update node.js build

* chore: update app.dock usage

Refs 71f3ff6bf2

* chore: bump electron@35.1.4

* chore: bump electron@35.1.5

* ci: bump sysroot to glibc 2.28 and gcc 10.5.0

* ci: enable timeout for smoketests

* chore: bump min glibcxx to 3.4.26 for server

* Revert "ci: enable timeout for smoketests"

This reverts commit afb637e85d.

* chore: update debian dependencies

* fix: workaround npm.ps1 argument parsing with powershell

* chore: update rpm dependencies

* test: partially revert changes from 242535

* test: remove redudant keybinding dispatch for selectTab

* test: fix test failure from running configured tasks

* test: focus settings editor for preferences.test.ts

* node - adopt compile cache (#246835)

* node - adopt compile cache

* adopt for utility process

* tweaks

* log state of compilation cache

* Revert "log state of compilation cache"

This reverts commit f3840387a583013834762e2c44f6e8424929297f.

* Revert "node - adopt compile cache (#246835)"

This reverts commit 673a00cab66c9bac87f3cd27b80efa41c80150f1.

* chore: update builds

* chore: bump electron@35.2.0

* chore: bump electron@35.2.1

* chore: bump electron@35.2.2

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2025-05-09 19:03:36 +09:00
Aiday Marlen Kyzy
fa548237be Adding acceptance condition to dispatchKeybinding in smoketests (#242570)
* adding code for smoke tests

* adding awaits

* changing wait code

* renaming dispatch to send

* moving comment

* update to send
2025-03-05 11:38:48 +01:00
Aiday Marlen Kyzy
060de16f9d Directly accepting editor selection when using text area edit context (#239211)
* allowing two offsets

* changing to true
2025-01-30 14:53:12 +00:00
Aiday Marlen Kyzy
4b2a52e942 Fixing smoketests, using different selection offsets depending on product quality (#239108)
fixing smoketests, using different selection offsets
2025-01-29 16:53:18 +01:00
Aiday Marlen Kyzy
3ff1dceedf Enable edit context (#237497)
* Revert "Revert Enablement of EditContext on Insiders (#235062)"

This reverts commit 45385e1c6f.

* adding product import

* adding som code

* removing console logs

* make sure editor selection is observed after keybinding dispatches

Co-authored-with: Aiday Mar <amarlenkyzy@microsoft.com>

* removing empty lines

---------

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2025-01-13 09:47:32 +01:00
Aiday Marlen Kyzy
be5c64a3df Revert "Enable edit context" (#237468)
Revert "Enable edit context (#235386)"

This reverts commit 3958e26f65.
2025-01-08 11:43:30 +01:00
Aiday Marlen Kyzy
3958e26f65 Enable edit context (#235386)
* Revert "Revert Enablement of EditContext on Insiders (#235062)"

This reverts commit 45385e1c6f.

* adding product import
2025-01-07 10:00:03 +01:00
Aiday Marlen Kyzy
45385e1c6f Revert Enablement of EditContext on Insiders (#235062)
Revert "Reenabling EditContext by default on Insiders (#234888)"

This reverts commit a47f407e38.
2024-12-03 08:37:57 +01:00
Aiday Marlen Kyzy
a47f407e38 Reenabling EditContext by default on Insiders (#234888)
Revert "Revert "Smoke test failure - changing selectors depending on app qual…"

This reverts commit b8d5339e04.
2024-11-29 11:49:50 +01:00
Aiday Marlen Kyzy
b8d5339e04 Revert "Smoke test failure - changing selectors depending on app quality" (#234638)
Revert "Smoke test failure - changing selectors depending on app quality (#23…"

This reverts commit b69589ce38.
2024-11-26 09:17:31 +01:00
Aiday Marlen Kyzy
b69589ce38 Smoke test failure - changing selectors depending on app quality (#234181)
* changing selector depending on app quality smoke test

* using correct selector

* resetting to just insiders

* focusing if not focused after event

* removing dom node focus
2024-11-21 11:58:33 +01:00
Aiday Marlen Kyzy
8d1d1373cd Reverting EditContext changes (#234247)
reverting changes
2024-11-20 10:18:20 +01:00
Aiday Marlen Kyzy
d649101bec Turning on experimental edit context on Insiders (#234071)
* turning on experimental edit context on insiders

* fixing smoke test

* resetting the search input to use the textarea
2024-11-19 10:19:00 +01:00
Raymond Zhao
e9e1f8a132 Revert "Separate Settings editor open and search steps" (#196997)
Revert "Separate Settings editor open and search steps (#196866)"

This reverts commit 932e49579b.
2023-10-30 09:53:19 -07:00
Raymond Zhao
932e49579b Separate Settings editor open and search steps (#196866) 2023-10-30 07:50:27 -07:00
Raymond Zhao
a08322ae0a Add delay to Settings editor search for smoke tests (#190903)
Ref #190896
2023-08-21 20:54:48 +01:00
Raymond Zhao
42b4bf0670 Add Settings editor smoke tests (take 2) (#189867) 2023-08-08 13:01:53 -07:00
Raymond Zhao
39e5dafcd6 Revert "Add Settings editor smoke tests" (#189848)
Revert "Add Settings editor smoke tests (#189687)"

This reverts commit e1dfb2a559.
2023-08-07 18:40:37 +01:00
Raymond Zhao
e1dfb2a559 Add Settings editor smoke tests (#189687)
Fixes #141054
2023-08-07 08:22:07 -07:00
Daniel Imms
87a99dba09 Speed up shell integration tests and improve reliability 2022-06-15 18:50:34 -07:00
Daniel Imms
a5f0a29527 Fix, re-enable or disable skipped terminal smoke tests
Fixes #146700
2022-05-06 08:11:50 -07:00
Sandeep Somavarapu
fb8316c8f4 #141054 check line numbers in settigns file 2022-02-01 09:35:54 +01:00
Benjamin Pasero
041e4d9b1f fix smoke tests with stable build (fix #117420) 2021-02-23 19:04:51 +01:00
Jackson Kearl
4623a50995 Fix #116154 2021-02-08 17:46:12 -08:00
Benjamin Pasero
85d2077f19 smoke - quickopen => quickaccess 2020-03-26 12:28:49 +01:00
Benjamin Pasero
4f0b2b0689 tests - fix smoketests for new quick open impl 2020-03-24 08:39:53 +01:00
Jason Ginchereau
4f2c387de1 Refactor smoke UI automation into separate package 2019-09-05 09:16:29 -07:00