Commit Graph

28395 Commits

Author SHA1 Message Date
Rob Lourens 76ced50914 Settings editor - remove leftover reset button 2018-07-19 09:55:31 -07:00
Daniel Imms 7b45764115 Workaround an issue where the terminal could overflow into right sidebar
Fixes #54230
2018-07-19 09:53:12 -07:00
Rob Lourens 3b7e13d53f Merge pull request #54518 from cleidigh/settings-selectbox-setAriaLabels/tweak
Settings: Utilize selectBox.setAriaLabel Related: #53821
2018-07-19 09:13:53 -07:00
Rob Lourens fb20a9be56 Merge pull request #54625 from JoshuaKGoldberg/file-search-trim
Trimmed file search strings in the search menu
2018-07-19 09:05:45 -07:00
isidor 9461528247 menubar registration: layout menu to appropriate owners
#54510
2018-07-19 18:03:36 +02:00
Jackson Kearl ca6471d6d6 Merge pull request #54672 from JacksonKearl/bug-autosuggest-trigger-chars
Fix autosuggest trigger chars not working in simpleWidgets
2018-07-19 09:03:27 -07:00
Jackson Kearl 8e42c9741f Fix autosuggest trigger chars not working in simpleWidgets 2018-07-19 08:46:28 -07:00
isidor 1141a5b8cd menubar registration: appearance menu to appropriate owners
#54510
2018-07-19 17:41:59 +02:00
isidor bd9db2df5e menus: move View menu contributions to appropriate owners
#54510
2018-07-19 17:31:20 +02:00
isidor e67143de42 menubar registration: file menu
#54510
2018-07-19 17:01:05 +02:00
Johannes Rieken f740c59962 breadcrumbs - fix reveal before layout (once again) 2018-07-19 16:58:42 +02:00
Alex Dima dcd5ea858f Fixes #54550: Define fs as original-fs only when running in Electron 2018-07-19 16:06:14 +02:00
isidor 0738ae2f7f menu: move debug menu registration to debug.contribution 2018-07-19 16:04:52 +02:00
Johannes Rieken e90faf1fa7 breadcrumbs - add "Toggle Breadcrumbs" to "View" menu 2018-07-19 15:59:51 +02:00
Johannes Rieken d5eb9df2b4 💄 2018-07-19 15:32:11 +02:00
Johannes Rieken 1a14814f05 breadcrumbs - disable min-width test 2018-07-19 15:32:10 +02:00
Johannes Rieken d0b1708a1c breadcrumbs - prevent scrollbar flashing 2018-07-19 15:32:10 +02:00
Johannes Rieken 48345b002d breadcrumbs - show hellip when outline info is available but not intersecting with the current selection 2018-07-19 15:32:10 +02:00
Alex Dima a384b259e6 Allow to create a Client with a Protocol 2018-07-19 15:27:12 +02:00
Alex Dima ae266f38ac Allow the Protocol to be disposed and extract buffered data 2018-07-19 15:25:40 +02:00
Alex Dima 1e82a6c1ca Improve type declarations 2018-07-19 15:19:43 +02:00
isidor 3e5f169e97 open editors: show actions for focused elements 2018-07-19 15:13:00 +02:00
Johannes Rieken 3f457f95ae breadcrumbs - don't use selection background color but an arrow 2018-07-19 12:52:39 +02:00
isidor 3ee7bda7ca list: simplify if statement 2018-07-19 11:41:40 +02:00
isidor d8feb77a06 list: do not steal focus for hidden elements (properly get style) 2018-07-19 11:36:56 +02:00
isidor 56ba2993ec list: do not steal focus for hidden elements 2018-07-19 11:31:56 +02:00
Johannes Rieken 9eedfdc260 fix missing icons in symbol search picker 2018-07-19 11:11:24 +02:00
Johannes Rieken eab1a7ad1f breadcrumbs - nicer picker creation 2018-07-19 11:11:24 +02:00
Johannes Rieken 742ea0dfdf breadcrumbs - don't show folder icons, shrink items for less scrolling 2018-07-19 11:11:24 +02:00
Joao Moreno 290570aaa7 fixes #52658 2018-07-19 11:10:45 +02:00
Joao Moreno 6396b69035 Merge branch 'master' of github.com:Microsoft/vscode 2018-07-19 10:15:09 +02:00
Joao Moreno 8fce8cce26 fixes #52658 2018-07-19 10:14:32 +02:00
Johannes Rieken f8ad345f20 breadcrumbs - make tab select an item from the picker, also tweak arrow key behaviour 2018-07-19 10:11:01 +02:00
Joao Moreno e427970032 Merge branch 'master' of github.com:Microsoft/vscode 2018-07-19 10:10:36 +02:00
Joao Moreno 96d06bd9e4 fixes #52601 2018-07-19 10:10:09 +02:00
Johannes Rieken bcb31657f2 breadcrumbs - add 'Focus Breadcrumbs' command 2018-07-19 09:47:58 +02:00
Peng Lyu f9f6cece37 fix microsoft/vscode-pull-request-github#43. Show comment indicator when editor has focus. 2018-07-19 15:30:54 +08:00
Josh Goldberg d7ea94d1f6 Allowed undefined options.filePattern
Forgot you folks aren't on strict types!
2018-07-18 22:45:08 -07:00
Josh Goldberg 0ed4d0ec02 Trimmed file search strings in the search menu
As suggested by roblourens, goes through `queryBuilder`'s `query` to trim the `filePattern`.

Fixes #54529.
2018-07-18 19:42:11 -07:00
Matt Bierner cec4ca0152 Extract isValid hover check 2018-07-18 17:21:04 -07:00
Matt Bierner 6a9f2159e1 Return results directly instead of using temp array 2018-07-18 17:19:11 -07:00
Matt Bierner c530bbb6c7 Refactoring
- Use const
- Remove use strict
- Return early instead of nesting
2018-07-18 17:16:19 -07:00
Matt Bierner f30234030a Use coalesce 2018-07-18 17:14:06 -07:00
Matt Bierner 0a1b3a5deb Use DefinitionLink internally instead of location 2018-07-18 16:53:40 -07:00
Matt Bierner 4610214559 Make sure our internal DefinitionProvider has backwards compatible api 2018-07-18 16:44:48 -07:00
Matt Bierner 44cd521ced Finalize definition link (#54424)
Finalize the definition link api

- Gives fields more explicit names (target and origin)
- Moves api to vscode.d.ts
- Makes other definition providers (such as type definition provider and implementation provider) also return definition links

Fixes #54101
2018-07-18 16:32:27 -07:00
Rachel Macfarlane 43cdb2c69b High contrast border in comments editor widget
Fixes https://github.com/Microsoft/vscode-pull-request-github/issues/58
Fixes https://github.com/Microsoft/vscode-pull-request-github/issues/59
2018-07-18 15:34:51 -07:00
Rachel Macfarlane 346b9770bb Block quote in comments styling, fixes https://github.com/Microsoft/vscode-pull-request-github/issues/60 2018-07-18 15:16:01 -07:00
Matt Bierner a51874590c Extract common type 2018-07-18 14:28:55 -07:00
Matt Bierner 0fbc508f17 Prefix unused with _ 2018-07-18 14:28:55 -07:00