Benjamin Pasero
90fd44c102
Merge branch 'master' into ben/sqlite
2018-10-12 09:16:30 +02:00
Alex Dima
46d1426b7e
Strict null checks ( #60565 )
2018-10-12 08:49:08 +02:00
Benjamin Pasero
4cffff9f6b
fix #51013
2018-10-12 08:00:12 +02:00
Matt Bierner
69fd947d76
Mark types as nullable where we explicitly assign something to undefined
2018-10-11 16:45:05 -07:00
Matt Bierner
7c0bfb91d4
strict null checks
...
#60565
2018-10-11 16:45:05 -07:00
Matt Bierner
ffbe67fef4
Annotate a few more null assignments
2018-10-11 16:45:05 -07:00
Matt Bierner
29d97683a1
Add null annotations for x: T[] = null
...
This code pattern indicates that the type should be nullable
2018-10-11 14:25:11 -07:00
Matt Bierner
0318e90c93
Add null type annotations for the common x: T = null pattern
...
In these cases, the programmer has explicitly indicated that the type should be nullable
2018-10-11 14:13:20 -07:00
Matt Bierner
da546f5d5d
Add null checks in filters and context keys
2018-10-11 13:29:11 -07:00
Alex Dima
0c403f82c3
More strict null ( #60565 )
2018-10-11 22:03:17 +02:00
Matt Bierner
428eac303b
Adding a few more files to strict null checks
2018-10-11 08:48:59 -07:00
Alex Dima
3ba326658d
More strict null sources ( #60565 )
2018-10-11 17:35:17 +02:00
Alex Dima
3e5bdc4571
Better typings for IteratorResult ( #60565 )
2018-10-11 15:50:08 +02:00
Alex Dima
740ac11a17
More strict null checks ( #60565 )
2018-10-11 13:04:56 +02:00
Benjamin Pasero
b77b9af3da
sqlite - first cut next storage adoption
2018-10-11 12:37:41 +02:00
Alex Dima
ae2f5e1c92
Add more files to be strict-null checked ( #60565 )
2018-10-11 10:59:45 +02:00
Alex Dima
98a67aea25
Reduce usage of WinJS.Promise ( #53526 )
2018-10-11 08:46:45 +02:00
Alex Dima
17d674aadf
Reduce usage of WinJS Promise ( #53526 )
2018-10-10 22:48:12 +02:00
Rob Lourens
8bd5387d37
Implement multiline search for #13155
2018-10-09 08:05:19 -07:00
Johannes Rieken
711217acc5
debt - less TPromise usage
2018-10-09 10:33:26 +02:00
Johannes Rieken
0741911a0f
add test for #60232
2018-10-09 10:28:25 +02:00
Alex Dima
fdf2dec52d
Remove usage of TPromise from public editor API ( #53526 )
2018-10-09 09:46:54 +02:00
Alex Dima
6daba7710a
Migrate to native Promise in web worker related code ( #53526 )
2018-10-09 09:24:07 +02:00
Alexandru Dima
99d97b5d93
Merge pull request #59568 from kscharlund/odd-indentation-support
...
Support odd indentation sizes (fixes #17639 )
2018-10-09 08:49:43 +02:00
Miguel Solorio
00cd0c355b
Increase max-width for find-widget
2018-10-08 08:48:08 -07:00
Matt Bierner
6d8b6d39cc
Remove css vendor pefixes for transition and transform ( #60050 )
...
The css3 `transform` and `transition` properties are now widely supported. I do not believe we need to ship vendor prefixed rules for these anymore
2018-10-08 08:10:15 -07:00
Alex Dima
ff085d3bc7
Fixes #59328
2018-10-08 16:12:10 +02:00
Johannes Rieken
75dc89debc
more measurement prop...
2018-10-08 11:13:23 +02:00
Johannes Rieken
14ba3e2647
less TPromise in editor/contrib
2018-10-08 10:48:56 +02:00
Johannes Rieken
9fa354a7aa
update internal API to allow parameter label to be an offset-range of its the signature label, #56337
2018-10-08 10:22:54 +02:00
Matt Bierner
2f51e97117
Add retrigger characters to SignatureHelpProvider
...
Introduces the concept of a re-trigger character to the signature help provider. This is a seperate set of characters that are registered with the provider. Typing a retrigger character fires a new signature help request if signature help is already showing.
#54972
2018-10-05 16:01:02 -07:00
Matt Bierner
2e8993b83c
Prefer const
2018-10-05 14:42:54 -07:00
Johannes Rieken
23891f8781
perf - use IdleValue in suggest controller
2018-10-05 18:03:31 +02:00
Johannes Rieken
148931476b
more promise removal
2018-10-05 11:38:11 +02:00
Matt Bierner
1bf1bc2c0e
Use async/await in tests
2018-10-04 13:27:17 -07:00
Matt Bierner
1e5a57279a
Removing or marking unused parameters
2018-10-03 17:26:47 -07:00
Matt Bierner
f7456ebf90
Switch to use standard @types/node types instead of our customized version
...
Using a custom version of the node typings is causing a lot of pain while trying to upgrade our build to use `@types` instead of the `d.ts` files we have to maintain. I believe we primarily maintain our own version for two reason:
- Custom require function
- setTimeout and other timer functions return NodeJs.timer instead of a number
These can both be delt with, the first by using interface augmentation and the second by switching to use any types for timer. I believe that the pain of maintaining our own node `d.ts` outweighs the benefits here
This change switches us to use the standard @types/node package for our node typings
2018-10-03 14:18:36 -07:00
Johannes Rieken
427663d35f
debt - less TPromise usage
2018-10-03 11:59:43 +02:00
Sandeep Somavarapu
90171dab97
#53526 Use Promise
2018-10-03 09:20:21 +02:00
Matt Bierner
be38e56996
Remove duplicate blank lines at the start of some files
2018-10-02 16:28:19 -07:00
Matt Bierner
d4edb9abcc
Remove use strict directives in main VS Code src (part 3)
...
We compile using the alwaysStrict flag so these directives are not needed.
This part removes most of the remaining use strict directives that were not caught by part 1 and 2
2018-10-02 16:14:11 -07:00
Matt Bierner
8087b0a8d8
Remove use strict directives in main vs code ts files (part 2)
...
We compile using the alwaysStrict flag so these directives are not needed
This part removes most `use strict` directives that are right after the file header
2018-10-02 16:11:05 -07:00
Matt Bierner
c63c97c128
Remove use strict directives in main vs code ts files
...
We compile using the alwaysStrict flag so these directives are not needed
2018-10-02 16:05:44 -07:00
Matt Bierner
7ebea5fba0
Remove "use strict" directives in tests
...
We set alwaysStrict so this directive is not needed
2018-10-02 15:59:35 -07:00
Ramya Achutha Rao
de6064c90a
Allow copying text from parameter hint widget
2018-10-02 15:48:29 -07:00
Johannes Rieken
0fb324496a
make sure ensureLowerCaseVariants has been called
2018-10-02 21:04:47 +02:00
Johannes Rieken
63d6fcf8f3
better fix for test
2018-10-02 21:02:00 +02:00
Johannes Rieken
a161d235bc
fix tests
2018-10-02 20:42:57 +02:00
Matt Bierner
7e87d06a4a
Skip failing test
2018-10-02 11:40:50 -07:00
Matt Bierner
e6454e6cbc
Add workaround some completions unit tests failing with null access exceptions
2018-10-02 11:36:38 -07:00