Commit Graph

83 Commits

Author SHA1 Message Date
Benjamin Pasero a7da0430da let execPath be a property of IEnvironmentService 2016-08-17 13:38:48 +02:00
Benjamin Pasero dffbeac1f6 use execPath from remote (node => electron-browser) 2016-08-17 13:13:09 +02:00
Isidor Nikolic 30c71c5d85 Merge pull request #9966 from Meai1/patch-3
Check if adapter is null and let it print errors
2016-08-03 23:16:45 +02:00
Meai1 39891e39b6 Update debugConfigurationManager.ts 2016-08-03 22:00:48 +02:00
isidor ac630b9b38 debug: import linting 2016-08-03 10:31:26 +02:00
Meai1 11e16d7c64 Update debugConfigurationManager.ts 2016-07-30 06:43:53 +02:00
Meai1 a0e4873558 Check if adapter is null and let it print errors
I had entire sections in the package.json missing and the errors I was getting were not helpful at all, it just said "e.adapter.variables undefined". Well it's undefined because the adapter is null!
If we work around that null we can get actually helpful messages here.
2016-07-30 06:23:01 +02:00
Martin Aeschlimann c72f6120a3 Fixes #9845: Do not give me word proposals when an object child has good proposals 2016-07-27 15:45:36 +02:00
isidor c818d1b81e debug: fix substituting command variables inside objects
fixes #8980
2016-07-22 15:48:59 +02:00
isidor 082cfeee65 debug: introduce breakpoints extension point
fixes #9037
2016-07-20 11:48:32 +02:00
Isidor Nikolic 971ed279d8 Merge pull request #8784 from DonJayamanne/replaceSettingsInDebugger
replace settings variables in debugger config #8042
2016-07-19 09:46:32 +02:00
Benjamin Pasero b2b2cb0f49 var => let/const 2016-07-15 09:54:35 +02:00
Don Jayamanne a81902c6ce reolved code review comments #8042 2016-07-11 08:39:29 +10:00
Don Jayamanne b8c4a030be changes to resolve code review issues #8042 2016-07-08 20:45:36 +10:00
Johannes Rieken 3f9f7514a5 command - move IKeybindingService#executeCommand to ICommandService 2016-07-07 11:13:45 +02:00
Johannes Rieken 1920059e45 rename index file 'keybindingService' to 'keybinding' such that it is aligned with the rest 2016-07-06 16:43:01 +02:00
isidor 79bdfd4a2d launch.json and tasks.json pin only if config file is created
#8727
2016-07-05 15:35:31 +02:00
isidor 6a6ca03f3e debug: variable substitution shouuld not replace full content
fixes #8378
2016-07-05 09:51:18 +02:00
isidor 89b39bd58d debug: resolve interactive variables inside objects
fixes #8288
2016-06-29 11:46:38 +02:00
Don Jayamanne 09f19a9212 reverted changes made to #8042, inadverted checkin (need to create a pull request instead) 2016-06-28 23:10:30 +10:00
Don Jayamanne d452f8d217 changes to replace settings variables in launch config #8042 2016-06-28 23:04:30 +10:00
Martin Aeschlimann e228769042 Polish configuration section labels & add link 2016-06-27 18:37:04 +02:00
isidor d20416e230 debug: change prefix of action variables to 'command'
fixes #7738
2016-06-16 12:48:40 +02:00
isidor 5a8c502f5a debug: workaround to open viewlet no longer needed 2016-06-14 11:22:56 +02:00
xzper 87a291d671 Debug: Fix setConfiguration error when name is null or undefined 2016-06-14 09:47:35 +08:00
isidor 32d68560c7 On first launch.json creation open debug viewlet
fixes #7291
2016-06-13 16:12:08 +02:00
isidor 39317f66e0 debug: whitespace formating 2016-06-03 11:43:43 +02:00
isidor fbec8996f7 debug: if an action variable is used multiple times in a launch config, the associated command should only be run once
#7026
2016-06-02 19:22:27 +02:00
isidor c8dc06b7dc debug: null guard 2016-06-02 15:04:31 +02:00
isidor 6aa2de7e8a Operating System Specific Properties in launch.json
fixes #1873
2016-06-02 12:31:41 +02:00
isidor c4e16ffc43 debug: null guard 2016-06-01 12:17:20 +02:00
isidor 02970ec581 debug: only convert strings in configuration 2016-06-01 11:06:10 +02:00
isidor ca44a14ad7 debug: abort debug session if interactive variable not picked
#7026
2016-06-01 10:25:10 +02:00
isidor 2c3910a342 debug: reslove interactive variables in sequence 2016-06-01 00:32:35 +02:00
isidor 9be55ebb81 debug: shorten comment 2016-06-01 00:03:31 +02:00
isidor ef617ddddd Support interactive variables in launch configurations
fixes #7026
2016-06-01 00:00:03 +02:00
isidor bac909403b debug adapter: add interactive variables as a field to package.json 2016-05-31 23:52:33 +02:00
isidor 63507b7ecc fixes #6809 2016-05-25 11:54:29 +02:00
isidor 559f650500 debug: set configuration properly when being passed by api
fixes #6806
fixes #6808
2016-05-24 17:26:53 +02:00
isidor bb9d5dd3df debug: additional telemetry data on debug session start
fixes microsoft/vscode-distro#35
2016-05-20 18:01:31 +02:00
Alex Dima e9b3e0ae92 Rename model.getAssociatedResource() to model.uri 2016-05-20 12:18:10 +02:00
isidor 1ef6a7093f debug: allow vscode.startDebug to pass full json config
fixes #4615
2016-05-10 18:06:47 +02:00
Benjamin Pasero b7ed8faad1 Merge pull request #5527 from outcoldman/respect_spaces_and_tabs_for_json_configuration_files
Create new conf files with right indent settings (fixes #5550)
2016-04-21 16:18:08 +01:00
Denis Gladkikh e63b4731ef Fix issues with getting settings 2016-04-21 05:17:39 -07:00
Martin Aeschlimann 519d618371 Remove addSchemaFileAssociation (was only used by legacy JSON mode) 2016-04-20 11:03:48 +02:00
Denis Gladkikh 0a4e82fbbd Create new conf files with right indent settings
If you are prefer to use spaces instead of tabs - in most cases you
don't want to see tabs anywhere (copy paste issues with other files).

This fixes several workflows:

- Creating new Debug file
- Creating new Tasks file
- Showing global settings (this one is cached, so it shows for the first
  time only right indentation, if you will change it will show old
  indentation till restart)
2016-04-19 21:01:50 -07:00
isidor dd7801f8d4 debug debt: make service interface slimmer, introduce IConfigurationManager 2016-04-18 15:38:17 +02:00
Benjamin Pasero 31ce12f023 Investigate to make IConfigurationService sync if already blocking startup (fixes #4264) 2016-04-01 11:41:16 +02:00
isidor a6ae23afc2 debug: make 'type' case insensitive
fixes #4563
2016-03-24 14:45:37 +01:00
isidor 4042b2bb63 fixes #3511 2016-03-07 11:06:45 +01:00