Commit Graph

1776 Commits

Author SHA1 Message Date
Benjamin Pasero 7d2083ed1d tests - allow to run our tests in chrome or msedge (#244969) 2025-03-28 08:17:16 -07:00
Alex Dima c36caf1bf7 EditorSimpleWorker -> EditorWebWorker 2025-03-21 10:13:39 +01:00
Alex Dima 46035d0296 Split up the editor's worker and the editor worker helper scripts, remove AMD support 2025-03-20 18:37:55 +01:00
João Moreno 6151dca574 remove watch module (#243208) 2025-03-11 16:21:23 +00:00
Daniel Imms d750544dc3 Fix shell integration smoke test flake
The problem was caused by zsh being out of date causing the shell
initialized check to not work properly as the prompt was delayed after
that.

Fixes #242739
2025-03-10 06:02:42 -07:00
Aaron Munger 469d54e912 call the generator function (#242912)
call the function

Co-authored-by: amunger <>
2025-03-07 10:54:22 -08:00
Aiday Marlen Kyzy fa548237be Adding acceptance condition to dispatchKeybinding in smoketests (#242570)
* adding code for smoke tests

* adding awaits

* changing wait code

* renaming dispatch to send

* moving comment

* update to send
2025-03-05 11:38:48 +01:00
Raymond Zhao 54b12e5ec8 Copy UUID impl (#231347) 2025-03-03 09:29:59 -08:00
João Moreno ae43cc72b6 make unit tests faster (#241847) 2025-02-25 15:18:20 +01:00
Alex Ross cf46a56bd4 Disable changes "workbench.action.toggleSidebarPosition" command key binding and verifies it (#239820) 2025-02-06 09:18:24 -08:00
Oleg Solomko 1195e2cf77 fix the the the typos (#239646)
fix the `the the` -> `the` typos
2025-02-04 15:35:23 -08:00
Aiday Marlen Kyzy 060de16f9d Directly accepting editor selection when using text area edit context (#239211)
* allowing two offsets

* changing to true
2025-01-30 14:53:12 +00:00
Aiday Marlen Kyzy 4b2a52e942 Fixing smoketests, using different selection offsets depending on product quality (#239108)
fixing smoketests, using different selection offsets
2025-01-29 16:53:18 +01:00
Benjamin Pasero 5e667f741b smoke tests - run with snapshots: true for tests that install extensions (#238855) 2025-01-27 17:30:59 +01:00
Johannes d96ee375ea fix tests 2025-01-24 08:46:16 +01:00
João Moreno 6cd86f433d fix flakiness in extension smoke tests (#238537) 2025-01-23 10:23:39 +01:00
Aiday Marlen Kyzy 3ff1dceedf Enable edit context (#237497)
* Revert "Revert Enablement of EditContext on Insiders (#235062)"

This reverts commit 45385e1c6f.

* adding product import

* adding som code

* removing console logs

* make sure editor selection is observed after keybinding dispatches

Co-authored-with: Aiday Mar <amarlenkyzy@microsoft.com>

* removing empty lines

---------

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2025-01-13 09:47:32 +01:00
Aiday Marlen Kyzy be5c64a3df Revert "Enable edit context" (#237468)
Revert "Enable edit context (#235386)"

This reverts commit 3958e26f65.
2025-01-08 11:43:30 +01:00
Aiday Marlen Kyzy 3958e26f65 Enable edit context (#235386)
* Revert "Revert Enablement of EditContext on Insiders (#235062)"

This reverts commit 45385e1c6f.

* adding product import
2025-01-07 10:00:03 +01:00
Johannes Rieken 17f6bcb7d2 chore - modernise test runner (#235511)
async/wait, remove AMD/ESM split, cleanup
2024-12-06 18:53:29 +01:00
Aiday Marlen Kyzy 45385e1c6f Revert Enablement of EditContext on Insiders (#235062)
Revert "Reenabling EditContext by default on Insiders (#234888)"

This reverts commit a47f407e38.
2024-12-03 08:37:57 +01:00
Aiday Marlen Kyzy a47f407e38 Reenabling EditContext by default on Insiders (#234888)
Revert "Revert "Smoke test failure - changing selectors depending on app qual…"

This reverts commit b8d5339e04.
2024-11-29 11:49:50 +01:00
Johannes Rieken 1994ebabef tweak inline chat hint (#234821)
* make editor readonly and disable squiggle while inline chat shows reply

https://github.com/microsoft/vscode/issues/226160

* tweak inline chat hint

only show on intented empty lines, hide when command run

* fix tests (only disable squiggle, not readonlyness)
2024-11-28 12:58:47 +01:00
Johannes Rieken e45ebc6d59 fail tests when having unhandled errors (#234673) 2024-11-26 08:32:08 -08:00
Aiday Marlen Kyzy b8d5339e04 Revert "Smoke test failure - changing selectors depending on app quality" (#234638)
Revert "Smoke test failure - changing selectors depending on app quality (#23…"

This reverts commit b69589ce38.
2024-11-26 09:17:31 +01:00
Aiday Marlen Kyzy b69589ce38 Smoke test failure - changing selectors depending on app quality (#234181)
* changing selector depending on app quality smoke test

* using correct selector

* resetting to just insiders

* focusing if not focused after event

* removing dom node focus
2024-11-21 11:58:33 +01:00
Aiday Marlen Kyzy 8d1d1373cd Reverting EditContext changes (#234247)
reverting changes
2024-11-20 10:18:20 +01:00
Aiday Marlen Kyzy d649101bec Turning on experimental edit context on Insiders (#234071)
* turning on experimental edit context on insiders

* fixing smoke test

* resetting the search input to use the textarea
2024-11-19 10:19:00 +01:00
Robo e178455531 ci: check for clean git state in npm validation (#230479) 2024-10-04 11:04:18 -07:00
Benjamin Pasero c5b6ef14e6 esm - more cleanup (#230285) 2024-10-02 11:55:17 +02:00
Benjamin Pasero f09184ceb7 esm - set type: module top level (#230210) 2024-10-01 20:48:56 +02:00
Benjamin Pasero 3b68a06818 esm - removal of CSS loader (#230206) 2024-10-01 19:24:18 +02:00
Benjamin Pasero 332b89f198 esm - remove AMD build scripts, tests and variables 2024-09-27 08:04:01 +02:00
Benjamin Pasero 789c320a1c Replace mkdirp with fs.mkdirSync(path, { recursive: true }) (#228017)
* Replace mkdirp with fs.mkdirSync(path, { recursive: true })
(fix #227931)

* compile
2024-09-09 22:43:29 -07:00
dependabot[bot] 2a4d7851ef Bump pathval from 1.1.0 to 1.1.1 in /test/monaco (#227783)
Bumps [pathval](https://github.com/chaijs/pathval) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/chaijs/pathval/releases)
- [Changelog](https://github.com/chaijs/pathval/blob/master/CHANGELOG.md)
- [Commits](https://github.com/chaijs/pathval/compare/v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: pathval
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-07 11:43:31 +09:00
Robo b5a6aa14a8 feat: switch to npm as default package manager (#226927)
* feat: move from yarn to npm

* chore: skip yarn.lock files

* fix: playwright download

* chore: fix compile and hygiene

* chore: bump vsce@2.17.0

Refs https://github.com/microsoft/vscode-vsce/commit/8b49e9dfdf909ad3af2b9ec9c825f5b501f6d75e

* test: update results for bat and sh colorizer tests

* fix: add missing lock files for windows

* fix: switch to legacy-peer-deps

* chore: update markdown-it@14.1.0

Refs https://github.com/markdown-it/markdown-it/commit/737c95a12976357df99652e4b51d831cac4a75aa

esbuild step in extensions-ci-pr was previously using markdown-it
from root which had userland punycode and was able to compile successfully.

* ci: increase pr timeout for windows integration tests

* chore: fix product build

* build: ignore extension dev dependency for rcedit

* build: fix working directory inside container

* build: fix dependency generation

* npm: update dependencies

* ci: use global npmrc

* ci: update cache

* ci: setup global npmrc for private npm auth

* build: fix extension bundling

* chore: sync npm dependencies

* ci: debug env variables for container

* ci: fix win32 cli pipeline

* build: fix npmrc config usage for build/ and remote/ dirs

* fix: windows build

* fix: container builds

* fix: markdown-language-features tests and bundling

```
[03:58:22] Error: Command failed: /Users/demohan/.nvm/versions/node/v20.15.1/bin/node /Users/demohan/github/vscode/extensions/markdown-language-features/esbuild-notebook.js --outputRoot /Users/demohan/github/vscode/.build/extensions/markdown-language-features
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds userland package based on https://github.com/markdown-it/markdown-it/commit/beed9aee2c1b44819afc25d485e86a6c699b6ef0

* fix: container builds for distro

* chore: update yarn occurrences

* fixup! chore: bump vsce@2.17.0

Uses the closest version to `main` branch that does not
include https://github.com/microsoft/vscode-vsce/commit/d3cc84cdec99b8e9f24be63d1a2a54abe908f68b
while still having the fix https://github.com/microsoft/vscode-vsce/commit/8b49e9dfdf909ad3af2b9ec9c825f5b501f6d75e

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: throw error when yarn is used for installation

* chore: add review feedback

* chore: switch exec => run where needed

* chore: npm sync dependencies

* fix: markdown-language-features bundling

```
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds missing userland package based on markdown-it/markdown-it@beed9ae,
can be removed once we update markdown-it >= 14.1.0

* ci: rename no-yarn-lock-changes.yml

* chore: sync npm dependencies

* ci: restore no-yarn-lock-changes.yml

We can disable it in a separate PR to keep the required
checks happy and also need workflow edit perms.

* chore: sync npm dependencies

* ci: rebuild cache

* ci: fix no-package-lock-changes.yml

* chore: bump distro

* chore: rm yarn.lock files

* chore: rm yarn.lock files without dependencies

* chore: add vscode-selfhost-import-aid to postinstall dirs

* chore: bump distro
2024-09-06 22:18:02 +09:00
Sandeep Somavarapu ebc02af2d8 rename electron-node to electron-utility (#227672) 2024-09-05 00:49:23 -07:00
Sandeep Somavarapu 01fcf004a6 Use electron net directly in shared process (#227553)
* Use electron net directly in shared process

* add built file

* introduce shared electron-node layer

* remove electron-utility layer

* fix (overlook): move back cli files to node
2024-09-04 07:26:43 -07:00
Connor Peet f9877b1978 eng: re-add coverage support post-ESM (#227459)
Fixes #227432
2024-09-03 20:33:56 +02:00
Benjamin Pasero d60295dc0e ESM: revisit need for _VSCODE_NODE_MODULES (fix #226453) (#227427) 2024-09-03 15:18:08 +02:00
Benjamin Pasero ca42f649a7 Allow to build an AMD version of VS Code (#227240) 2024-09-02 09:36:19 +02:00
Benjamin Pasero f0417069c6 esm - restore lost changes in tests from migration (#227225) 2024-08-30 09:12:48 -07:00
Benjamin Pasero 6b924c5152 ESM merge to main (#227184)
Co-authored-by: Johannes Rieken <jrieken@microsoft.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-08-30 10:31:46 +02:00
Benjamin Pasero 9f04aaf6f4 tests - depend on a test preload.js (#226588) 2024-08-26 10:14:27 +02:00
Alexandru Dima 4e0de3a8f4 Move workbench workers off EditorWorker (#225796)
* Add support for having channels in SimpleWorker

* Extract text model syncing code to a separate file

* Use a channel to do text model syncing for the language detection worker

* Simplify code

* Remove unused method

* Move OutputLinkComputer worker off editor worker

* Move TextMateTokenizationWorker off editor worker

* Simplify code

* Adopt channels for the host object

* More adopting channels for the host object

* More adopting channels for the host object

* More adopting channels for the host object

* Remove host object support from SimpleWorker

* Use the IEditorWorkerService, avoid starting a separate worker

* Bring the amd module id, the esm location and the worker label in a single type

* Improve typings

* SImplify worker creation pattern

* Enforce that all proxied methods start with `$` or `on`

* Adopt native proxy support

* Simplify code

* Simplify code

* Reintroduce a different standalone / workbench editor worker service
2024-08-20 14:00:18 +02:00
Benjamin Pasero 48bf32d320 esm - fix browser tests to run (#225791) 2024-08-16 17:13:07 +02:00
Benjamin Pasero 02fcc994ac esm - port over unit test changes (#225711) 2024-08-15 19:58:52 +02:00
Benjamin Pasero fdc8d882e2 esm - backport worker related changes (#225672) 2024-08-15 13:46:45 +02:00
Connor Peet 7dde0a7943 eng: fix --run path in electron tests not working (#225422)
I assume this broke with some of the ESM work, but I have no idea how it was working before. This should be a better fix.
2024-08-12 18:58:54 +02:00
Robo 00427fda20 chore: update electron@30.3.1 (#225106)
* chore: update electron@30.3.1

* temp: update distro

* chore: update node.js builds

* temp: update distro

* temp: revert node-pty

* Revert "temp: revert node-pty"

This reverts commit e834f75959ffd0078708db764457e05ec0f3b6b6.

* temp: test with oss electron

* chore: update node.js checksums

* Revert "temp: test with oss electron"

This reverts commit 18506aaa82b2cf44e4b5780eac1b929bbf98ac11.

* temp: disable sandbox for smoke tests

* Revert "temp: disable sandbox for smoke tests"

This reverts commit 8596ef5fcc776cc9a14b4546f9e448ccba2acbad.

* test: skip icon validation task smoke tests

* chore: bump distro
2024-08-09 23:44:42 +00:00