Commit Graph

2844 Commits

Author SHA1 Message Date
Rachel Macfarlane
9623b3441d Add setting to control when comments panel opens (#64941) 2018-12-13 16:34:31 -08:00
Matt Bierner
d40fa4a27e Review uses of Promise.resolve(null)
Many `Promise.resolve(null)` should actually be `Promise.resolve(void 0)`. In other cases, we were missing a null return annotation.
2018-12-13 15:41:13 -08:00
Matt Bierner
68a4e01246 Use resolve(void 0) instead of resolve(null) for void promises
Fixes a common type error
2018-12-13 15:20:46 -08:00
Daniel Imms
e6254db320 Recreate pid promise when reusing terminals 2018-12-13 10:02:17 -08:00
Daniel Imms
461bf7207b Merge remote-tracking branch 'origin/master' into pr/g-arjones/60111 2018-12-13 09:33:42 -08:00
Daniel Imms
e7102b1824 Send terminal name with id when it's ready
Fixes #64390
2018-12-13 08:07:55 -08:00
Dirk Baeumer
51f7beb40c Fixes #64918: Remove old task conversion code 2018-12-13 14:45:51 +01:00
Alex Dima
e2a42ca321 Change extension point registration to use a descriptor object 2018-12-13 13:39:39 +01:00
Johannes Rieken
c6c7edaa9f debt - asThenable -> asPromise because it returns a promise 2018-12-13 11:45:48 +01:00
Johannes Rieken
653280d133 debt - Thenable -> Promise 2018-12-13 11:31:54 +01:00
Alex Dima
29dd4e77de Keep track of activating extensions 2018-12-13 11:22:26 +01:00
Benjamin Pasero
227fd6634b fix #64597 2018-12-12 08:00:50 +01:00
Matt Bierner
0b1d0da7af Prefer to use .then(void 0, ..) over .then(null, ..)
ES6 promises like using undefined as their first argument instead of null. Both should behave the same behavior
2018-12-11 21:59:32 -08:00
Johannes Rieken
48a452dcee towards strict null and completion model, #63454 2018-12-11 17:00:19 +01:00
Joao Moreno
408e03220c event namespace consolidation & docs 2018-12-11 10:14:38 +01:00
Matt Bierner
100adeb3e9 Use more generic word pattern for markdown
Try to better support handle of unicode in markdown by using a word definition that use unicode character class

Fixes #15177
2018-12-10 18:24:10 -08:00
Benjamin Pasero
0bcf5cff8a Update to Electron 3.0.10 (#56149)
* update to 3.0.0-beta.3

* update d.ts files; rename NodeBuffer => Buffer

* update to 3.0.0-beta.4

* undo invalid change

* remove some Electron 2.0.x specific workarounds

* pinch zoom is now disabled by default

* update vscode-nsfw

* change vscode-nsfw

* update smoke test electron version

* streams: use destroy() over close()

* workaround broken tests

* bump distro and OSS

* try to bump node version for build

* update macOS build to use node.js 10.8.0

* fix extension tests

* use node.js 10.2.1 for all builds

* remove nsfw from dev dependencies

* back to node 8.x for build

* Revert "back to node 8.x for build"

This reverts commit 90ea2b7af2.

* update distro

* disable test run on macOS prod build for now

* bump distro

* ensure proper nsfw dep

* fix more native dependencies

* temp disable failing test

* fix packages

* update deps

* fix deps

* update deps

* enable macOS unit tests again

* fix deprecated buffer use

* Electron 3.0.0.beta.5

* bump deps

* fix tree accidentally treating auxclick as click

* improve overlay cleanup scheduler (fixes flicker seen with Electron 3.0.x)

* update distro

* remove obsolete disableBlinkFeatures: 'Auxclick'

* update to Electron 3.0 beta 6

* fix compile

* workaround #56994

* do not use backgroundColor to find shared process (causes flicker)

* fix flicker on windows from shared process background color

* webview - bubble up keyboard events (workaround for #56988)

* bump electron to 3.0.0-beta.8

* webview - fix deprecation

* webview - fix another deprecation

* debt - handle SIGPIPE on more processes

* workaround more webview focus issues (for #56988)

* webview - use proper way to focus()

* debt - avoid window-focus/blur and use native focus events instead

* webview - restore previous focus method

* webview - improve focus tracking (do not rely on DOM events)

* bump to electron 3.0.0-beta.9

* update deps

* update electron@3.0.0-beta.10

* webview - do not rely on DOM focus for certain commands (for #56988)

* update to electron@3.0.0-beta.11

* electron@3.0.0-beta.12

* update to beta 13

* update to electron 3.0.0

* update to Electron 3.0.1

* electron@3.0.2

* revert build changes (node.js version)

* try with: enable mojave dark mode support

* fix types

* electron 3.0.3

* electron@3.0.4

* fix deps

* bump electron@3.0.6

* bump electron@3.0.9

* fix strict null issue

* reset format

* bump electron@3.0.10

* fix strict null issue

* webview - print error when revive fails

* electron 3.0.x - try to fix keybindings in webviews (#64417)

* bump @types/node => ^10.12.12

* 💄

* update distro
2018-12-10 12:54:38 +01:00
Joao Moreno
65a420e359 remove TPromise
related to #64596
2018-12-10 11:40:28 +01:00
Matt Bierner
0928a6d348 Prefer coalesce over filter
Coalesce has the correct return type of `T[]`. Filter may return `(T | undefined)[]`
2018-12-07 16:32:45 -08:00
Matt Bierner
e2cf8ebc5d Enable strictBindCallApply for VS Code
Fixes #64633
2018-12-07 14:25:14 -08:00
Rob Lourens
9be224980c Make LogLevel converters safer and consistent with other converters, from @jrieken feedback 2018-12-06 11:02:09 -08:00
Rob Lourens
514217add5 Fix #64273 - EH log levels start at 1 2018-12-05 13:29:38 -08:00
Joao Moreno
ec0c9f22e9 fixes #25281 2018-12-05 15:48:11 +01:00
Rob Lourens
6f9b2d7593 Fix #59922 - changes needed to support a cache in a FileSearchProvider 2018-12-03 16:19:37 -08:00
Matt Bierner
64117e8fb5 Rename TriggerReason -> TriggerKind
Fixes #64216
2018-12-03 13:53:53 -08:00
Johannes Rieken
3bb5ce5d52 remove sample function proposed api 2018-12-03 18:14:43 +01:00
Joao Moreno
a8b004a30e fixes #62629 2018-12-03 15:15:37 +01:00
Johannes Rieken
daae50ab21 ensure a range contains its previous range, #63935 2018-12-03 12:05:50 +01:00
Johannes Rieken
2baa14fcf2 tests and api command for smart select api, #63935 2018-12-03 11:51:53 +01:00
Johannes Rieken
07be58bbad add proposed api for smart select, #63935 2018-12-03 11:29:12 +01:00
Alex Ross
f9703e9ad6 Input variables in tasks (#63910)
Fixes #4758
2018-12-03 09:24:59 +01:00
Johannes Rieken
253a4f6d17 log provider failure as errors, #63831 2018-12-03 08:47:39 +01:00
Matt Bierner
9d5987b0f7 Type objects.assign
Use similar typings to `Object.assign`
2018-11-30 16:44:42 -08:00
Alex Dima
aa3ea85b0a Explorations 2018-11-30 15:54:40 +01:00
Alex Ross
e16c62b315 Move rerun behavior api out of proposed (#63511)
Fixes #62789
2018-11-30 15:31:13 +01:00
Andre Weinand
f168d88224 final tracker API; for #62843 2018-11-30 15:17:40 +01:00
Johannes Rieken
5637f24b29 uri tweaks in md strings 2018-11-30 11:45:13 +01:00
Alex Ross
eaee631826 Merge branch 'master' of https://github.com/Microsoft/vscode 2018-11-30 11:17:59 +01:00
Alex Ross
298a36714f Global tasks don't need a workspace root
Fixes #63951
2018-11-30 11:17:41 +01:00
Sandeep Somavarapu
34b655147e - Remove proposed api check for collpaseAll
- Add proposed api check for treeview message and globalStorage
2018-11-30 10:48:11 +01:00
rebornix
9eb6d908e3 remove unused method 2018-11-29 10:38:42 -08:00
rebornix
52811a3a48 Merge remote-tracking branch 'origin/master' into rebornix/commentsgrouping 2018-11-29 10:33:39 -08:00
rebornix
e877e5c820 comment thread can be updated by draft mode change. 2018-11-29 10:27:27 -08:00
Benjamin Pasero
94315b8636 lifecycle - introduce onShutdown event for disposing things after onWillShutdown 2018-11-29 08:55:56 +01:00
rebornix
8d78edddaa render pending comment 2018-11-28 16:05:16 -08:00
Sandeep Somavarapu
37037eac8a #23251 Expose global storage path in proposed API 2018-11-28 16:33:59 +01:00
rebornix
11d48f122e first cut 2018-11-27 16:02:39 -08:00
Andre Weinand
4201f517b1 finalize DebugAdapterDescriptorFactory API: fixes #62977 2018-11-26 23:54:30 +01:00
Daniel Imms
daf4deaf0c Terminal process request improvements 2018-11-26 14:42:35 -08:00
Andre Weinand
8780c7b4f8 finalize DA & Tracker Debug APIs 2018-11-25 16:29:00 +01:00