Commit Graph

66 Commits

Author SHA1 Message Date
Johannes
295fd497cb Merge branch 'main' into joh/inlineChatEdits 2025-01-22 09:55:48 +01:00
Johannes Rieken
9b637ac69e remove chat.editing.alwaysSaveWithGeneratedChanges setting and things around it (#238447)
fyi @isidorn
2025-01-22 09:52:52 +01:00
Johannes
3aece83761 wip - inline chat via editing session 2025-01-22 09:13:23 +01:00
Johannes Rieken
5555f6604d inline hint for empty lines, right-click to hide, differentiate between empty line and suffix hint (#234773) 2024-11-27 09:08:40 -08:00
Johannes Rieken
eddef09fa7 renderer side inline hint and cmd to show/hide (#234421) 2024-11-22 15:36:09 +01:00
Joyce Er
8327a80a6c fix: Send and Dispatch should be Send in chat editing view (#233117) 2024-11-05 10:36:37 -08:00
Rob Lourens
50a2adc65b Cleanup chat context keys (#232515)
* Start renaming context keys

* vote

* detected agent

* More

* More

* chatEditApplied

* More

* More

* More

* Cleanup

* Cleanup
2024-10-29 11:55:16 -07:00
Johannes Rieken
ec1125c2d1 inline chat fixes (#229973)
* disposing the editor view should remove overflowing overlay widgets node

* use a suitable overflow widget dom node for the inline chat widget

fixes https://github.com/microsoft/vscode-internalbacklog/issues/4298

fixes (doesn't re-introduce) https://github.com/microsoft/vscode-copilot/issues/8701

* * make sure `ESC` first closes suggest before closing inline chat
* also remove duplicated action
2024-09-27 17:09:21 +02:00
David Dossett
a8cef90680 Update cancel request string 2024-09-12 10:47:35 -07:00
Johannes Rieken
6f3c714dbe removes inline chat content widget (#227224)
fixes https://github.com/microsoft/vscode/issues/227187
2024-08-30 16:59:56 +02:00
Benjamin Pasero
6b924c5152 ESM merge to main (#227184)
Co-authored-by: Johannes Rieken <jrieken@microsoft.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-08-30 10:31:46 +02:00
Johannes Rieken
eb2f7c1a35 add secondary inline chat menu and render response commands there (#226621)
fixes https://github.com/microsoft/vscode-copilot/issues/7368
fixes https://github.com/microsoft/vscode-copilot/issues/6650
2024-08-26 16:06:26 +02:00
Johannes Rieken
6f13ec62fc chore - inline chat work (#226139)
* chore - prepare inline chat to be started with an existing model that has edits

* debt - remove `SessionExchange` et al.

* Makes inline chat be entirely grounded in the chat model
* Removes the copy recordings command which never got used
2024-08-21 11:55:19 +02:00
Johannes Rieken
3b44b1102b fix https://github.com/microsoft/vscode-copilot/issues/7326 (#226065) 2024-08-20 16:23:56 +02:00
Johannes Rieken
6593979d4c improve action label for making an inline request (#225582)
use "Edit Code" when having a selection to operate on and "Generate" otherwise
2024-08-14 10:03:54 +02:00
Johannes Rieken
3218292d9d remove ExpTextButtons setting and logic but keep make buttons more dynamic (#225495) 2024-08-13 16:00:26 +02:00
Johannes Rieken
2811728ba1 first version of tab to trigger inline chat (#225475) 2024-08-13 10:42:41 +02:00
Megan Rogge
304c83e6c3 fix inline chat accessibility help (#223529)
fix #223333
2024-07-24 11:14:29 -07:00
Johannes Rieken
da06c08a32 Inline chat fixes and polish (#218398)
* react to changes of `inlineChat.experimental.textButtons` (no more window reload)

https://github.com/microsoft/vscode/issues/217845

* fix status label wrapping

* remove unused toolbar

* fix https://github.com/microsoft/vscode/issues/218395
2024-06-26 16:48:28 +02:00
Johannes Rieken
53c0b5ac53 Joh/mental-koi (#217004)
* hightlight first button only when inline chat has a prompt

* rename "Cancel Request" to "Stop Request"

* mark `inlineChat.experimental.textButtons` as experimental

* show all "input" command when not using text btns

* When cancelling, undo untill before the request
2024-06-24 13:06:53 +02:00
Johannes Rieken
d64446d9a2 filter send and cancel actions from execute toolbar (#216801)
* * fixes https://github.com/microsoft/vscode/issues/216692
* make text-btn with command but with a little color

* * don't show close/view-in-chat while request is in flight

* filter send and cancel actions from execute toolbar

fixes https://github.com/microsoft/vscode/issues/216772
2024-06-21 13:12:27 +02:00
Johannes Rieken
88d860624c Inline chat UI overhaul (#215927)
* don't dimiss inline chat content widget when already having typed something

https://github.com/microsoft/vscode-copilot/issues/6067

* extract `TextOnlyMenuEntryActionViewItem` for reuse

* remove unused variables

* * show chat input below request/response pairs
* setting for text-only buttons
* more dynamic buttons
* always show the first request, don't repopulate input with last message
* keep progress bar hidden, rely on "Generating..."
* no more special background color

* add `minimal` renderer style for chat renderings

* tweak font-size for details when render mode is minimal

* stable scroll position for inline chat, don't push down the lines chat is editing but push the inline chat upwards

* more buttons more compact, tweak labels

* * add missing service dependency
* repopulate input for some unit test

* allow output from `InteractiveChatController` suite
2024-06-17 11:26:21 +02:00
Johannes Rieken
3683ed7151 remove IInlineChatService and types around it (#213298) 2024-05-23 11:03:49 +02:00
Johannes Rieken
95ffd765e1 chore - remove dead/stale commands (#213207) 2024-05-22 09:07:35 +02:00
Johannes
dd05a6ff19 remove bridge agents and agent providers because inline chat is all participants now
* remove much of IInlineChatSessionProvider
* deprecate IInlineChatService and move most consumers off
2024-05-21 17:41:25 +02:00
Johannes Rieken
7680db2a11 Move rerun request back to prime spot, return with intent detection back as link (#212775)
* Bring back "Rerun Request" to its prominent spot

https://github.com/microsoft/vscode-copilot/issues/5604

* move rerun without gesture back into title

fixes https://github.com/microsoft/vscode-copilot/issues/5275
2024-05-15 09:31:04 +02:00
Megan Rogge
00bc1553ba create AccessibleViewRegistry, move all applicable views/accessibility help dialogs over to use it (#212138) 2024-05-07 05:48:04 +02:00
Johannes Rieken
7d04d4df43 only have one report bug command (#210802) 2024-04-20 01:34:57 +02:00
Johannes Rieken
ef6345ae05 Support for attempt and enableCommandDetection in chat model/service (#209826)
* add `IChatRequestModel#attempt` so that rerun request/response can be supported

* - support to run with/without command detection enabled
- adopt agent brigde to new chat request
- add share rerun-commands (but only enable them for inline chat for now)
2024-04-08 14:08:22 +02:00
Johannes
ebfbf27d8c - fix layout bugs
- enable terminal history with new world
- fix (most) command group associations
2024-03-21 11:58:28 +01:00
Johannes
95c009d7e1 make sure to start inline chat session service eagerly 2024-03-21 09:18:26 +01:00
Johannes
6931665097 - fix re-run and re-run with intent detection commands
- add support for tree-rendering detected command/agent in a special way
- first cut of tree-rendering for text edis
2024-03-20 12:38:04 +01:00
Johannes
e5385dac71 - use chat widget also for content widget (shared chat model)
- add TextEdits to chat model
- add IChatTextEdit and IChatUsedSlashCommand to chat progress types
-  hook up ad-hoc agent to inline chat session (no more custom commands)
- add new `State.SHOW_REQUEST` state for when new requests are made
2024-03-18 19:12:44 +01:00
Johannes
0ac95cc1b7 - use chat input part for content widget
- use chat widget over renderer-reuse and custom input
- allow to configure chat menus/actions
- allow to define filter for chat list/tree
2024-03-15 15:44:41 +01:00
Johannes Rieken
9626fb0cd2 Inline chat widget tweaks (#206954)
* make status menu configurable

https://github.com/microsoft/vscode/issues/206940

* pull inline chat zone widget into its own file

* 💄

* remove expand/crop feature

* make chat message contents scrollable
2024-03-06 12:51:50 +01:00
Johannes Rieken
7215958b3c add commands to navigate between hunks (#205293)
https://github.com/microsoft/vscode/issues/203349
2024-02-15 15:57:24 +01:00
Johannes Rieken
6aad7f2ec9 move StartSessionAction back to /browser/, add indirection for holdForSpeech-feature (#203890)
https://github.com/microsoft/vscode-copilot/issues/3857
2024-01-31 15:13:58 +01:00
Johannes Rieken
4217af7696 restore stashed sessions for when accidentially dismissing a session (#203006) 2024-01-22 14:31:23 +01:00
Johannes
bf53fde347 move browser things back so that services and dependents are registered properly 2024-01-17 12:30:40 +01:00
Johannes
481d7bb72d Use hold mode in start inline chat action to enable speech 2024-01-16 18:16:31 +01:00
Johannes Rieken
b8b5a4aad0 Move hunk computation into sessions, let strategies render them (#202578)
* chore - move chat session service implementation and interface into their own files

* chore - move chat saving service implementation and interface into their own files

* - move hunks into session (instead of strategy)
- recompute them after receiving AI changes
- accept& discard moves hunks from textModelN to textModel0 and vice versa
- service renames
- tests

* - session doesn't know about an editor, only service does
- allow to "move" session to a different editor
- let controller pickup session after move to its editor
- session saving picks up orphand sessions

* try to restore editors when group is still valid

* ctrl - don't pause when cancellation happens during session create

* fix tests
2024-01-16 14:50:19 +01:00
Johannes Rieken
02580fd00c Make sure AI generate code gets accepted/discarded before saving (#202347)
* add inline chat save logic that ensures AI generated changes are only saved after consent

* live - when cancelling don't undo until start version but revert changes

* add setting to control save participation

* fix typo

* stub new services, fixes tests
2024-01-12 16:29:12 +01:00
Johannes Rieken
77ca6ccd41 Joh/mysterious-octopus (#202079)
* debt - don't use extra buttons for accept/discard hunk

* - inline chat history shouldn't loop
- preserve the initial value and restore it

fixes https://github.com/microsoft/vscode-copilot-release/issues/671
2024-01-09 15:43:26 +01:00
Johannes Rieken
0bd31a85e4 Add inline chat toolbar for close and configure (#201200)
* add input widget toolbar, add close action

* * make "finish on typing" configurable and turn it off by default
* add configure action to widget toolbar

* fix tests
2023-12-19 15:19:11 +01:00
Johannes Rieken
054c9129f8 live3 becomes live (#200866) 2023-12-14 18:24:38 +01:00
Johannes Rieken
f6a6df7dd4 fix https://github.com/microsoft/vscode-copilot/issues/3143 (#200859) 2023-12-14 17:20:18 +01:00
Aiday Marlen Kyzy
8f81492eb2 removing the code for the gutter icon and the toolbar icon 2023-12-13 10:49:08 +01:00
Johannes Rieken
f54f1b0400 Further tweak light weight diff mode (#199148)
- Let message talk about changes not lines
- Move "Compare" into rhs toolbar as toogle action
2023-11-27 12:21:57 +01:00
rebornix
49eb796101 Resolve conflicts 2023-11-14 08:19:07 -08:00
rebornix
6dd6275d2a move off menu 2023-11-13 12:12:22 -08:00