Commit Graph

5 Commits

Author SHA1 Message Date
Johannes
c5af7e2424 fix & improve reporting of cyclic dependencies 2025-06-09 15:02:25 +02:00
Johannes
6bb8066506 fix tsb cyclic dependency check 2025-06-09 14:37:05 +02:00
Johannes Rieken
a40e594f25 Check for cyclic dependencies during compile (#235808)
* Check for cyclic dependencies during compile

Changes gulp-tsb to check the emitted JS code for cyclic dependencies. Historically we never cared about cycles between TS files as long as they dissappeared after compile (e.g type-dependencies, not runtime dependencies)

https://github.com/microsoft/vscode-internalbacklog/issues/5271

* fix cycling dependencies

fyi @aeschli @aiday-mar

* remove cyclic dependency with unused `BasedTextEdit` fyi @hediet

* remove cycle between chatEditService and chatEditingSession

fyi @alexdima

* remove cyclic dependency between chatSetup and chatViewPane

fyi @roblourens

* better cycle detection

* don't check cycles when not needed

* clear graph when reprocessing file dependencies

* remove cycle between with `notebookChatEditController` fyi @DonJayamanne

* modernize and cleanup tsb/utils
2024-12-11 11:26:59 +01:00
Johannes
0656d21d11 auto-fixed prefer-const violation 2022-06-08 17:49:21 +02:00
Johannes
c13d581bce move gulp-tsb into the build/lib remove as dependency 2022-05-05 11:35:33 +02:00