Commit Graph

80 Commits

Author SHA1 Message Date
Don Jayamanne
43957ccfe1 Compress streams in notebook outputs (#160946)
* Revert "Compress notebook output streams before rendering (#160667)"

This reverts commit 4230c22a08.

* Compress stream output items

* Minor perf improvements

* Misc

* Comments

* Added tests

* Merge issue

* More merge issues

* Misc

* Address code review comments
2022-10-11 14:43:46 -07:00
Matt Bierner
feb3d2d205 Fix null ref in attachments check (#162396)
Fixes #162391

Also reduces use of `any`
2022-09-29 13:15:01 -07:00
Peng Lyu
6e8bc02be4 Cell attachment cleanup tool improvement in diff editor (#161132)
* Move attachment out of custom metadata, prep for attachment clean up in diff editor

* recover attachments from dirty notebook document

* Allow metadata to be restored when content changed/reverted in nb diff editor
2022-09-16 14:12:53 -07:00
Don Jayamanne
4230c22a08 Compress notebook output streams before rendering (#160667)
* Compress notebook output streams before rendering

* OOps

* Combine the buffers manually

* Address code review

* oops

* Fixes

* We can have multiple stream mimes in an output

* oops
2022-09-13 08:56:32 +10:00
Michael Lively
42238bdaab notebook image cleaning automation (#159212)
* cache and cleaner complete, needs debounce

* minor renaming and reformatting

* bugfix for paste into new cell

* cleaning functionality complete

* refer to metadata as copy of current cell's

* check undef before reading from cache

* working state, pending cache restructure

* dots -> brackets

* pre-class refactor

* massive cleaner refactor

* cache typing, closed nb check, workspaceEdit only if metadata is changed

* undefined access fix

* proper debouncer

* get it up to work again

* no need to loop

* cell metadata uri parsing regression

* diagnostic

* Show diagnostics on document open

* transfer cache before file renames

* disable word wrap in notebook diff editor

* Avoid early notebook cell metadata deep clone

* No special case empty cell

* rename

* better naming

* Quick fix for invalid image attachment

* cleanup

* Add code action metadata

Co-authored-by: rebornix <penn.lv@gmail.com>
2022-09-09 11:32:10 -07:00
Michael Lively
834ad7365b small fix in logic 2022-08-31 15:41:15 -07:00
Michael Lively
05ae151b7d return object, change placeholder 2022-08-25 15:33:50 -07:00
Michael Lively
16f842ea76 fix for attachment naming within notebook metadata 2022-08-25 15:04:56 -07:00
Michael Lively
614c7dd5f4 fix conflict demo 2022-08-24 10:37:37 -07:00
Michael Lively
02cb45c3cb demo merge conflict 2022-08-23 16:10:56 -07:00
Michael Lively
ae1167bd94 refactor with updated metadata properties 2022-08-23 16:09:30 -07:00
Matt Bierner
f00fde0f24 Mark that notebook metadata is readonly (#158960)
Mark that metadata is `readonly`

Fixes #158955

We freeze the object here 0656d21d11/src/vs/workbench/api/common/extHostNotebookDocument.ts (L70)
2022-08-23 14:52:00 -07:00
Matt Bierner
b72671133b Fix any types and extract method (#158967)
`currentCell` and `notebookUri` are currently any types, which hides type errors. To fix this and clean up the code, I've extracted a new `getCellFromCellDocument` method
2022-08-23 13:57:44 -07:00
Michael Lively
6f7189b7bb refactor metadata into own fxn 2022-08-18 11:58:44 -07:00
Michael Lively
880fda6ed9 fix pasting image into newly created cell bug 2022-08-17 12:17:39 -07:00
Michael Lively
38477bf5f5 change dir of cellAttachmentRenderer (#157671)
* change dir of cellAttachmentRenderer

* add new directories to `.vscodeignore`

* add the .js directories back in...

* hopefully now understanding `.vscodeignore`
2022-08-09 20:00:24 +02:00
Michael Lively
9225503c85 Support for pasting images into markdown notebook cells (#156847)
* dataflow support for updated metadata

* update cellAttachmentRenderer.ts to reflect metadata being a getter() inside MarkupCell

* document paste additions

* update condition to re-render cells, now includes metadata changes

* paste API working, debugging command added

* paste working with metadata. needs numbering, and cleaning upon delete

* paste screenshot works fully

* remove debugging command. Cleaning.

* notebook cells now re-render upon metadata changes

* changed name validity checking, remove unneeded function

* use _document for cell data, use snippet choice, dto fix

* return subscription, for loop, uri fix, alter metadata in-place, better snippet

* metadata fix, object.equals, fix cellAttRenderer metadata call

* added comment with source of encodeBase64

* gate mkdn image paste behind experimental setting
2022-08-08 13:57:49 -07:00
Matt Bierner
68912bd844 Use 'import type' for '@jupyterlab/nbformat' (#157153)
This is a type only dev dep so we should prevent referencing it as a value
2022-08-04 23:46:53 +02:00
Michael Lively
61e8687fa3 Notebook Cells re-render upon changes to metadata (#156917)
* dataflow support for updated metadata

* update cellAttachmentRenderer.ts to reflect metadata being a getter() inside MarkupCell

* update condition to re-render cells, now includes metadata changes

* notebook cells now re-render upon metadata changes

* fix missing metadata update

Co-authored-by: Peng Lyu <penn.lv@gmail.com>
2022-08-03 09:46:12 -07:00
Michael Lively
6fbee10cc1 more checking for undefined objects, fixed bug casuing markdown renderer to entirely crash 2022-07-28 11:53:51 -07:00
Michael Lively
eaf321d50d formatting 2022-07-20 16:12:32 -07:00
Michael Lively
63142212a1 remove md-it dependency, added undefined check to attachments 2022-07-20 16:10:54 -07:00
Michael Lively
1b59f566bb rendering of attachment images complete via tokens 2022-07-20 12:23:37 -07:00
Michael Lively
735ead82f5 added attachment and metadata support back in... rebasing is scary 2022-07-20 12:23:37 -07:00
Michael Lively
0fa857c9a1 okay now things are actually fresh and working 2022-07-20 12:23:24 -07:00
Johannes
0656d21d11 auto-fixed prefer-const violation 2022-06-08 17:49:21 +02:00
Matt Bierner
c9c5990e38 Adopt notebookWorkspaceEdit proposal internally (#149778)
This switches us to use the new `notebookWorkspaceEdit` proposal instead of `notebookEditorEdit`
2022-05-17 18:51:25 -07:00
Johannes
b1faab40de adopt tests to new notebook change event 2022-03-29 11:58:54 +02:00
rebornix
157cba093c fix #140673. 2022-03-15 17:01:33 -07:00
rebornix
e632f91b35 fix #143966. 2022-03-02 16:55:55 -08:00
rebornix
998ee04a72 update nbformat typings 2022-03-01 12:59:58 -08:00
rebornix
3567a2f2bc Show codelens to ipynb json to open in notebook editor 2022-02-18 14:54:40 -08:00
rebornix
4b17d05668 re #142872. Contribute ipynb notebook to File -> New when no Jupyter extension enabled. 2022-02-16 11:42:45 -08:00
rebornix
8e3c41760e re #142872. Default language to python. 2022-02-16 11:42:45 -08:00
rebornix
7f99539fe7 re #142872. Ignore whitespace only content error. 2022-02-15 17:45:09 -08:00
Johannes Rieken
7ccb868835 make sure to use .eslintignore when running yarn eslint, this will ensure that cli failure and editor squiggles are always equal 2022-02-02 12:37:29 +01:00
Johannes Rieken
68e819043c use tsconfig.json#include for vscode.d.ts and vscode.proposed.d.ts, enables to remove most ref.d.ts-files 2021-11-09 15:53:35 +01:00
Johannes Rieken
9254a8cd27 move vscode.d.ts and vscode.proposed.d.ts into src/vscode-dts-folder, https://github.com/microsoft/vscode/issues/131165 2021-11-09 15:00:03 +01:00
Rob Lourens
3df135c388 Fix jupyter version number, #136544 2021-11-05 14:50:10 -07:00
Rob Lourens
29c5f2d394 Show an error when opening an old unsupported jupyter format
Fix #136544
2021-11-05 14:06:39 -07:00
Rob Lourens
a14ebdfec4 Remove inputCollapsed and outputCollapsed metadata, make them view properties
Fix #125274
2021-11-03 17:22:07 -07:00
Don Jayamanne
79a3586d6c Add cell_ids for ipynb with nbformat >= 4.5 (#134835) 2021-10-12 09:35:05 -07:00
Don Jayamanne
fd910caaf2 Support nbformat 4.5 2021-09-24 13:16:03 -07:00
Don Jayamanne
217e74508d add new line 2021-09-24 12:48:03 -07:00
Don Jayamanne
0bf3b221ca Fix unnecessary changes 2021-09-24 12:45:03 -07:00
Don Jayamanne
3e10e0c49b oops 2021-09-24 10:51:16 -07:00
Don Jayamanne
2f43876783 Ensure nb cell source uses LF instead of CRLF 2021-09-24 10:35:22 -07:00
Don Jayamanne
245fffbce1 Misc 2021-09-21 10:17:33 -07:00
Don Jayamanne
68ba13d07c Remove window keyword from serializer 2021-09-20 09:49:00 -07:00
Don Jayamanne
192e689be1 Fixes to image serializations 2021-09-16 16:27:44 -07:00