Commit Graph

476 Commits

Author SHA1 Message Date
Matt Bierner 1904cd8d84 Prototype auto fixable quick fixes
Part of #62110

- Adds a new field `canAutoApply` to code actions. This field indicates that a code action can be applied without additional user input. For quick fixes, this should be set if the fix properly addresses the error

- Enable auto fixes for TS spelling errors

- Added a `editor.action.autoFix` command to triggers auto fixes at the current cursor position
2019-01-16 17:56:22 -08:00
Matt Bierner 2ab82c12ed Make sure we opt in to new TS user preferences for enabling rename features
Fixes #66176
2019-01-11 15:42:03 -08:00
Matt Bierner adb4b04bfd Fix type error 2019-01-11 14:40:17 -08:00
Matt Bierner beef295f9a Normalize the TS server path in logged TS server errors 2019-01-11 14:23:29 -08:00
Matt Bierner e730375b7a Don't make semantic requests against the TS server when the languageService has been disabled 2019-01-11 14:23:29 -08:00
Matt Bierner 6682006c8b Use more explicit state for TS server states
Try to prevent the tracked server state from getting into weird invalid states and make the state more explicit
2019-01-11 14:23:29 -08:00
Matt Bierner 2f5d88899d Make NoContentResponse an constant instead of a class 2019-01-11 11:04:58 -08:00
Matt Bierner 60f232b246 Include TypeScript version in errors logged to dev tools
Fixes #66368
2019-01-11 11:04:58 -08:00
Matt Bierner 3da39a64dd Improve logging of TypeScript server errors
Fixes #66366
Fixes #66367

Avoid printing the error twice in the trace

Make sure we show helpful error information in the VS Code dev tools when a TS server error occurrs
2019-01-11 11:04:57 -08:00
Matt Bierner d2a8ca946f Use isCancellationRequested 2019-01-11 11:04:57 -08:00
Matt Bierner 66511a0bdb Interup geterror during rename
Rename is a user triggered operation and should interupt long run error computations
2019-01-11 11:04:57 -08:00
Matt Bierner 299997228d Don't include object key types in completeFunctionCalls
Fixes #66297
2019-01-09 11:52:02 -08:00
Matt Bierner e44801f2b3 Fix inserting of duplicate calls when using typescript.suggest.completeFunctionCalls
Fixes #18131
2019-01-08 16:25:07 -08:00
Matt Bierner f49c40947e Add test for completeFunctionCalls 2019-01-08 16:07:40 -08:00
Matt Bierner 6eeb11ecf2 Extract updateConfig 2019-01-08 15:53:11 -08:00
Matt Bierner d9e2246c9b Temporarily revert using word range for TS completions due to #66187 2019-01-07 17:49:58 -08:00
Matt Bierner 9d2787e42e Accepting a member completion should result in valid code
Fixes #58597

Default to replacing the word range in js/ts. This is a change in core behavior so  we'll need to see what the feedback is like for it.
2019-01-04 18:09:48 -08:00
Matt Bierner 7a4944fb64 Add pinning test for paren accept character on bracket completion 2019-01-04 18:08:17 -08:00
Matt Bierner 6494c1c513 Adding pinning test for function treating paren as commit character 2019-01-04 18:01:01 -08:00
Matt Bierner 24cb22200e Move wait to setup block 2019-01-04 17:33:08 -08:00
Matt Bierner 6366adf510 Add pinning test for period treated as bracket trigger character 2019-01-04 17:30:26 -08:00
Matt Bierner b166d5896f Add basic pinning test for commit character var completion 2019-01-04 16:56:42 -08:00
Matt Bierner 483adec7a5 Add simple pinning test for basic completion 2019-01-04 16:49:40 -08:00
Matt Bierner df2d0c0fee Add pinning test for #53962 2019-01-04 16:29:19 -08:00
Matt Bierner b4964bcf35 Replace some common index based for loops with for-of loops
Replaces many loops of the form:

```js
for (let i = 0; i < elements.length; ++i) {
    const i = elements[i];
   ...
}
```

with:

```js
for (const element of elements) {
    ...
}
```

Mix of a horrible regex based find/replace and manual touch ups
2019-01-03 19:11:18 -08:00
Matt Bierner 5cc00861fc Enable no-var-keyword tslint rule 2019-01-03 18:02:48 -08:00
Matt Bierner 3f8579f96a Avoid some common type casts
Casts can hide some type errors
2019-01-03 17:44:14 -08:00
Rob Lourens ef2547d547 replace void 0 with undefined 2019-01-03 11:20:19 -08:00
Matt Bierner 3e7bb120c7 Use label text indexes to mark active paramter for js/ts
Fixes #65513
2019-01-02 14:53:21 -08:00
Matt Bierner 44b5a77632 Use TS's document highlight API instead of references api to get highlights
Fixes #65921
Fixes #65051
2019-01-02 11:56:39 -08:00
Matt Bierner 494e5e8509 Fix bug for completing function name parameters if function name contained special snippet syntax 2018-12-23 22:22:38 -06:00
Matt Bierner 8ac2c23fdc Don't force convert fixable diagnostics to numbers
Fixes #64848 for the VS Code side
2018-12-14 14:57:37 -08:00
Matt Bierner 45c34a2c51 Remove extra Array.from 2018-12-14 14:57:37 -08:00
Matt Bierner 7632e0133e Use clear 2018-12-14 14:57:37 -08:00
Matt Bierner 83ce38f6de Make fixPathPrefixes a bit more resiliant 2018-12-14 14:57:36 -08:00
Prabhanjan S Koushik 0f5b2d14e7 Fix #64253 - Support ~/ paths for typescript.tsdk (#64892)
* fix-64253 Added fixPathPrefixes

* fix-64253 Removed  and handled ~/path
2018-12-14 14:18:24 -08:00
Matt Bierner a87dc2b62f Interup getError for refactor and updatePaths on rename
These are user triggered operations that should interupt the background getError requests
2018-12-14 13:48:53 -08:00
Matt Bierner d02be78457 Show progress during update JS/TS imports
Fixes #64986
2018-12-14 13:29:57 -08:00
Matt Bierner 90f36693c9 Extend disposable 2018-12-14 12:54:07 -08:00
Matt Bierner bb8fc43f72 Remove un-needed cast 2018-12-14 12:52:48 -08:00
Matt Bierner 6b89247875 Allow extension contributed TS plugins to be loaded for workspace versions of TS
Fixes #65031

Adds a `enableForWorkspaceTypeScriptVersions` flag (default false) to the plugins contributions that  allows a contributed plugin to be loaded for workspace versions of ts
2018-12-13 14:29:32 -08:00
Matt Bierner 5dc52f0617 Extract getCodeLensLabel 2018-12-12 18:07:37 -08:00
Matt Bierner 314b7d75a3 Use text icon for js text suggestions
Fixes #64777
2018-12-11 16:18:58 -08:00
Matt Bierner 7683decdb5 Adding more tests for cached response 2018-12-10 14:12:33 -08:00
Matt Bierner 2b7278c712 Adding better test case for not caching cancelled responses 2018-12-10 14:12:33 -08:00
Matt Bierner 68e0182064 Add test for not caching cancelled response 2018-12-10 14:12:33 -08:00
Matt Bierner 863aee78b6 Adding basic test for cached response 2018-12-10 14:12:33 -08:00
Matt Bierner aa990b4528 Don't cache cancelled ts server responses
Fixes #64649
2018-12-10 14:12:33 -08:00
Matt Bierner 8b4924d755 Build VS Code using TS 3.2
Fixes #64631
2018-12-07 14:25:14 -08:00
Matt Bierner a4bed89652 💄 2018-12-07 14:25:14 -08:00