Commit Graph

64 Commits

Author SHA1 Message Date
Peng Lyu
9acfd66aa0 Merge remote-tracking branch 'upstream/master' into rebornix/review 2018-05-18 10:16:19 -07:00
Matt Bierner
6c462a29b2 Fix markdown preview not being restored 2018-05-14 14:36:13 -07:00
Matt Bierner
302cbc143f Don't try to revive webviews without a reviver 2018-05-14 11:06:05 -07:00
Matt Bierner
21ee81c03b Working on webview persistence API
#49022
2018-05-14 10:34:59 -07:00
Alex Dima
0252ac49bc Introduce and adopt extensionLocation 2018-05-07 17:28:59 +02:00
Matt Bierner
8578f0241e Add preserveFocus option for webviews
Fixes #14311
2018-04-27 16:40:45 -07:00
Matt Bierner
6091135ee5 Correctly handle when webview.reveal is called without any args
Fixes #48707
2018-04-25 12:43:03 -07:00
Matt Bierner
856c9cacd8 Handle a few edge cases where extension host may try accessing a disposed webview 2018-04-25 12:43:03 -07:00
Matt Bierner
2fca133150 Make sure we still delete the webview handle when the extension event has an error 2018-04-25 12:43:03 -07:00
Peng Lyu
cbee2c0ce5 Merge remote-tracking branch 'upstream/master' into rebornix/review 2018-04-24 08:23:32 -07:00
Matt Bierner
e0a4456723 Make sure we fire view state updates when changing the webview position
#48246
2018-04-23 10:12:50 -07:00
Matt Bierner
7e343b00ca Fix webview not firing viewStateChange events when it is first created 2018-04-23 10:12:49 -07:00
Matt Bierner
d770ce503a Make sure we handle webview position updates when an entire editor group moves 2018-04-19 16:35:17 -07:00
Matt Bierner
52a75ecf23 Use correct $name for onDidDisposeWebviewPanel event
Fixes #48127
2018-04-18 11:32:29 -07:00
Matt Bierner
cdd9a731f9 Use standard 'postMessage' name 2018-04-17 16:22:44 -07:00
Matt Bierner
f2a2f394c7 Unregister webview reviver on dispose
Part of #48065
2018-04-17 10:36:56 -07:00
Matt Bierner
ea680fae1c Update to use more consistent WebviewPanel naming 2018-04-17 10:36:56 -07:00
Matt Bierner
71c09a6c4c weview -> webview 2018-04-16 11:50:51 -07:00
Matt Bierner
8cb7e80544 Split out Webview from WebviewEditor in proposed API (#47370)
* Split out `Webview` from `WebviewEditor` in API

**Problem**
The current proposed `Webview` interface has a few methods and properties that are very editor specific, such as `.reveal` and `.onDidChangeViewState`. These properies will not make sense if we ever allow webview to be displayed in other locations, such as in widgets

**Proposal**
Split the concepts of a `Webview` and of a `WebveiwEditor`. A webview is the html content itself. A `WebviewEditor` is an editor that displays a `Webview`

This would allow us to easily add other types of `Webview` owning objects in the future without having to document that some methods only apply when a webview is used as an editor vs as a widget
2018-04-11 11:49:02 -07:00
Matt Bierner
d855ec8060 Reduce duplicate state for active webviews 2018-04-06 16:06:44 -07:00
Matt Bierner
4da7386445 Rename webviewInput to webviewEditorInput 2018-04-06 16:06:44 -07:00
Matt Bierner
89d6db5c86 Show at a specific position 2018-04-06 14:15:07 -07:00
Matt Bierner
c810428647 Fix compile error 2018-04-06 13:52:38 -07:00
Matt Bierner
d7e0604ec6 Prototype webview widget
Start prototyping a webview widget. Code is still super rough
2018-04-06 13:29:21 -07:00
Matt Bierner
78707964d0 Reduce duplicate state for active webviews 2018-04-06 00:15:07 -07:00
Matt Bierner
7307023e1d Rename webviewInput to webviewEditorInput 2018-04-05 23:43:49 -07:00
Matt Bierner
bcdbb50e5d Extract out duplicate webview event handler logic 2018-04-05 19:48:15 -07:00
Matt Bierner
15bc74647a Use correct promise type 2018-04-05 19:30:16 -07:00
Matt Bierner
c14e30aeb4 Show error when webview restore fails 2018-04-05 19:18:55 -07:00
Matt Bierner
753b18ddc1 Handle exceptions in webview serialize 2018-04-05 19:04:45 -07:00
Matt Bierner
ca3341f659 Move main webview contributions from html to webview 2018-04-05 18:45:09 -07:00
Matt Bierner
bae8e69220 WebviewService -> WebviewEditorService 2018-04-05 18:33:43 -07:00
Matt Bierner
52b59d5e9a Timebox webview serialization 2018-04-05 14:32:46 -07:00
Matt Bierner
caee7a5789 Working on progress indicator when loading webview 2018-04-05 10:16:39 -07:00
Matt Bierner
dd21d3520a Add webview restoration api proposal (#46380)
Adds a proposed webiew serialization api that allows webviews to be restored automatically when vscode restarts
2018-04-03 18:25:22 -07:00
Matt Bierner
67d8eebaf4 Rename webview.show to webview.reveal
Make it more clear that this command only reveals an existing webview

Fixes #44580
2018-03-20 16:16:05 -07:00
Matt Bierner
954c5ae24f Don't set resource on webviews
Fixes #46217
2018-03-20 15:53:22 -07:00
Matt Bierner
ea1fed9616 Use viewType instead of uri for webviews
As discussed in #45994, move from using a uri to using a viewType. The view type is shared among all webviews of a given type, such as all markdown previews

Fixes #44575
2018-03-20 14:44:10 -07:00
Matt Bierner
82084be1bc Switch to use vscode-resource scheme in webviews
Fixes #45784
2018-03-14 11:25:40 -07:00
Matt Bierner
ec6412be83 Switch release notes to use webview editor
Changes the release notes to use the standard webview editor instead of their custom webview editor.

Also makes the release notes editor a singleton. Only one release notes editor may be open at a time.

Fixes #27493
Fixes #34369
2018-03-05 16:18:54 -08:00
Matt Bierner
78870d93cb Remove create on webview input 2018-03-05 16:18:54 -08:00
Matt Bierner
267f791f2c Move webview editor and input to own part 2018-03-05 14:07:17 -08:00
Matt Bierner
02bd0a10e5 Fix show preview not re-showing existing preview 2018-03-01 11:02:00 -08:00
Matt Bierner
9ea92b3019 Fix webview dispose potentially closing unrelated editors 2018-02-28 18:09:50 -08:00
Matt Bierner
85d47a74cb Fix webviews not restoring html properly 2018-02-28 11:44:30 -08:00
Matt Bierner
b60267b17c Delete webview input on dispose 2018-02-28 00:25:13 -08:00
Matt Bierner
103d106421 Fix retained webview incorrectly refreshing on resume
Fix #44681
2018-02-28 00:25:13 -08:00
Matt Bierner
a48c4d702f Fix webview.show re-opening webview instead of moving it
Fixes #44585
2018-02-28 00:25:13 -08:00
Matt Bierner
a989220093 Add title to webviewCreate
Part of #44579
2018-02-28 00:25:13 -08:00
Matt Bierner
66aa34ba7e Fix retained webviews not being properly when their editor hides
Fixes #44589
2018-02-27 14:24:22 -08:00