Commit Graph

2876 Commits

Author SHA1 Message Date
Alex Dima
9cf36cdf8f Rename CanonicalExtensionIdentifier to ExtensionIdentifier 2019-01-07 12:00:54 +01:00
Andre Weinand
ac39335c81 remove obsolete Tracker API 2019-01-07 10:28:46 +01:00
Matt Bierner
087629786a Mark private service properties declarated in ctors as readonly 2019-01-04 12:03:24 -08:00
Matt Bierner
c109d319fe Second pass converting for index based looping to for-of loops
More manual conversion of index based for loops to for-of loops
2019-01-04 12:03:23 -08:00
Matt Bierner
cd88417f49 Enabling a few more tslint rules in the codebase 2019-01-03 17:39:12 -08:00
Matt Bierner
9e4daf6069 Prefer using explicit function types instead of Function 2019-01-03 17:39:12 -08:00
Rob Lourens
ef2547d547 replace void 0 with undefined 2019-01-03 11:20:19 -08:00
Rob Lourens
7805023eaa Fix #65933 2019-01-02 21:20:14 -08:00
Matt Bierner
88bc3b3d35 Organize imports 2019-01-02 14:36:16 -08:00
Matt Bierner
c809337d5c Code action on save failures should not block other actions from running
Fixes #65733
2019-01-02 14:36:16 -08:00
bissonex
36ac195d16 fix typo (#65740)
fix typo for Editor Find, terminalSupport.ts, terminals.ts, extHostDebugService.ts
2018-12-28 12:13:31 -08:00
Johannes Rieken
195fd560a5 undo unneeded change 2018-12-27 11:57:16 +01:00
Johannes Rieken
96d2413a4e Tweak ctor of SelectionRange, https://github.com/Microsoft/language-server-protocol/issues/613 2018-12-27 10:07:23 +01:00
Josh Goldberg
d659000852 Converted about 25 *.test.ts files to --strictNullChecks (mostly automatically) (#65581)
* Manually added strict null checks in around 70 files

* Fixed tsconfig.strictNullChecks.json merge fail

* Touched up a few unnecessary type changes

* Removed files already in other PRs
2018-12-23 20:28:51 -08:00
Rob Lourens
f045bb5c85 Strict null check SearchModel #60565 2018-12-22 10:09:34 -06:00
Daniel Imms
fedf2f8771 Rename experimentalUseConpty to windowsEnableConpty 2018-12-21 12:00:35 -08:00
Daniel Imms
dceb815558 Merge remote-tracking branch 'origin/master' into tyriar/conpty 2018-12-21 10:49:44 -08:00
Alex Dima
25417553be Adopt case insensitive extension identifiers 2018-12-21 12:41:41 +01:00
Matt Bierner
6422adaffe Remove redundant type annotations for generic emitter properties
Code like:

```
private readonly _onDidEncounterLanguage: Emitter<LanguageId> = new Emitter<LanguageId>();
```

Does not need to repeat the `Emitter<LanguageId>` type annotation
2018-12-19 17:10:39 -08:00
Andre Weinand
5fece3f30e do not ignore debggers that lack a label; fixes #61649 2018-12-19 16:03:17 +01:00
Johannes Rieken
321535761a format - extract formatting logic, make it so that we potentially run multiple providers sequentially (off for now) 2018-12-19 15:52:28 +01:00
Daniel Imms
58f6dc5185 Merge remote-tracking branch 'origin/master' into tyriar/conpty 2018-12-18 17:13:35 -08:00
Rachel Macfarlane
c5c15eb75f Add document parameter to draft methods on comments provider 2018-12-18 14:57:50 -08:00
Johannes Rieken
27fd58c206 refine SelectionRangeKind #63935 2018-12-18 10:57:56 +01:00
Daniel Imms
e110245f13 Merge branch 'master' into kieferrm/terminal-cwd 2018-12-17 11:21:20 -08:00
Johannes Rieken
514ec620de add SelectionRange and SelectionRangeKind, #63935 2018-12-17 15:10:18 +01:00
Alex Ross
3c55d1c2e7 Made Task an object (#65073) 2018-12-17 12:22:28 +01:00
Andre Weinand
2808feeaf6 cleanup names for debug adapter factories 2018-12-14 12:48:31 +01:00
Daniel Imms
ece3a90fb5 Tweak setLocaleVariables setting
- False now really means false
- The default is true for all platforms

Fixes #65037
2018-12-13 18:07:20 -08:00
Matt Bierner
986f924ad5 Prefer using Array<T> for complex array types
Use `Array<T | U>` when dealing with union types instead of  `(T | U)[]`
2018-12-13 16:40:44 -08:00
Rachel Macfarlane
9623b3441d Add setting to control when comments panel opens (#64941) 2018-12-13 16:34:31 -08:00
Matt Bierner
d40fa4a27e Review uses of Promise.resolve(null)
Many `Promise.resolve(null)` should actually be `Promise.resolve(void 0)`. In other cases, we were missing a null return annotation.
2018-12-13 15:41:13 -08:00
Matt Bierner
68a4e01246 Use resolve(void 0) instead of resolve(null) for void promises
Fixes a common type error
2018-12-13 15:20:46 -08:00
Daniel Imms
e6254db320 Recreate pid promise when reusing terminals 2018-12-13 10:02:17 -08:00
Daniel Imms
461bf7207b Merge remote-tracking branch 'origin/master' into pr/g-arjones/60111 2018-12-13 09:33:42 -08:00
Daniel Imms
e7102b1824 Send terminal name with id when it's ready
Fixes #64390
2018-12-13 08:07:55 -08:00
Dirk Baeumer
51f7beb40c Fixes #64918: Remove old task conversion code 2018-12-13 14:45:51 +01:00
Alex Dima
e2a42ca321 Change extension point registration to use a descriptor object 2018-12-13 13:39:39 +01:00
Johannes Rieken
c6c7edaa9f debt - asThenable -> asPromise because it returns a promise 2018-12-13 11:45:48 +01:00
Johannes Rieken
653280d133 debt - Thenable -> Promise 2018-12-13 11:31:54 +01:00
Alex Dima
29dd4e77de Keep track of activating extensions 2018-12-13 11:22:26 +01:00
Benjamin Pasero
227fd6634b fix #64597 2018-12-12 08:00:50 +01:00
Matt Bierner
0b1d0da7af Prefer to use .then(void 0, ..) over .then(null, ..)
ES6 promises like using undefined as their first argument instead of null. Both should behave the same behavior
2018-12-11 21:59:32 -08:00
Daniel Imms
e417e07b4b Add use conpty setting 2018-12-11 11:46:39 -08:00
Johannes Rieken
48a452dcee towards strict null and completion model, #63454 2018-12-11 17:00:19 +01:00
Joao Moreno
408e03220c event namespace consolidation & docs 2018-12-11 10:14:38 +01:00
Matt Bierner
100adeb3e9 Use more generic word pattern for markdown
Try to better support handle of unicode in markdown by using a word definition that use unicode character class

Fixes #15177
2018-12-10 18:24:10 -08:00
Benjamin Pasero
0bcf5cff8a Update to Electron 3.0.10 (#56149)
* update to 3.0.0-beta.3

* update d.ts files; rename NodeBuffer => Buffer

* update to 3.0.0-beta.4

* undo invalid change

* remove some Electron 2.0.x specific workarounds

* pinch zoom is now disabled by default

* update vscode-nsfw

* change vscode-nsfw

* update smoke test electron version

* streams: use destroy() over close()

* workaround broken tests

* bump distro and OSS

* try to bump node version for build

* update macOS build to use node.js 10.8.0

* fix extension tests

* use node.js 10.2.1 for all builds

* remove nsfw from dev dependencies

* back to node 8.x for build

* Revert "back to node 8.x for build"

This reverts commit 90ea2b7af2.

* update distro

* disable test run on macOS prod build for now

* bump distro

* ensure proper nsfw dep

* fix more native dependencies

* temp disable failing test

* fix packages

* update deps

* fix deps

* update deps

* enable macOS unit tests again

* fix deprecated buffer use

* Electron 3.0.0.beta.5

* bump deps

* fix tree accidentally treating auxclick as click

* improve overlay cleanup scheduler (fixes flicker seen with Electron 3.0.x)

* update distro

* remove obsolete disableBlinkFeatures: 'Auxclick'

* update to Electron 3.0 beta 6

* fix compile

* workaround #56994

* do not use backgroundColor to find shared process (causes flicker)

* fix flicker on windows from shared process background color

* webview - bubble up keyboard events (workaround for #56988)

* bump electron to 3.0.0-beta.8

* webview - fix deprecation

* webview - fix another deprecation

* debt - handle SIGPIPE on more processes

* workaround more webview focus issues (for #56988)

* webview - use proper way to focus()

* debt - avoid window-focus/blur and use native focus events instead

* webview - restore previous focus method

* webview - improve focus tracking (do not rely on DOM events)

* bump to electron 3.0.0-beta.9

* update deps

* update electron@3.0.0-beta.10

* webview - do not rely on DOM focus for certain commands (for #56988)

* update to electron@3.0.0-beta.11

* electron@3.0.0-beta.12

* update to beta 13

* update to electron 3.0.0

* update to Electron 3.0.1

* electron@3.0.2

* revert build changes (node.js version)

* try with: enable mojave dark mode support

* fix types

* electron 3.0.3

* electron@3.0.4

* fix deps

* bump electron@3.0.6

* bump electron@3.0.9

* fix strict null issue

* reset format

* bump electron@3.0.10

* fix strict null issue

* webview - print error when revive fails

* electron 3.0.x - try to fix keybindings in webviews (#64417)

* bump @types/node => ^10.12.12

* 💄

* update distro
2018-12-10 12:54:38 +01:00
Joao Moreno
65a420e359 remove TPromise
related to #64596
2018-12-10 11:40:28 +01:00
Matt Bierner
0928a6d348 Prefer coalesce over filter
Coalesce has the correct return type of `T[]`. Filter may return `(T | undefined)[]`
2018-12-07 16:32:45 -08:00