Commit Graph

580 Commits

Author SHA1 Message Date
Matt Bierner
8bbe3157f0 Trying to hook up basic save for custom editors 2019-11-18 11:27:45 -08:00
Sandeep Somavarapu
0282585dd7 Fix #83171 2019-11-18 15:04:08 +01:00
Alexandru Dima
41be9a6142 Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-18 08:59:14 +01:00
Benjamin Pasero
9727eb6050 untitled - fix save with associated file path 2019-11-18 07:57:48 +01:00
Benjamin Pasero
00688bf051 working copies - properly implement save, saveAs, saveAll (#84672) 2019-11-17 17:44:57 +01:00
Matt Bierner
27a33ee6fe Hook up very basic undo/redo for webview editors
For #77131
2019-11-15 18:21:46 -08:00
Matt Bierner
7ac686d6cc Working on hooking up undo/redo for custom editors 2019-11-15 15:53:25 -08:00
Benjamin Pasero
72c2f506de working copy - introduce first save/revert semantics (#84672) 2019-11-15 15:36:55 +01:00
Johannes Rieken
261ef3e7e6 Merge pull request #84812 from microsoft/joh/opener
OpenerService supporting URI and URL
2019-11-15 15:31:38 +01:00
Johannes Rieken
e80c62bdcb allow $openUri to accept URI and string 2019-11-15 10:53:04 +01:00
Johannes Rieken
e51ef85bcb Revert "allow $openUri to accept a URI and string, adopt consumer but keep the API as is"
This reverts commit 544b0abf5b.
2019-11-15 10:29:29 +01:00
Johannes Rieken
544b0abf5b allow $openUri to accept a URI and string, adopt consumer but keep the API as is 2019-11-15 10:28:03 +01:00
Alexandru Dima
cbb231754f Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-15 10:10:39 +01:00
Matt Bierner
5370653cf8 Use create functions for more descriptors
For #81574

This applies the fix from #84878 to a number of other descriptor classes in our codebase
2019-11-14 17:10:53 -08:00
Matt Bierner
36a8322ae8 Convert SyncActionDescriptor to use a create function (#84878)
For #81574

See #84669 for details of the problem around strict function types. This change converts `SyncActionDescriptor` to use a static `create` function. This allows us to make the `create` function generic so that it can take the correct types for strictFunctionTypes
2019-11-14 16:49:25 -08:00
Alex Dima
4dbb961407 Fix issue with appended deltas having the wrong order & add unit tests to semantic areas delta computation 2019-11-14 14:03:52 +01:00
Alex Dima
15beb36ccf Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-14 09:16:10 +01:00
Matt Bierner
7e71822af3 Hook up CustomEditorModel to workingCopyService 2019-11-12 15:54:32 -08:00
Matt Bierner
c26325fb46 Support excluding subsets of code actions for codeActionsOnSave
Fixes #84602
2019-11-12 14:28:43 -08:00
Benjamin Pasero
da5f408834 workbench editor model: getResource => resource 2019-11-12 17:04:54 +01:00
Martin Aeschlimann
12b7d0aafe window.showOpenDialog throws "TypeError: Default path must be a string" with defaultUri = null. Fixes #84325 2019-11-12 16:05:18 +01:00
Johannes Rieken
a2e9c12994 use isFile-info instead of defaulting to FileType.File, fixes #84524 2019-11-12 11:45:11 +01:00
Benjamin Pasero
5ae52b61cb files - implement ctime properly as btime (fix #84525) 2019-11-12 10:42:04 +01:00
Joao Moreno
a8f5f3e0a7 add log tracing to main thread tree views 2019-11-12 10:39:46 +01:00
Alex Dima
3cef67fae0 Do not evict newer semantic tokens from cache 2019-11-08 12:03:28 +01:00
Matt Bierner
278b4f8cfa Hookup experimental undo for customEditors
This currently is not connected to any actual actions in the editor
2019-11-07 17:22:21 -08:00
Matt Bierner
b5dbace111 Better name for codeAction types file 2019-11-07 16:00:12 -08:00
Matt Bierner
bca7206f59 Forward onEdit from webviewEditor to mainthread 2019-11-07 15:57:47 -08:00
Alexandru Dima
c34e736195 Forward SemanticColoring disposals to the ext host 2019-11-07 16:06:46 +01:00
Johannes Rieken
e5719685cc implement api commands for call hierarchy, #83274 2019-11-07 14:05:50 +01:00
Benjamin Pasero
87064db103 debt - untitled editor => untitled text editor 2019-11-06 12:44:59 +01:00
Alex Dima
57995de234 Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-06 08:51:39 +01:00
Daniel Imms
e41c71b0d0 Merge branch 'master' into tyriar/63052 2019-11-05 10:32:42 -08:00
Daniel Imms
1d60909d1f Implement Terminal.creationOptions API
Fixes #63052
2019-11-05 10:30:43 -08:00
Daniel Imms
7215e5e9f5 Pass through undefined exit codes 2019-11-05 09:17:57 -08:00
Daniel Imms
2a0d3d0140 Support Terminal.exitStatus API
Fixes #62103
2019-11-05 09:09:39 -08:00
Alexandru Dima
308ff31f95 Merge remote-tracking branch 'origin/master' into alex/semantic-exploration 2019-11-05 09:44:55 +01:00
Matt Bierner
dcecb9eea6 Documenting thoughts on direction for custom editor API
This documents the current thinking on the custom editor api. The current api proposal is not actually implemented yet
2019-11-04 15:11:54 -08:00
Matt Bierner
a97738297d Fixing some more node 12 typings errors 2019-11-04 15:11:54 -08:00
Johannes Rieken
073735c5e1 Merge branch 'master' into joh/willRename 2019-11-04 12:10:18 +01:00
Johannes Rieken
ca98871316 show progress message 2019-11-04 11:10:06 +01:00
Johannes Rieken
de1b1fb71e remove warning 2019-11-04 10:52:26 +01:00
Johannes Rieken
45c755098e timeout before operations after 5sec 2019-11-04 10:52:03 +01:00
Benjamin Pasero
41466a2390 debt - declare more fs provider capabilities 2019-11-04 09:57:08 +01:00
Johannes Rieken
9f6518c533 move events back to textfile service 2019-11-01 16:07:50 +01:00
Johannes Rieken
31160103a3 migrate proposed API onto new events 2019-11-01 12:05:32 +01:00
Benjamin Pasero
b7b21844e7 api - fold app uri creation into asExternalUri (fix #82884) 2019-10-29 07:18:19 +01:00
Joao Moreno
400ca187dc fixes #83440 2019-10-28 16:00:45 +01:00
Benjamin Pasero
33cc09da7a Revert "Removing EXT_HOST_CREATION_DELAY hacks" (#83422)
This reverts commit 2b61a8817b.
2019-10-28 12:08:07 +01:00
Daniel Imms
2b61a8817b Removing EXT_HOST_CREATION_DELAY hacks
This one was a bit tricky to figure out what was going on, but this is how it
was working before: Terminals that use extension processes calls
$createTerminal from the ext host, this returns a promise with an ID that gets
returned asynchronously after the process has been setup (ie. an ext host process
proxy was created).

The reason we needed the timeout was because the process initialization is async
as we need a layout to occur so that we have the dimensions of the terminal to
give to the process. The fix could have been setTimeout(..., 0) as well but that
feels hacky as well, the fix in this commit is to pipe an event through from
the process manager which is the actual time when we are good to start telling
ext hosts are the new terminals.

Fixes #77655
2019-10-25 12:57:30 -07:00